From 1b8038d8e82c81512be03dc9525b39647014d274 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Tue, 26 May 2026 21:46:23 -0400
Subject: [PATCH] feat(fusion_login_audit): nightly retention GC cron

Adds _fc_retention_gc() that deletes rows older than the configured
horizon (default 365 days; 0 = keep forever). Registered as a daily
ir.cron. Tests verify both the delete path and the "keep forever"
short-circuit.

Also documents the Odoo 19 gotcha that ir.cron dropped the numbercall
field (the legacy "-1 = run forever" pattern now raises ValueError at
install time; just omit the field).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 CLAUDE.md                                     |  2 +
 fusion_login_audit/__manifest__.py            |  1 +
 fusion_login_audit/data/ir_cron_data.xml      | 16 +++++++
 .../models/fusion_login_audit.py              | 22 ++++++++-
 fusion_login_audit/tests/test_login_audit.py  | 48 +++++++++++++++++++
 5 files changed, 88 insertions(+), 1 deletion(-)
 create mode 100644 fusion_login_audit/data/ir_cron_data.xml

diff --git a/CLAUDE.md b/CLAUDE.md
index 3ef13c0c..579ee46b 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -27,6 +27,8 @@
    The attribute name after the leading underscore becomes the SQL object name suffix (`{table}_{suffix}`). `models.Index` accepts `DESC`, `WHERE` predicates, and `USING btree (...)`. Sources: `odoo/orm/model_classes.py` (warns at registry build), `odoo/orm/table_objects.py` (Constraint + Index classes).
 10. **`res.users._login` is an instance method in Odoo 19**, not a classmethod as in earlier versions. Signature is `def _login(self, credential, user_agent_env)` — there is no `db` parameter. Override it like any normal instance method (`super()._login(credential, user_agent_env)`). When called via `authenticate()` on an empty recordset, `self` carries the right env. Older recipes that build a separate `api.Environment` from `odoo.modules.registry.Registry(db)` no longer apply. Source: `odoo/addons/base/models/res_users.py:760`.
 11. **Inherited `ir.ui.view` records cannot have `groups`/`group_ids` on the record itself.** Odoo 19 raises `ParseError: Inherited view cannot have 'groups' defined on the record. Use 'groups' attributes inside the view definition` at install time. Move the gate to the inner XML nodes — every `<button>`, `<page>`, `<field>`, `<xpath>`, `<group>` etc. supports a `groups="base.group_system"` attribute. For an inherited form with a smart button + admin tab, put `groups=` on the button and the page individually; leave the `<record model="ir.ui.view">` clean.
+12. **`mail.template` QWeb/inline_template `ctx` IS `self.env.context`** — not a nested dict you can pass. `MailRenderMixin._render_eval_context()` sets `ctx = self.env.context`, so `ctx.get('foo')` in subject/body resolves to `env.context.get('foo')`. To pass dynamic data to a template, spread keys directly into the context: `tmpl.with_context(**my_data).send_mail(res_id, ...)`. Calling `tmpl.with_context(ctx=my_data)` puts the dict at `env.context['ctx']`, and the template's `ctx.get('foo')` becomes `env.context.get('foo')` → `None` (looks like a silent rendering bug — subject ends up blank).
+13. **`ir.cron` dropped `numbercall`** in Odoo 19. Old recipes set `<field name="numbercall">-1</field>` for "run forever"; that now raises `ValueError: Invalid field 'numbercall' in 'ir.cron'` at install time. Just omit the field — recurring crons keep running as long as `active=True`. Source: `odoo/addons/base/models/ir_cron.py` field list.
 
 15. **There is NO `sale.subscription` model in Odoo 19** (Enterprise `sale_subscription`). A subscription is a **`sale.order`** with `is_subscription=True`, `plan_id` → **`sale.subscription.plan`** (the recurrence), plus `subscription_state` / `next_invoice_date` / `recurring_monthly`. Any Many2one or relation that targets "a subscription" must point at `sale.order` (filter `domain=[('is_subscription','=',True)]`) — **not** `sale.subscription`, which does not exist and fails at install. The surviving `sale.subscription.*` records are only the plan + wizards/reports (`sale.subscription.plan`, `sale.subscription.report`, `sale.subscription.change.customer.wizard`, `sale.subscription.close.reason.wizard`). Verified on live `nexamain` (odoo-nexa, 19.0): `SELECT model FROM ir_model WHERE model LIKE 'sale.subscription%'`.
 
diff --git a/fusion_login_audit/__manifest__.py b/fusion_login_audit/__manifest__.py
index 122256cf..01c2ae6d 100644
--- a/fusion_login_audit/__manifest__.py
+++ b/fusion_login_audit/__manifest__.py
@@ -27,6 +27,7 @@ bursts. Daily retention cron honours a configurable horizon.
         'security/ir.model.access.csv',
         'security/security.xml',
         'data/mail_template_data.xml',
+        'data/ir_cron_data.xml',
         'views/fusion_login_audit_views.xml',
         'views/res_users_views.xml',
         'views/res_config_settings_views.xml',
diff --git a/fusion_login_audit/data/ir_cron_data.xml b/fusion_login_audit/data/ir_cron_data.xml
new file mode 100644
index 00000000..a7fee2cc
--- /dev/null
+++ b/fusion_login_audit/data/ir_cron_data.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <data noupdate="1">
+
+        <record id="cron_retention_gc" model="ir.cron">
+            <field name="name">Fusion Login Audit: Retention GC</field>
+            <field name="model_id" ref="model_fusion_login_audit"/>
+            <field name="state">code</field>
+            <field name="code">model._fc_retention_gc()</field>
+            <field name="interval_number">1</field>
+            <field name="interval_type">days</field>
+            <field name="active" eval="True"/>
+        </record>
+
+    </data>
+</odoo>
diff --git a/fusion_login_audit/models/fusion_login_audit.py b/fusion_login_audit/models/fusion_login_audit.py
index 3848c21a..4bd29d55 100644
--- a/fusion_login_audit/models/fusion_login_audit.py
+++ b/fusion_login_audit/models/fusion_login_audit.py
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-from odoo import fields, models
+from odoo import api, fields, models
 
 
 class FusionLoginAudit(models.Model):
@@ -83,3 +83,23 @@ class FusionLoginAudit(models.Model):
     _user_time_idx = models.Index('(user_id, event_time DESC)')
     _login_time_idx = models.Index('(attempted_login, event_time DESC)')
     _geo_state_idx = models.Index('(geo_lookup_state, event_time)')
+
+    @api.model
+    def _fc_retention_gc(self):
+        """Delete audit rows older than `fusion_login_audit.retention_days`.
+        Called daily by ir.cron. retention_days=0 means keep forever."""
+        from datetime import timedelta
+        ICP = self.env['ir.config_parameter'].sudo()
+        try:
+            days = int(ICP.get_param(
+                'fusion_login_audit.retention_days', 365))
+        except (TypeError, ValueError):
+            days = 365
+        if days <= 0:
+            return 0
+        cutoff = fields.Datetime.now() - timedelta(days=days)
+        old = self.sudo().search([('event_time', '<', cutoff)])
+        count = len(old)
+        if old:
+            old.unlink()
+        return count
diff --git a/fusion_login_audit/tests/test_login_audit.py b/fusion_login_audit/tests/test_login_audit.py
index 34412a7e..38802f9f 100644
--- a/fusion_login_audit/tests/test_login_audit.py
+++ b/fusion_login_audit/tests/test_login_audit.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+from odoo import fields
 from odoo.tests.common import TransactionCase, tagged
 
 
@@ -392,3 +393,50 @@ class TestFusionLoginAuditModel(TransactionCase):
             pass
         after = Mail.search_count([('subject', 'ilike', 'disabled@example.com')])
         self.assertEqual(after, before, "Disabled alerts should queue nothing")
+
+    def test_retention_gc_deletes_old_rows(self):
+        """The GC method deletes rows older than retention_days."""
+        from datetime import timedelta
+        ICP = self.env['ir.config_parameter'].sudo()
+        ICP.set_param('fusion_login_audit.retention_days', '30')
+
+        now = fields.Datetime.now()
+        Audit = self.env['fusion.login.audit'].sudo()
+        old = Audit.create({
+            'attempted_login': 'gc-old@example.com',
+            'result': 'success',
+            'event_time': now - timedelta(days=45),
+        })
+        recent = Audit.create({
+            'attempted_login': 'gc-recent@example.com',
+            'result': 'success',
+            'event_time': now - timedelta(days=5),
+        })
+        old_id, recent_id = old.id, recent.id
+
+        Audit._fc_retention_gc()
+
+        self.assertFalse(Audit.browse(old_id).exists(),
+                         "Row older than retention_days should be gone")
+        self.assertTrue(Audit.browse(recent_id).exists(),
+                        "Row inside retention_days should survive")
+
+    def test_retention_zero_keeps_forever(self):
+        """retention_days=0 keeps all rows."""
+        from datetime import timedelta
+        ICP = self.env['ir.config_parameter'].sudo()
+        ICP.set_param('fusion_login_audit.retention_days', '0')
+
+        now = fields.Datetime.now()
+        Audit = self.env['fusion.login.audit'].sudo()
+        ancient = Audit.create({
+            'attempted_login': 'forever@example.com',
+            'result': 'success',
+            'event_time': now - timedelta(days=3650),
+        })
+        ancient_id = ancient.id
+
+        Audit._fc_retention_gc()
+
+        self.assertTrue(Audit.browse(ancient_id).exists(),
+                        "retention_days=0 must keep everything")