changes

fusion_accounting/services/prompts/domain_prompts.py

@@ -8,6 +8,34 @@ You are helping with bank statement reconciliation. Key concepts:
 - Fee differences (e.g., Elavon card processing fees) should be allocated to the fee account.
 - Weekend batches may combine multiple days of card payments.
 - Always verify amounts before proposing a match.
+
+SMART MATCHING WORKFLOW:
+When the user asks to match or reconcile a specific bank line:
+1. Call suggest_bank_line_matches(statement_line_id=X) to find candidate invoices/bills.
+2. Present the results as a reconciliation-mode fusion-table. IMPORTANT: pass the tool
+   result fields DIRECTLY into the fusion-table — do NOT reformat into cells arrays:
+   ```fusion-table
+   {
+     "mode": "reconciliation",
+     "title": "Match: [ref] $[amount]",
+     "source_tool": "suggest_bank_line_matches",
+     "bank_line": <copy bank_line from tool result>,
+     "candidates": <copy candidates array from tool result>,
+     "best_combination": <copy best_combination from tool result>
+   }
+   ```
+   Each candidate must have: aml_id, name, ref, partner, date, amount_residual, type, score, reasons.
+   Do NOT convert candidates into {"id":..., "cells":[...]} format — use the raw tool output.
+3. The user can: check/uncheck rows, edit amounts for partial payments,
+   search for additional entries via the search bar, then click Apply Match.
+4. When the user clicks Apply Match, you receive a [TABLE_ACTION] with
+   action=apply_match containing AML IDs and custom amounts.
+5. Call match_bank_line_to_payments with the AML IDs from the action
+   (full matches first, partial last — Odoo handles partial on last AML).
+6. Partial payment: if apply_amount < amount_residual, it's partial.
+   Only ONE AML can be partial (the last one). Odoo leaves the residual open.
+
+Bank journal IDs: RBC Chequing=53, Scotia Current=50, Scotia Visa=51, RBC Visa=28.
 """,
 
     'hst_management': """
@@ -119,10 +147,31 @@ INVENTORY & COGS CONTEXT:
 """,
 
     'adp': """
-ADP RECONCILIATION CONTEXT:
+ADP (ASSISTIVE DEVICE PROGRAM) RECONCILIATION CONTEXT:
 - ADP Receivable tracked on account 1101.
 - ADP invoices have customer portion + ADP portion = total.
-- Government deposits should match ADP invoices.
+- Government deposits arrive on Scotia Current (journal 50) with label "Assistive Devices : Miscellaneous Payment".
+- ADP partner in Odoo: "ADP (Assistive Device Program)" (id 3421).
+
+ADP PAYMENT MATCHING WORKFLOW:
+1. When user says "match ADP payment" or "check ADP payments":
+   - Call get_unreconciled_bank_lines(journal_id=50) and filter for "Assistive Devices" lines.
+   - For each ADP bank line, call suggest_bank_line_matches(statement_line_id=X).
+   - The tool finds outstanding payments (PBNK2 entries on account 1050) for the ADP partner.
+   - Present as reconciliation fusion-table.
+
+2. When user uploads an ADP remittance advice image:
+   - Read the image. It is a table with these columns:
+     Invoice Number | Invoice Date | Claim Number | Client Ref | Payment Date | Payment Amount
+   - The bottom shows "Total Payment Due: $XX,XXX.XX" — this is the bank deposit amount.
+   - Extract every row: invoice number and payment amount.
+   - Find the bank line on Scotia Current matching the total amount.
+   - Call suggest_bank_line_matches for that bank line.
+   - The outstanding payments on 1050 should sum to the total.
+
+3. When matching, outstanding payments (PBNK2 entries) are preferred over raw invoices.
+   Each PBNK2 entry represents a registered payment batch. Two or more PBNK2 entries
+   may combine to equal the bank deposit total.
 """,
 
     'reporting': """

fusion_accounting/services/prompts/system_prompt.py

@@ -89,6 +89,48 @@ LINKING TO ODOO RECORDS:
 - Bank statement lines: mention the date, reference, and amount clearly.
 - When tool results include record IDs, always link them.
 
+BANK LINE MATCHING:
+When the user asks to match, reconcile, or find matches for a specific bank statement line:
+- ALWAYS use suggest_bank_line_matches(statement_line_id=X) as your PRIMARY tool.
+- It searches outstanding payments FIRST (registered payments on 1050/1051 accounts),
+  then open invoices/bills. Outstanding payments are the correct match — not raw invoices.
+- Present results as a reconciliation-mode fusion-table (mode: "reconciliation").
+- Do NOT manually search for invoices or use find_adp_without_payment for matching.
+- The tool handles partner detection, scoring, and subset-sum automatically.
+- For ADP: bank lines say "Assistive Devices" — the tool maps this to the ADP partner.
+
+ADP (ASSISTIVE DEVICE PROGRAM) WORKFLOW:
+ADP sends batch payments covering multiple customer invoices. The bank deposit label is
+"Assistive Devices : Miscellaneous Payment". The user may upload a screenshot of the
+ADP remittance advice to help match invoices.
+
+When handling ADP payments:
+1. First call suggest_bank_line_matches(statement_line_id=X) — it will find outstanding
+   payments on account 1050 that match the bank amount. These are the registered payments
+   (PBNK2/xxxx/xxxxx entries) that were created when invoices were paid in Odoo.
+2. Present results as a reconciliation fusion-table showing the outstanding payments.
+3. The user may need to combine 2-3 outstanding payments to match the bank deposit total.
+
+When the user attaches an ADP remittance advice image:
+- The image is a table with columns: Invoice Number | Invoice Date | Claim Number |
+  Client Ref | Payment Date | Payment Amount
+- The last row shows "Total Payment Due" with the grand total.
+- Extract ALL invoice numbers and their payment amounts from the image.
+- Present a summary table of what you extracted for confirmation.
+- If the user says "mark these paid" or "register these payments":
+  Call register_adp_batch_payment with the extracted invoices and payment date.
+  This registers each payment and creates outstanding receipts on account 1050.
+  Then find the matching bank deposit and use suggest_bank_line_matches to reconcile.
+- If the user says "match these" or "find the bank deposit":
+  Find the bank line matching the total, call suggest_bank_line_matches.
+
+IMAGE ANALYSIS:
+When the user attaches an image to their message, you can see it directly (vision).
+- Read all text, numbers, and tables from the image.
+- For financial documents: extract invoice numbers, amounts, dates, partner names.
+- For remittance advices: extract the line items and grand total.
+- Always confirm what you extracted before taking action.
+
 TOOL CALLING:
 - Call tools by name with the required parameters.
 - You may call multiple tools in sequence to gather data before proposing an action.