admin/Odoo-Modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(receiving): drop dead staged state — Option B (draft→counted→closed)

Browse Source 
Reported 2026-05-20: the receiving state machine had four states
(draft → counted → staged → closed) where the middle pair was pure
ceremony. Real-usage data on entech:

  state distribution: 14 draft, 4 closed (zero `staged` records)
  median dwell counted → staged: 11 seconds
  median dwell staged  → closed: 4 minutes

`staged` captured no fields, fired no gates, mapped to the same SO
`x_fc_receiving_status='partial'` as `counted`. Pure click-through.

Cleanup:
- State Selection retains `staged` as `Staged (legacy)` so historical
  records remain readable; new transitions never write it.
- statusbar_visible drops it from the chevron header.
- action_mark_staged becomes a thin shim that advances counted →
  closed directly (any old button binding still works).
- action_close now accepts `counted` as a valid source state (was
  previously only `staged` / legacy `accepted` / `resolved`).
- View: "Stage for Racking" button removed. "Close" button renamed
  to "Close — Racking Confirmed" so the racking-crew confirmation
  meaning stays obvious.
- _update_so_receiving_status mapping unchanged for legacy `staged`
  (still maps to partial) — only the comment block updated to
  describe the new canonical flow.

Migration 19.0.3.20.0 advances any `staged` records to `closed`
and syncs the linked SO's x_fc_receiving_status to `received` so
downstream gates (job step start, mark_done qty check, cert
creation) don't see a stale "partial" status.

Module: fusion_plating_receiving 19.0.3.19.0 → 19.0.3.20.0.

Tests: TestQtyReceivedPropagation updated — 5 tests dropped the
action_mark_staged() call, walk draft → counted → closed directly.
All 11 tests green (carrier 6 + propagation 5).

Verified on entech: existing 14 draft + 4 closed records untouched.
Direct draft → counted → closed transition works end-to-end on
RCV-30041 (was the test target).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsinghpal
2026-05-20 08:40:43 -04:00
parent d7bee9e854
commit 3d1b6e7ec5
5 changed files with 103 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
fusion_plating/fusion_plating_receiving/views/fp_receiving_views.xml
View File

@@ -40,21 +40,21 @@
<field name="arch" type="xml">
<form string="Receiving">
<header>
<!-- Sub 8 — new primary flow: box count only -->
<!-- Sub 8 + 2026-05-20: draft → counted → closed.
`Stage for Racking` removed (was pure ceremony
between Counted and Closed, median dwell 11 sec,
no captured data). Receiver counts boxes, then
closes once the racking crew confirms. -->
<button name="action_mark_counted"
string="Mark Counted"
type="object"
class="btn-primary"
invisible="state not in ('draft', 'inspecting')"/>
<button name="action_mark_staged"
string="Stage for Racking"
<button name="action_close"
string="Close — Racking Confirmed"
type="object"
class="btn-primary"
invisible="state != 'counted'"/>
<button name="action_close"
string="Close"
type="object"
invisible="state not in ('staged', 'accepted', 'resolved')"/>
invisible="state not in ('counted', 'staged', 'accepted', 'resolved')"/>
<!-- Legacy actions (hidden by default; surfaces for old records) -->
<button name="action_accept"
string="Accept (legacy)"
@@ -85,7 +85,7 @@
icon="fa-file-pdf-o"
invisible="not x_fc_outbound_shipment_id"/>
<field name="state" widget="statusbar"
statusbar_visible="draft,counted,staged,closed"/>
statusbar_visible="draft,counted,closed"/>
</header>
<sheet>
<div class="oe_button_box" name="button_box">