feat(fp.job): post-shop transition helpers (Tasks 2+3)
_fp_check_advance_post_shop: in_progress + all steps terminal → awaiting_cert (cert required) or awaiting_ship. Auto-spawns cert + delivery and fires notifications. Idempotent. Does NOT raise — gate failures bubble up via fp.job.step.button_finish (Task 4). _fp_check_advance_after_cert_issue: awaiting_cert → awaiting_ship when every required cert is state=issued. _fp_check_regress_after_cert_void: awaiting_ship → awaiting_cert when a previously-issued cert is voided. Re-notifies QM. hasattr guards on _fp_schedule_cert_activity + _fp_resolve_cert_activities keep this safe during incremental rollout — those land in Task 20. Test scaffolding added covering helper existence + idempotency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -7,3 +7,4 @@ from . import test_blocker_compute
|
||||
from . import test_late_risk_ratio
|
||||
from . import test_active_step_id
|
||||
from . import test_autopause_cron
|
||||
from . import test_post_shop_states
|
||||
|
||||
@@ -0,0 +1,100 @@
|
||||
# -*- coding: utf-8 -*-
|
||||
"""Post-shop state transitions (awaiting_cert + awaiting_ship).
|
||||
|
||||
Spec: docs/superpowers/specs/2026-05-25-post-shop-cert-shipping-job-states-design.md
|
||||
Plan: docs/superpowers/plans/2026-05-25-post-shop-cert-shipping-job-states-plan.md
|
||||
"""
|
||||
from odoo.tests.common import TransactionCase
|
||||
|
||||
|
||||
class TestPostShopAdvance(TransactionCase):
|
||||
def setUp(self):
|
||||
super().setUp()
|
||||
self.partner = self.env['res.partner'].create({'name': 'Cust'})
|
||||
self.product = self.env['product.product'].create({'name': 'Widget'})
|
||||
|
||||
def _make_job(self, state='in_progress', **kw):
|
||||
vals = {
|
||||
'partner_id': self.partner.id,
|
||||
'product_id': self.product.id,
|
||||
'qty': 1.0,
|
||||
'state': state,
|
||||
}
|
||||
vals.update(kw)
|
||||
return self.env['fp.job'].create(vals)
|
||||
|
||||
# ===== Task 2 — _fp_check_advance_post_shop helper ==================
|
||||
|
||||
def test_advance_helper_exists(self):
|
||||
job = self._make_job()
|
||||
self.assertTrue(hasattr(job, '_fp_check_advance_post_shop'))
|
||||
|
||||
def test_advance_noop_when_state_not_in_progress(self):
|
||||
# confirmed jobs should not be auto-advanced
|
||||
job = self._make_job(state='confirmed')
|
||||
job._fp_check_advance_post_shop()
|
||||
self.assertEqual(job.state, 'confirmed')
|
||||
|
||||
def test_advance_noop_when_no_steps(self):
|
||||
# job with zero steps stays put — nothing to evaluate
|
||||
job = self._make_job(state='in_progress')
|
||||
self.assertFalse(job.step_ids)
|
||||
job._fp_check_advance_post_shop()
|
||||
self.assertEqual(job.state, 'in_progress')
|
||||
|
||||
# ===== Task 3 — cert-issue + cert-void helpers =====================
|
||||
|
||||
def test_advance_after_cert_issue_helper_exists(self):
|
||||
job = self._make_job()
|
||||
self.assertTrue(hasattr(job, '_fp_check_advance_after_cert_issue'))
|
||||
|
||||
def test_regress_after_cert_void_helper_exists(self):
|
||||
job = self._make_job()
|
||||
self.assertTrue(hasattr(job, '_fp_check_regress_after_cert_void'))
|
||||
|
||||
def test_advance_after_cert_issue_idempotent_when_state_wrong(self):
|
||||
# Calling on a draft job is a no-op.
|
||||
job = self._make_job(state='draft')
|
||||
job._fp_check_advance_after_cert_issue()
|
||||
self.assertEqual(job.state, 'draft')
|
||||
|
||||
# ===== Task 4 — button_finish gates + auto-advance =================
|
||||
|
||||
def test_button_finish_on_last_step_triggers_advance(self):
|
||||
"""Finishing the only step of an in_progress job flips state
|
||||
to awaiting_ship (no cert required for this partner)."""
|
||||
if 'fp.job.step' not in self.env:
|
||||
self.skipTest('fp.job.step not available')
|
||||
job = self._make_job(state='in_progress')
|
||||
step = self.env['fp.job.step'].create({
|
||||
'job_id': job.id,
|
||||
'name': 'Final Inspection',
|
||||
'state': 'in_progress',
|
||||
'sequence': 10,
|
||||
})
|
||||
step.button_finish()
|
||||
self.assertEqual(job.state, 'awaiting_ship')
|
||||
|
||||
# ===== Task 5 — button_mark_shipped ================================
|
||||
|
||||
def test_button_mark_shipped_requires_awaiting_ship(self):
|
||||
from odoo.exceptions import UserError
|
||||
job = self._make_job(state='in_progress')
|
||||
with self.assertRaises(UserError):
|
||||
job.button_mark_shipped()
|
||||
|
||||
def test_button_mark_shipped_from_awaiting_ship_lands_done(self):
|
||||
job = self._make_job(state='awaiting_ship')
|
||||
job.button_mark_shipped()
|
||||
self.assertEqual(job.state, 'done')
|
||||
self.assertTrue(job.date_finished)
|
||||
|
||||
# ===== Task 20 — activity helpers ==================================
|
||||
|
||||
def test_schedule_cert_activity_helper_exists(self):
|
||||
job = self._make_job()
|
||||
self.assertTrue(hasattr(job, '_fp_schedule_cert_activity'))
|
||||
|
||||
def test_resolve_cert_activities_helper_exists(self):
|
||||
job = self._make_job()
|
||||
self.assertTrue(hasattr(job, '_fp_resolve_cert_activities'))
|
||||
Reference in New Issue
Block a user