admin/Odoo-Modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(sub12a): rename _seed_default_inputs → action_seed_default_inputs

Browse Source 
Odoo 19 rejects view buttons that call private (underscore-prefixed)
methods. Renamed the public entry point. The post_init_hook callers
follow.

Caught by entech upgrade (ParseError on the form view).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsinghpal
2026-04-27 20:43:26 -04:00
parent d6cdae30ec
commit 5494684181
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fusion_plating/fusion_plating/__init__.py
View File

@@ -155,7 +155,7 @@ def _create_template_from_node(env, node, seen):
tpl = env['fp.step.template'].create(vals) tpl = env['fp.step.template'].create(vals)
if kind: if kind:
tpl._seed_default_inputs() tpl.action_seed_default_inputs()
def _seed_minimal_library(env): def _seed_minimal_library(env):
@@ -180,7 +180,7 @@ def _seed_minimal_library(env):
] ]
for name, kind in minimal: for name, kind in minimal:
tpl = Tpl.create({'name': name, 'default_kind': kind}) tpl = Tpl.create({'name': name, 'default_kind': kind})
tpl._seed_default_inputs() tpl.action_seed_default_inputs()
_logger.info( _logger.info(
'Fusion Plating: seeded minimal step library (%s entries)', 'Fusion Plating: seeded minimal step library (%s entries)',
len(minimal), len(minimal),

8
fusion_plating/fusion_plating/models/fp_step_template.py
View File

@@ -198,9 +198,13 @@ class FpStepTemplate(models.Model):
'gating': [], 'gating': [],
} }
def _seed_default_inputs(self): def action_seed_default_inputs(self):
"""Seed input_template_ids based on default_kind. Idempotent — """Seed input_template_ids based on default_kind. Idempotent —
only adds inputs whose names don't already exist on this template.""" only adds inputs whose names don't already exist on this template.
Public method (Odoo 19 requires non-underscore-prefixed names
for methods called from a view button).
"""
Input = self.env['fp.step.template.input'] Input = self.env['fp.step.template.input']
for tpl in self: for tpl in self:
if not tpl.default_kind: if not tpl.default_kind:

2
fusion_plating/fusion_plating/views/fp_step_template_views.xml
View File

@@ -30,7 +30,7 @@
<field name="arch" type="xml"> <field name="arch" type="xml">
<form string="Step Library Template"> <form string="Step Library Template">
<header> <header>
<button name="_seed_default_inputs" type="object" <button name="action_seed_default_inputs" type="object"
string="Seed Default Inputs" class="btn-secondary" string="Seed Default Inputs" class="btn-secondary"
invisible="not default_kind"/> invisible="not default_kind"/>
</header> </header>