From 5f6c7af2a780c8d6498e86b28e1aec69de015884 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Mon, 27 Apr 2026 22:51:30 -0400
Subject: [PATCH] feat(phase3): tighten group-gating on operator-irrelevant
 top-levels
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Three targeted gates so operators no longer see admin/audit views:

- KPIs (menu_fp_dashboard) → supervisor+. Operators don't need
  dashboards; their tablet shows what they need to do next.
- Move Log (menu_fp_job_step_move) → supervisor+. Operators see
  their own moves on the tablet; this top-level menu is the
  audit-of-everyone-else view.
- Replenishment Suggestions (menu_fp_replenishment_suggestions) →
  supervisor+. Purchasing decision, not operator concern.

Other top-levels were already correctly gated:
- Sales / Configurator → estimator
- Shipping & Receiving → group_fp_receiving
- Compliance hub → supervisor+
- Configuration → manager
- Shop Floor / Quality → operator (correctly visible to floor staff)
- Operations parent stays open; child menus enforce per-action gates

Net effect: a fresh operator now sees ~5 top-level menus instead of
the previous ~10. Supervisors see ~8. Managers see all.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 fusion_plating/fusion_plating/__manifest__.py              | 2 +-
 .../fusion_plating/views/fp_job_step_move_views.xml        | 7 +++++--
 fusion_plating/fusion_plating/views/fp_menu.xml            | 4 +++-
 fusion_plating/fusion_plating_kpi/__manifest__.py          | 2 +-
 fusion_plating/fusion_plating_kpi/views/fp_menu.xml        | 5 +++--
 5 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/fusion_plating/fusion_plating/__manifest__.py b/fusion_plating/fusion_plating/__manifest__.py
index c41b494c..ac1f118e 100644
--- a/fusion_plating/fusion_plating/__manifest__.py
+++ b/fusion_plating/fusion_plating/__manifest__.py
@@ -5,7 +5,7 @@
 
 {
     'name': 'Fusion Plating',
-    'version': '19.0.11.1.0',
+    'version': '19.0.11.2.0',
     'category': 'Manufacturing/Plating',
     'summary': 'Core plating / metal finishing ERP: facilities, processes, tanks, baths, jobs, operators.',
     'description': """
diff --git a/fusion_plating/fusion_plating/views/fp_job_step_move_views.xml b/fusion_plating/fusion_plating/views/fp_job_step_move_views.xml
index c64daa9d..a4d55ef8 100644
--- a/fusion_plating/fusion_plating/views/fp_job_step_move_views.xml
+++ b/fusion_plating/fusion_plating/views/fp_job_step_move_views.xml
@@ -115,11 +115,14 @@
         <field name="search_view_id" ref="view_fp_job_step_move_search"/>
     </record>
 
-    <!-- Phase 1 — re-parented under Operations. -->
+    <!-- Phase 1 — under Operations.
+         Phase 3 — supervisor+ only. Operators see their own moves on
+         the tablet; this is an audit view of every move. -->
     <menuitem id="menu_fp_job_step_move"
               name="Move Log"
               parent="menu_fp_operations"
               action="action_fp_job_step_move"
-              sequence="90"/>
+              sequence="90"
+              groups="fusion_plating.group_fusion_plating_supervisor"/>
 
 </odoo>
diff --git a/fusion_plating/fusion_plating/views/fp_menu.xml b/fusion_plating/fusion_plating/views/fp_menu.xml
index 6315fe80..0b9fea97 100644
--- a/fusion_plating/fusion_plating/views/fp_menu.xml
+++ b/fusion_plating/fusion_plating/views/fp_menu.xml
@@ -112,11 +112,13 @@
               action="action_fp_rack"
               sequence="35"/>
 
+    <!-- Phase 3 — supervisor+: replenishment is a purchasing decision. -->
     <menuitem id="menu_fp_replenishment_suggestions"
               name="Replenishment Suggestions"
               parent="menu_fp_operations"
               action="action_fp_replenishment_suggestion"
-              sequence="40"/>
+              sequence="40"
+              groups="fusion_plating.group_fusion_plating_supervisor"/>
 
     <!-- Configuration children (referencing the 7 buckets above) -->
     <menuitem id="menu_fp_replenishment_rules"
diff --git a/fusion_plating/fusion_plating_kpi/__manifest__.py b/fusion_plating/fusion_plating_kpi/__manifest__.py
index 19a10070..a6039da4 100644
--- a/fusion_plating/fusion_plating_kpi/__manifest__.py
+++ b/fusion_plating/fusion_plating_kpi/__manifest__.py
@@ -5,7 +5,7 @@
 
 {
     'name': 'Fusion Plating — KPI Dashboard',
-    'version': '19.0.1.0.0',
+    'version': '19.0.1.1.0',
     'category': 'Manufacturing/Plating',
     'summary': 'Configurable KPI dashboards for plating operations.',
     'author': 'Nexa Systems Inc.',
diff --git a/fusion_plating/fusion_plating_kpi/views/fp_menu.xml b/fusion_plating/fusion_plating_kpi/views/fp_menu.xml
index 55749e15..18690997 100644
--- a/fusion_plating/fusion_plating_kpi/views/fp_menu.xml
+++ b/fusion_plating/fusion_plating_kpi/views/fp_menu.xml
@@ -6,11 +6,12 @@
 -->
 <odoo>
 
-    <!-- ===== KPIs top-level menu ===== -->
+    <!-- Phase 3 — supervisor+ only. Operators don't need dashboards. -->
     <menuitem id="menu_fp_dashboard"
               name="KPIs"
               parent="fusion_plating.menu_fp_root"
-              sequence="85"/>
+              sequence="85"
+              groups="fusion_plating.group_fusion_plating_supervisor"/>
 
     <menuitem id="menu_fp_kpis"
               name="KPIs"