From 677e4604384accc68550c6bf8224f22372e06297 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Wed, 13 May 2026 07:25:42 -0400
Subject: [PATCH] fix(sticker): wire SN # + Thickness to the correct Sub 5
 fields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The values were structurally blank because the variable
resolution was reading the wrong field names:

  Was:  _line.x_fc_serial_number    (doesn't exist)
        _line.x_fc_thickness        (doesn't exist)
  Now:  _line.x_fc_serial_id.name           (M2O fp.serial)
        _line.x_fc_thickness_id.display_name (M2O fp.coating.thickness)

Sub 5 shipped these as Many2one registries (fp.serial,
fp.coating.thickness) — the sticker was guessing at flat
Char-field equivalents that were never created.

Verified on SO-30019: SN # now prints "65767", Thickness now
prints "0.3-0.5 mils" (the en-dash in display_name mojibakes
to "â€"" through wkhtmltopdf's font path on entech, so we
replace en-dash + em-dash with ASCII hyphen-minus before
render — ASCII-only is what label printers want anyway).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../fusion_plating_reports/__manifest__.py     |  2 +-
 .../report/report_fp_wo_sticker.xml            | 18 +++++++++++-------
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/fusion_plating/fusion_plating_reports/__manifest__.py b/fusion_plating/fusion_plating_reports/__manifest__.py
index cb7a1c8e..4c8fa563 100644
--- a/fusion_plating/fusion_plating_reports/__manifest__.py
+++ b/fusion_plating/fusion_plating_reports/__manifest__.py
@@ -3,7 +3,7 @@
 # License OPL-1 (Odoo Proprietary License v1.0)
 {
     'name': 'Fusion Plating — Reports',
-    'version': '19.0.10.9.0',
+    'version': '19.0.10.11.0',
     'category': 'Manufacturing/Plating',
     'summary': 'PDF reports for Fusion Plating: quote, SO, WO, packing, BoL, CoC, invoice, receipt, quality + compliance.',
     'depends': [
diff --git a/fusion_plating/fusion_plating_reports/report/report_fp_wo_sticker.xml b/fusion_plating/fusion_plating_reports/report/report_fp_wo_sticker.xml
index fba22b9c..f362b66e 100644
--- a/fusion_plating/fusion_plating_reports/report/report_fp_wo_sticker.xml
+++ b/fusion_plating/fusion_plating_reports/report/report_fp_wo_sticker.xml
@@ -69,13 +69,17 @@
                                            or (_so and _so.x_fc_internal_note
                                                and _so.x_fc_internal_note.striptags()[:100])
                                            or '-'"/>
-        <!-- Serial number — Sub 5 added x_fc_serial_number on the SO line. -->
-        <t t-set="_serial_number" t-value="(_line and 'x_fc_serial_number' in _line._fields and _line.x_fc_serial_number) or '-'"/>
-        <!-- Thickness — Sub 5 added x_fc_thickness on the SO line; fall back
-             to the coating config's thickness spec if the line is bare. -->
-        <t t-set="_thickness" t-value="(_line and 'x_fc_thickness' in _line._fields and _line.x_fc_thickness)
-                                       or (_coating and 'thickness' in _coating._fields and _coating.thickness)
-                                       or '-'"/>
+        <!-- Serial number — Sub 5 added x_fc_serial_id (M2O fp.serial) on
+             the SO line. The serial record's `name` is the printable label. -->
+        <t t-set="_serial_number" t-value="(_line and 'x_fc_serial_id' in _line._fields and _line.x_fc_serial_id and _line.x_fc_serial_id.name) or '-'"/>
+        <!-- Thickness — Sub 5 added x_fc_thickness_id (M2O fp.coating.thickness)
+             on the SO line. `display_name` is the human-readable range, e.g.
+             "0.3–0.5 mils". The en-dash (U+2013) in display_name mojibakes
+             to "â€"" through wkhtmltopdf's font path on entech, so we
+             swap en-dash + em-dash for a plain hyphen-minus before
+             rendering. ASCII-only printable for any QR-label printer. -->
+        <t t-set="_thickness_dn" t-value="_line and 'x_fc_thickness_id' in _line._fields and _line.x_fc_thickness_id and _line.x_fc_thickness_id.display_name"/>
+        <t t-set="_thickness" t-value="(_thickness_dn and _thickness_dn.replace(u'–', '-').replace(u'—', '-')) or '-'"/>
         <!-- Notes content = customer-facing description. Per Sub 2 decision
              Q6: SO line `name` is the customer-facing description (Odoo
              standard). Falls back to product name when the line is bare. -->