chore(plating): de-dash shipped code + intake-neutral customer emails
Replace em-dashes and en-dashes with hyphens across 789 shipped source files (py/xml/js/scss) so the delivered module reads as human-written; em-dashes had become a recognizable AI-generated tell. Internal .md dev notes are excluded. The WO-sticker mojibake strippers keep their dash search targets (now written — / –). No logic changes: comments and display strings only; validated with py_compile + lxml parse. Rewrite the 7 customer notification emails to be intake-neutral (ship-in / drop-off / pickup) and repair-aware, and fix the Shipped email documents line (packing slip vs bill of lading; certificate only when issued). Subjects use a hyphen separator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -22,14 +22,14 @@ class ResPartner(models.Model):
|
||||
Plating Manager OR Plating Administrator qualifies. Administrator
|
||||
is checked explicitly (in addition to the implied chain) because
|
||||
Odoo's ``implied_ids`` cascade does NOT reliably propagate to
|
||||
existing users on module upgrade — admin (uid 1) typically lands
|
||||
existing users on module upgrade - admin (uid 1) typically lands
|
||||
in Administrator only, with no Manager membership. Without this
|
||||
defensive check, the highest-privileged user can't bypass holds.
|
||||
|
||||
See CLAUDE.md "Implied group cascade" rule.
|
||||
"""
|
||||
user = self.env.user
|
||||
# Phase G: fixed audit-finding-11 — old code referenced
|
||||
# Phase G: fixed audit-finding-11 - old code referenced
|
||||
# 'fusion_plating.group_fusion_plating_administrator', an xmlid
|
||||
# that never existed, so the gate always returned False. Replaced
|
||||
# with group_fp_manager which transitively implies Owner via
|
||||
@@ -48,7 +48,7 @@ class ResPartner(models.Model):
|
||||
# invoice strategy, delivery method, and deadlines on every new SO so
|
||||
# repeat customers don't need re-typing the same values each order.
|
||||
# Tax type lives on `property_account_position_id` (Odoo native fiscal
|
||||
# position) and payment terms on `property_payment_term_id` — both are
|
||||
# position) and payment terms on `property_payment_term_id` - both are
|
||||
# surfaced on the same Plating Defaults tab in the partner form.
|
||||
|
||||
x_fc_default_invoice_strategy = fields.Selection(
|
||||
|
||||
Reference in New Issue
Block a user