From 8d4c85cc52c589787726c08ac413c615bbebfddc Mon Sep 17 00:00:00 2001 From: gsinghpal Date: Sun, 24 May 2026 19:36:48 -0400 Subject: [PATCH] fix(workspace): drop native confirm() on Close Receiving Native browser confirm popups look out of place in the tablet UI. Mark Counted is already a deliberate prior step, so requiring a second confirmation on Close Receiving was just friction. If a receiver hits Close prematurely, action_reset_to_counted on fp.receiving from the back office is the recovery path. Co-Authored-By: Claude Opus 4.7 (1M context) --- fusion_plating/fusion_plating_shopfloor/__manifest__.py | 2 +- .../static/src/js/job_workspace.js | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fusion_plating/fusion_plating_shopfloor/__manifest__.py b/fusion_plating/fusion_plating_shopfloor/__manifest__.py index 6829e899..9e629974 100644 --- a/fusion_plating/fusion_plating_shopfloor/__manifest__.py +++ b/fusion_plating/fusion_plating_shopfloor/__manifest__.py @@ -5,7 +5,7 @@ { 'name': 'Fusion Plating — Shop Floor', - 'version': '19.0.33.1.8', + 'version': '19.0.33.1.9', 'category': 'Manufacturing/Plating', 'summary': 'Shop-floor tablet stations, QR scanning, bake window enforcer, ' 'first-piece inspection gates.', diff --git a/fusion_plating/fusion_plating_shopfloor/static/src/js/job_workspace.js b/fusion_plating/fusion_plating_shopfloor/static/src/js/job_workspace.js index 01b9d9c8..f5b65a58 100644 --- a/fusion_plating/fusion_plating_shopfloor/static/src/js/job_workspace.js +++ b/fusion_plating/fusion_plating_shopfloor/static/src/js/job_workspace.js @@ -496,9 +496,11 @@ export class FpJobWorkspace extends Component { } async onReceivingClose(rcv) { - if (!window.confirm(`Close receiving ${rcv.name}? The recipe steps will take over.`)) { - return; - } + // No confirmation — Mark Counted is already a deliberate prior + // step, and the native browser confirm() popup looks out of place + // on the tablet UI. If a receiver hits Close prematurely, an + // admin can reset via fp.receiving.action_reset_to_counted from + // the back office. try { const res = await rpc("/fp/workspace/receiving_close", { receiving_id: rcv.id,