From 903ceb10d069cf382d85bca8bf2874c99d6349e2 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Tue, 2 Jun 2026 02:21:07 -0400
Subject: [PATCH] fix(fusion_repairs): two install blockers found on first
 clean install (Westin Enterprise)

Surfaced by installing fusion_repairs into a westin-v19 clone (its first-ever clean install; cloud.md's 'installed locally' was stale). (1) Post-visit NPS mail template used url_encode(), which is NOT in Odoo 19's mail.template QWeb render context -> save-validation failed at install (ParseError 'issue with this value'); replaced with a string-method (.replace) fallback. (2) views/menus.xml defined menu_fusion_repairs_configuration AFTER the children referencing it as parent -> 'External ID not found in the system'; moved the parent definition above its children. fusion_repairs now installs cleanly (32 models, 11 templates) on the Enterprise stack.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 fusion_repairs/data/mail_template_data.xml |  4 ++--
 fusion_repairs/views/menus.xml             | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fusion_repairs/data/mail_template_data.xml b/fusion_repairs/data/mail_template_data.xml
index b6bbe0d1..fb12c0e4 100644
--- a/fusion_repairs/data/mail_template_data.xml
+++ b/fusion_repairs/data/mail_template_data.xml
@@ -125,8 +125,8 @@
             We would love to hear how it went - your feedback helps other clients
             find us and helps us improve.
         </p>
-        <!-- H4: URL-encode the company name so the fallback URL survives ampersands + spaces. -->
-        <t t-set="review_url" t-value="object.company_id.x_fc_google_review_url or ('https://www.google.com/search?' + url_encode({'q': object.company_id.name or ''}))"/>
+        <!-- H4: build a fallback search URL without url_encode (not available in the mail QWeb render context); replace spaces so the URL survives. -->
+        <t t-set="review_url" t-value="object.company_id.x_fc_google_review_url or ('https://www.google.com/search?q=' + (object.company_id.name or '').replace(' ', '+'))"/>
         <div style="text-align:center;margin:0 0 24px 0;">
             <a t-att-href="review_url"
                style="display:inline-block;padding:14px 28px;background-color:#38a169;color:#ffffff;text-decoration:none;border-radius:6px;font-size:16px;font-weight:600;">
diff --git a/fusion_repairs/views/menus.xml b/fusion_repairs/views/menus.xml
index 61e33661..775ba4a3 100644
--- a/fusion_repairs/views/menus.xml
+++ b/fusion_repairs/views/menus.xml
@@ -57,6 +57,13 @@
               action="action_repair_part_order"
               sequence="38"/>
 
+    <!-- Configuration parent: must be defined before the children that reference it below -->
+    <menuitem id="menu_fusion_repairs_configuration"
+              name="Configuration"
+              parent="menu_fusion_repairs_root"
+              sequence="90"
+              groups="fusion_repairs.group_fusion_repairs_manager"/>
+
     <menuitem id="menu_fusion_repairs_emergency_charges"
               name="Emergency Surcharges"
               parent="menu_fusion_repairs_configuration"
@@ -100,13 +107,6 @@
               action="action_repair_labor_warranty"
               sequence="36"/>
 
-    <!-- Configuration -->
-    <menuitem id="menu_fusion_repairs_configuration"
-              name="Configuration"
-              parent="menu_fusion_repairs_root"
-              sequence="90"
-              groups="fusion_repairs.group_fusion_repairs_manager"/>
-
     <menuitem id="menu_fusion_repairs_categories"
               name="Equipment Categories"
               parent="menu_fusion_repairs_configuration"