fix(bank_rec): don't shadow Odoo's _() translation function in action_run_migration
Line 77 was `_ = super().action_run_migration()`, using `_` as a
throwaway variable name. That rebinds the module-level `_` (Odoo's
translation function imported at the top) to whatever super() returns
\u2014 in our case the parent's notification dict.
Lines 84/85 then call `_('Bank-Rec Migration Complete')` which is
now `some_dict('Bank-Rec Migration Complete')` \u2192
TypeError: 'dict' object is not callable.
User hit this when running the migration wizard from the menu.
Fix: drop the assignment; we don't actually use super()'s return value.
Made-with: Cursor
This commit is contained in:
@@ -74,7 +74,9 @@ class FusionMigrationWizard(models.TransientModel):
|
|||||||
Phase 0) and then runs the bank-rec bootstrap. Returns a
|
Phase 0) and then runs the bank-rec bootstrap. Returns a
|
||||||
notification summarizing both.
|
notification summarizing both.
|
||||||
"""
|
"""
|
||||||
_ = super().action_run_migration()
|
# Don't bind super()'s return value to `_` \u2014 that shadows the
|
||||||
|
# imported translation function and breaks the _("...") calls below.
|
||||||
|
super().action_run_migration()
|
||||||
result = self._bank_rec_bootstrap_step()
|
result = self._bank_rec_bootstrap_step()
|
||||||
return {
|
return {
|
||||||
'type': 'ir.actions.client',
|
'type': 'ir.actions.client',
|
||||||
|
|||||||
Reference in New Issue
Block a user