From 9e5c23f37dcbfdffcb38a1853959b84a35b9e65f Mon Sep 17 00:00:00 2001 From: gsinghpal Date: Sun, 24 May 2026 01:36:28 -0400 Subject: [PATCH] fix(plating-tests): correct menu xmlids (menu_fp_sales, menu_fp_shopfloor) Implementer concern from D1-D4 dispatch: plan template referenced menu_fp_sales_root / menu_fp_shopfloor_root but actual xmlids drop the _root suffix. Tests were silently skipping. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../fusion_plating/tests/test_menu_visibility.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fusion_plating/fusion_plating/tests/test_menu_visibility.py b/fusion_plating/fusion_plating/tests/test_menu_visibility.py index dc0699df..8d8fe1a5 100644 --- a/fusion_plating/fusion_plating/tests/test_menu_visibility.py +++ b/fusion_plating/fusion_plating/tests/test_menu_visibility.py @@ -43,25 +43,25 @@ class TestMenuVisibility(TransactionCase): self.assertFalse(result, '"No" role must not see Plating root') def test_technician_sees_shop_floor(self): - result = self._visible(self.u_tech, 'fusion_plating_shopfloor.menu_fp_shopfloor_root') + result = self._visible(self.u_tech, 'fusion_plating_shopfloor.menu_fp_shopfloor') if result is None: self.skipTest('Shop Floor menu not found') self.assertTrue(result) def test_technician_does_not_see_sales(self): - result = self._visible(self.u_tech, 'fusion_plating_configurator.menu_fp_sales_root') + result = self._visible(self.u_tech, 'fusion_plating_configurator.menu_fp_sales') if result is None: self.skipTest('Sales menu not found') self.assertFalse(result, 'Technician must not see Sales & Quoting') def test_sales_rep_sees_sales(self): - result = self._visible(self.u_sr, 'fusion_plating_configurator.menu_fp_sales_root') + result = self._visible(self.u_sr, 'fusion_plating_configurator.menu_fp_sales') if result is None: self.skipTest('Sales menu not found') self.assertTrue(result) def test_sales_rep_does_not_see_shop_floor(self): - result = self._visible(self.u_sr, 'fusion_plating_shopfloor.menu_fp_shopfloor_root') + result = self._visible(self.u_sr, 'fusion_plating_shopfloor.menu_fp_shopfloor') if result is None: self.skipTest('Shop Floor menu not found') self.assertFalse(result, 'Sales Rep must not see Shop Floor')