From a4a969288815f1a9d80d22b25e31f4462cbdfefd Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Sun, 19 Apr 2026 12:28:34 -0400
Subject: [PATCH] fix(fusion_accounting_bank_rec): acceptSuggestion
 double-decrement count

Optimistic remove was decrementing unreconciledCount before assigning
the authoritative server count, leading to off-by-one. Order swapped:
remove first, then overwrite with server count.

Caught by Task 28 subagent self-review.

Made-with: Cursor
---
 .../static/src/services/bank_reconciliation_service.js         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fusion_accounting_bank_rec/static/src/services/bank_reconciliation_service.js b/fusion_accounting_bank_rec/static/src/services/bank_reconciliation_service.js
index 8f15e5d3..b8607fcd 100644
--- a/fusion_accounting_bank_rec/static/src/services/bank_reconciliation_service.js
+++ b/fusion_accounting_bank_rec/static/src/services/bank_reconciliation_service.js
@@ -149,9 +149,8 @@ export class BankReconciliationService {
             const result = await this.rpc(`${ENDPOINT_BASE}/accept_suggestion`, {
                 suggestion_id: suggestionId,
             });
-            this.state.unreconciledCount = result.unreconciled_count_after;
-            // Optimistic remove from list
             this._removeReconciledLineFromState(this.state.selectedLineId);
+            this.state.unreconciledCount = result.unreconciled_count_after;
             this.notification.add("Reconciliation accepted", { type: "success" });
             return result;
         } catch (err) {