From b015958edc2aa398075814ffa1528b328758b853 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Sun, 31 May 2026 22:07:00 -0400
Subject: [PATCH] feat(fusion_clock): unify + label kiosk settings, add
 quick-open buttons

Settings tidy-up: one 'Kiosk' block holding both PIN Kiosk and NFC Kiosk
(clearly described so users know which is which), each with an Open-kiosk
button when enabled; Corrections + Sounds split into a 'Portal' block. Move
Auto-Wipe Photos under Photo Verification (was hidden for PIN-only clients).
Bump 19.0.4.0.0 -> 19.0.4.0.1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 fusion_clock/__manifest__.py                  |  2 +-
 .../views/res_config_settings_views.xml       | 88 +++++++++++--------
 2 files changed, 52 insertions(+), 38 deletions(-)

diff --git a/fusion_clock/__manifest__.py b/fusion_clock/__manifest__.py
index 036bf779..ab55c7fe 100644
--- a/fusion_clock/__manifest__.py
+++ b/fusion_clock/__manifest__.py
@@ -5,7 +5,7 @@
 
 {
     'name': 'Fusion Clock',
-    'version': '19.0.4.0.0',
+    'version': '19.0.4.0.1',
     'category': 'Human Resources/Attendances',
     'summary': 'Complete Employee T&A with Geofencing, Shifts, Penalties, Overtime, Kiosk, Dashboard & Payroll Export',
     'description': """
diff --git a/fusion_clock/views/res_config_settings_views.xml b/fusion_clock/views/res_config_settings_views.xml
index 65261c5f..a566831d 100644
--- a/fusion_clock/views/res_config_settings_views.xml
+++ b/fusion_clock/views/res_config_settings_views.xml
@@ -133,8 +133,14 @@
                             <field name="fclk_enable_ip_fallback"/>
                         </setting>
                         <setting id="fclk_photo_verification" string="Photo Verification"
-                                 help="Master switch for clock-in/out selfies. When OFF, no photos are captured anywhere (portal or NFC kiosk). When ON, the per-location and NFC-kiosk photo settings apply.">
+                                 help="Master switch for clock-in/out selfies. When OFF, no photos are captured anywhere (portal, PIN kiosk or NFC kiosk). When ON, the per-location and kiosk photo settings apply.">
                             <field name="fclk_enable_photo_verification"/>
+                            <div class="content-group" invisible="not fclk_enable_photo_verification">
+                                <div class="row mt16">
+                                    <label for="fclk_photo_retention_days" string="Auto-Wipe Photos After (days)" class="col-lg-5 o_light_label"/>
+                                    <field name="fclk_photo_retention_days"/>
+                                </div>
+                            </div>
                         </setting>
                         <setting id="fclk_google_maps" string="Google Maps API Key"
                                  help="Required for location geocoding and map previews in clock location setup.">
@@ -157,13 +163,53 @@
                     </block>
 
                     <!-- ============================================================ -->
-                    <!-- Kiosk & Portal -->
+                    <!-- Kiosk (shared-device clock-in: PIN or NFC) -->
                     <!-- ============================================================ -->
-                    <block title="Kiosk &amp; Portal" name="fclk_kiosk_portal">
-                        <setting id="fclk_kiosk" string="Kiosk Mode"
-                                 help="Allow employees to clock in/out from a shared device (tablet or computer).">
+                    <block title="Kiosk" name="fclk_kiosk_modes">
+                        <setting id="fclk_pin_kiosk" string="PIN Kiosk"
+                                 help="Shared tablet where staff tap their photo and enter a PIN. Best when you don't use NFC cards/fobs.">
                             <field name="fclk_enable_kiosk"/>
+                            <div class="content-group" invisible="not fclk_enable_kiosk">
+                                <div class="mt16">
+                                    <a href="/fusion_clock/kiosk" target="_blank" class="btn btn-secondary btn-sm">
+                                        <i class="fa fa-external-link me-1"/> Open PIN Kiosk
+                                    </a>
+                                </div>
+                            </div>
                         </setting>
+                        <setting id="fclk_nfc_kiosk" string="NFC Kiosk"
+                                 help="Shared tablet where staff tap an NFC card or fob (contactless). Fastest for shop floors.">
+                            <field name="fclk_enable_nfc_kiosk"/>
+                            <div class="content-group" invisible="not fclk_enable_nfc_kiosk">
+                                <div class="row mt16">
+                                    <label for="fclk_nfc_kiosk_location_id" string="Location" class="col-lg-5 o_light_label"/>
+                                    <field name="fclk_nfc_kiosk_location_id"/>
+                                </div>
+                                <div class="row mt8">
+                                    <label for="fclk_nfc_photo_required" string="Require Photo" class="col-lg-5 o_light_label"/>
+                                    <field name="fclk_nfc_photo_required"/>
+                                </div>
+                                <div class="row mt8">
+                                    <label for="fclk_nfc_enroll_password" string="Enroll Password" class="col-lg-5 o_light_label"/>
+                                    <field name="fclk_nfc_enroll_password" password="True"/>
+                                </div>
+                                <div class="row mt8">
+                                    <label for="fclk_nfc_kiosk_debug" string="Debug Overlay" class="col-lg-5 o_light_label"/>
+                                    <field name="fclk_nfc_kiosk_debug"/>
+                                </div>
+                                <div class="mt16">
+                                    <a href="/fusion_clock/kiosk/nfc" target="_blank" class="btn btn-secondary btn-sm">
+                                        <i class="fa fa-external-link me-1"/> Open NFC Kiosk
+                                    </a>
+                                </div>
+                            </div>
+                        </setting>
+                    </block>
+
+                    <!-- ============================================================ -->
+                    <!-- Portal -->
+                    <!-- ============================================================ -->
+                    <block title="Portal" name="fclk_portal">
                         <setting id="fclk_corrections" string="Correction Requests"
                                  help="Allow employees to request timesheet corrections from the portal.">
                             <field name="fclk_enable_correction_requests"/>
@@ -228,38 +274,6 @@
                         </setting>
                     </block>
 
-                    <!-- ============================================================ -->
-                    <!-- NFC Clock Kiosk -->
-                    <!-- ============================================================ -->
-                    <block title="NFC Clock Kiosk" name="fclk_nfc_kiosk">
-                        <setting id="fclk_nfc_enable" string="Enable NFC Kiosk"
-                                 help="Tap-to-clock kiosk for shop-floor tablets at /fusion_clock/kiosk/nfc">
-                            <field name="fclk_enable_nfc_kiosk"/>
-                            <div class="content-group" invisible="not fclk_enable_nfc_kiosk">
-                                <div class="row mt16">
-                                    <label for="fclk_nfc_kiosk_location_id" string="Location" class="col-lg-5 o_light_label"/>
-                                    <field name="fclk_nfc_kiosk_location_id"/>
-                                </div>
-                                <div class="row mt8">
-                                    <label for="fclk_nfc_photo_required" string="Require Photo" class="col-lg-5 o_light_label"/>
-                                    <field name="fclk_nfc_photo_required"/>
-                                </div>
-                                <div class="row mt8">
-                                    <label for="fclk_photo_retention_days" string="Auto-Wipe Photos After (days)" class="col-lg-5 o_light_label"/>
-                                    <field name="fclk_photo_retention_days"/>
-                                </div>
-                                <div class="row mt8">
-                                    <label for="fclk_nfc_enroll_password" string="Enroll Password" class="col-lg-5 o_light_label"/>
-                                    <field name="fclk_nfc_enroll_password" password="True"/>
-                                </div>
-                                <div class="row mt8">
-                                    <label for="fclk_nfc_kiosk_debug" string="Debug Overlay" class="col-lg-5 o_light_label"/>
-                                    <field name="fclk_nfc_kiosk_debug"/>
-                                </div>
-                            </div>
-                        </setting>
-                    </block>
-
                 </app>
             </xpath>
         </field>