feat(plating): close compliance gaps 7-9 — NCR + CAPA + discharge + invoice ref
**7a. NCR close gate** (fusion.plating.ncr.action_close) Block close unless these are filled in: • Description (what happened) • Containment Actions (immediate response) • Root Cause (why it happened) • Disposition (use-as-is / rework / scrap / RTV decision) A closed NCR without these is useless for AS9100 audits — it's the entire point of an NCR to document what went wrong, why, and how we responded. Empty-HTML strings like "<p><br></p>" are detected as empty too. **7b. CAPA close gate** (fusion.plating.capa.action_close) Block close unless: • Root Cause Analysis filled in • Action Plan filled in • Verification (date + verifier) recorded • Effectiveness Notes filled when CAPA was marked Not Effective AS9100 §10.2 / Nadcap require evidence of root-cause analysis, the corrective/preventive action plan, AND that effectiveness was verified before the loop is closed. **8. Invoice ref defensive default** (account.move.create) Auto-fills `ref` from the source SO's client_order_ref or x_fc_po_number when the invoice is created with invoice_origin set but no ref. Already populated on the SO confirm path; this catches manually-created invoices that would otherwise miss it. Customer AP teams reject invoices that don't quote their PO# back. **9. Discharge sample close gate** (fusion.plating.discharge.sample.action_close) Block close unless: • Lab Report # set • Results Received Date set • At least one parameter reading on file • Lab certificate/report attached Without lab evidence the record fails any environmental compliance audit — the whole point is to document the test was performed and what the lab said. **Simulator** (scripts/fp_e2e_workforce.py) Adds 4 new negative tests (Test 8-11), all wrapped in savepoints: ✓ Test 8 : NCR close without RC/containment/disposition → blocked ✓ Test 9 : CAPA close without analysis/plan/verification → blocked ✓ Test 10: Discharge sample close without lab evidence → blocked ✓ Test 11: Invoice ref auto-fills from SO.client_order_ref → asserted **Final E2E**: 52 PASS / 2 WARN / 0 FAIL out of 54 checks. Both remaining WARNs are expected (bake-window auto-create, first-piece gate — coating-driven, this coating doesn't trigger them). 11 negative tests in total now, every gate fires when triggered. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,8 @@
|
||||
# -*- coding: utf-8 -*-
|
||||
# Copyright 2026 Nexa Systems Inc.
|
||||
# License OPL-1 (Odoo Proprietary License v1.0)
|
||||
from odoo import api, fields, models
|
||||
from odoo import _, api, fields, models
|
||||
from odoo.exceptions import UserError
|
||||
|
||||
|
||||
class FpDischargeSample(models.Model):
|
||||
@@ -63,4 +64,32 @@ class FpDischargeSample(models.Model):
|
||||
self.write({'state': 'escalated'})
|
||||
|
||||
def action_close(self):
|
||||
"""Block close until lab evidence is on file.
|
||||
|
||||
A closed discharge sample without a lab report ref + at least
|
||||
one parameter reading + (when results are in) a lab cert
|
||||
attachment fails any environmental audit. The whole point
|
||||
of the record is to document the test was performed and what
|
||||
the lab said.
|
||||
"""
|
||||
for rec in self:
|
||||
missing = []
|
||||
if not rec.lab_report_ref:
|
||||
missing.append(_('Lab Report #'))
|
||||
if not rec.received_date:
|
||||
missing.append(_('Results Received Date'))
|
||||
if not rec.line_ids:
|
||||
missing.append(_('At least one parameter reading'))
|
||||
if not rec.attachment_ids:
|
||||
missing.append(_('Lab certificate / report attachment'))
|
||||
if missing:
|
||||
raise UserError(_(
|
||||
'Cannot close discharge sample "%(name)s" — these '
|
||||
'fields must be filled in first:\n • %(fields)s\n\n'
|
||||
'Without lab evidence on file the record fails any '
|
||||
'environmental compliance audit.'
|
||||
) % {
|
||||
'name': rec.name or rec.display_name,
|
||||
'fields': '\n • '.join(missing),
|
||||
})
|
||||
self.write({'state': 'closed'})
|
||||
|
||||
Reference in New Issue
Block a user