feat(plating): close compliance gaps 7-9 — NCR + CAPA + discharge + invoice ref

**7a. NCR close gate** (fusion.plating.ncr.action_close)
Block close unless these are filled in:
  • Description (what happened)
  • Containment Actions (immediate response)
  • Root Cause (why it happened)
  • Disposition (use-as-is / rework / scrap / RTV decision)

A closed NCR without these is useless for AS9100 audits — it's
the entire point of an NCR to document what went wrong, why, and
how we responded. Empty-HTML strings like "<p><br></p>" are
detected as empty too.

**7b. CAPA close gate** (fusion.plating.capa.action_close)
Block close unless:
  • Root Cause Analysis filled in
  • Action Plan filled in
  • Verification (date + verifier) recorded
  • Effectiveness Notes filled when CAPA was marked Not Effective

AS9100 §10.2 / Nadcap require evidence of root-cause analysis,
the corrective/preventive action plan, AND that effectiveness
was verified before the loop is closed.

**8. Invoice ref defensive default** (account.move.create)
Auto-fills `ref` from the source SO's client_order_ref or
x_fc_po_number when the invoice is created with invoice_origin set
but no ref. Already populated on the SO confirm path; this catches
manually-created invoices that would otherwise miss it. Customer
AP teams reject invoices that don't quote their PO# back.

**9. Discharge sample close gate** (fusion.plating.discharge.sample.action_close)
Block close unless:
  • Lab Report # set
  • Results Received Date set
  • At least one parameter reading on file
  • Lab certificate/report attached

Without lab evidence the record fails any environmental compliance
audit — the whole point is to document the test was performed and
what the lab said.

**Simulator** (scripts/fp_e2e_workforce.py)
Adds 4 new negative tests (Test 8-11), all wrapped in savepoints:
  ✓ Test 8 : NCR close without RC/containment/disposition → blocked
  ✓ Test 9 : CAPA close without analysis/plan/verification → blocked
  ✓ Test 10: Discharge sample close without lab evidence → blocked
  ✓ Test 11: Invoice ref auto-fills from SO.client_order_ref → asserted

**Final E2E**: 52 PASS / 2 WARN / 0 FAIL out of 54 checks.
Both remaining WARNs are expected (bake-window auto-create,
first-piece gate — coating-driven, this coating doesn't trigger them).

11 negative tests in total now, every gate fires when triggered.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fusion_plating/fusion_plating_quality/models/fp_capa.py

@@ -3,7 +3,8 @@
 # License OPL-1 (Odoo Proprietary License v1.0)
 # Part of the Fusion Plating product family.
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class FpCapa(models.Model):
@@ -160,6 +161,43 @@ class FpCapa(models.Model):
         })
 
     def action_close(self):
+        """Block close unless root_cause + action_plan + verification are set.
+
+        A CAPA without these is just an open ticket — the AS9100 §10.2
+        / Nadcap loop requires evidence of the root cause analysis,
+        the corrective/preventive action plan, AND that effectiveness
+        was verified before the loop is closed.
+        """
+        for rec in self:
+            missing = []
+
+            def is_empty_html(val):
+                if not val:
+                    return True
+                s = str(val).replace('<p>', '').replace('</p>', '')
+                s = s.replace('<br>', '').replace('<br/>', '').strip()
+                return not s
+
+            if is_empty_html(rec.root_cause_analysis):
+                missing.append(_('Root Cause Analysis'))
+            if is_empty_html(rec.action_plan):
+                missing.append(_('Action Plan'))
+            if not rec.verification_date or not rec.verification_by_id:
+                missing.append(_('Verification (date + verifier)'))
+            if rec.is_effective is False and is_empty_html(rec.effectiveness_notes):
+                # If marked not-effective, demand a note explaining the
+                # follow-up plan — otherwise the loop never actually closes.
+                missing.append(_('Effectiveness Notes (required when "Not Effective")'))
+            if missing:
+                raise UserError(_(
+                    'Cannot close CAPA "%(name)s" — these fields must be '
+                    'filled in first:\n  • %(fields)s\n\n'
+                    'A CAPA without root cause + action plan + verified '
+                    'effectiveness fails AS9100 §10.2 / Nadcap on audit.'
+                ) % {
+                    'name': rec.name or rec.display_name,
+                    'fields': '\n  • '.join(missing),
+                })
         self.write({'state': 'closed'})
 
     def action_reset_to_draft(self):

fusion_plating/fusion_plating_quality/models/fp_ncr.py

@@ -3,7 +3,8 @@
 # License OPL-1 (Odoo Proprietary License v1.0)
 # Part of the Fusion Plating product family.
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class FpNcr(models.Model):
@@ -156,6 +157,42 @@ class FpNcr(models.Model):
         self.write({'state': 'disposition'})
 
     def action_close(self):
+        """Block close unless root_cause + containment + disposition are set.
+
+        A closed NCR without these three is useless for AS9100 audits:
+        the whole point of the NCR is to document what went wrong
+        (containment), why (root_cause), and what we decided to do
+        with the affected parts (disposition).
+        """
+        for rec in self:
+            missing = []
+            # Strip HTML-empty strings like "<p><br></p>" before checking
+            def is_empty_html(val):
+                if not val:
+                    return True
+                s = str(val).replace('<p>', '').replace('</p>', '')
+                s = s.replace('<br>', '').replace('<br/>', '').strip()
+                return not s
+
+            if is_empty_html(rec.description):
+                missing.append(_('Description'))
+            if is_empty_html(rec.containment):
+                missing.append(_('Containment Actions'))
+            if is_empty_html(rec.root_cause):
+                missing.append(_('Root Cause'))
+            if not rec.disposition:
+                missing.append(_('Disposition (use-as-is / rework / scrap / RTV)'))
+            if missing:
+                raise UserError(_(
+                    'Cannot close NCR "%(name)s" — these fields must be '
+                    'filled in first:\n  • %(fields)s\n\n'
+                    'AS9100 / Nadcap auditors will reject a closed NCR '
+                    'that doesn\'t document what happened, why, and how '
+                    'we responded.'
+                ) % {
+                    'name': rec.name or rec.display_name,
+                    'fields': '\n  • '.join(missing),
+                })
         self.write({
             'state': 'closed',
             'closed_date': fields.Datetime.now(),