feat(plating): close compliance gaps 7-9 — NCR + CAPA + discharge + invoice ref

**7a. NCR close gate** (fusion.plating.ncr.action_close)
Block close unless these are filled in:
  • Description (what happened)
  • Containment Actions (immediate response)
  • Root Cause (why it happened)
  • Disposition (use-as-is / rework / scrap / RTV decision)

A closed NCR without these is useless for AS9100 audits — it's
the entire point of an NCR to document what went wrong, why, and
how we responded. Empty-HTML strings like "<p><br></p>" are
detected as empty too.

**7b. CAPA close gate** (fusion.plating.capa.action_close)
Block close unless:
  • Root Cause Analysis filled in
  • Action Plan filled in
  • Verification (date + verifier) recorded
  • Effectiveness Notes filled when CAPA was marked Not Effective

AS9100 §10.2 / Nadcap require evidence of root-cause analysis,
the corrective/preventive action plan, AND that effectiveness
was verified before the loop is closed.

**8. Invoice ref defensive default** (account.move.create)
Auto-fills `ref` from the source SO's client_order_ref or
x_fc_po_number when the invoice is created with invoice_origin set
but no ref. Already populated on the SO confirm path; this catches
manually-created invoices that would otherwise miss it. Customer
AP teams reject invoices that don't quote their PO# back.

**9. Discharge sample close gate** (fusion.plating.discharge.sample.action_close)
Block close unless:
  • Lab Report # set
  • Results Received Date set
  • At least one parameter reading on file
  • Lab certificate/report attached

Without lab evidence the record fails any environmental compliance
audit — the whole point is to document the test was performed and
what the lab said.

**Simulator** (scripts/fp_e2e_workforce.py)
Adds 4 new negative tests (Test 8-11), all wrapped in savepoints:
  ✓ Test 8 : NCR close without RC/containment/disposition → blocked
  ✓ Test 9 : CAPA close without analysis/plan/verification → blocked
  ✓ Test 10: Discharge sample close without lab evidence → blocked
  ✓ Test 11: Invoice ref auto-fills from SO.client_order_ref → asserted

**Final E2E**: 52 PASS / 2 WARN / 0 FAIL out of 54 checks.
Both remaining WARNs are expected (bake-window auto-create,
first-piece gate — coating-driven, this coating doesn't trigger them).

11 negative tests in total now, every gate fires when triggered.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsinghpal
2026-04-19 10:35:19 -04:00
parent db8b79d22e
commit c118b7c6b5
8 changed files with 200 additions and 12 deletions

View File

@@ -475,6 +475,72 @@ def t_thickness_cal():
neg_test('thickness reading without cal std', t_thickness_cal,
['calibration', 'required', 'not-null', 'null value'])
# Test 8: NCR close without root cause / containment / disposition
step('SYSTEM', 'Test 8 — NCR close() with missing fields → blocked')
def t_ncr_close():
f = env['fusion.plating.facility'].search([], limit=1)
n = env['fusion.plating.ncr'].sudo().create({
'facility_id': f.id,
'description': '',
'containment': '',
'root_cause': '',
'disposition': False,
})
n.action_close()
neg_test('NCR close without RC/containment/disposition', t_ncr_close,
['Root Cause', 'Containment', 'Disposition'])
# Test 9: CAPA close without root cause analysis / action plan / verification
step('SYSTEM', 'Test 9 — CAPA close() with missing fields → blocked')
def t_capa_close():
c = env['fusion.plating.capa'].sudo().create({
'description': '',
'root_cause_analysis': '',
'action_plan': '',
})
c.action_close()
neg_test('CAPA close without analysis/plan/verification', t_capa_close,
['Root Cause Analysis', 'Action Plan', 'Verification'])
# Test 10: Discharge sample close without lab evidence
step('SYSTEM', 'Test 10 — Discharge sample close() with no lab evidence → blocked')
def t_discharge_close():
f = env['fusion.plating.facility'].search([], limit=1)
s = env['fusion.plating.discharge.sample'].sudo().create({
'facility_id': f.id,
})
s.action_close()
neg_test('discharge sample close without lab evidence', t_discharge_close,
['Lab Report', 'Results Received', 'parameter', 'Lab certificate'])
# Test 11: Invoice ref auto-fill from SO at create time
step('SYSTEM', 'Test 11 — Invoice ref auto-fills from SO.client_order_ref')
test_inv2 = env['account.move'].sudo().create({
'move_type': 'out_invoice',
'partner_id': customer.id,
'invoice_date': fields.Date.today(),
'invoice_origin': so.name,
'invoice_line_ids': [(0, 0, {
'name': 'Test', 'quantity': 1, 'price_unit': 1.0,
})],
})
finding('PASS' if test_inv2.ref == so.client_order_ref else 'FAIL',
'invoice ref auto-fills from SO',
f'ref={test_inv2.ref!r} (expected {so.client_order_ref!r})')
test_inv2.sudo().unlink()
# =====================================================================
banner('PHASE 5 — Operators run their work orders (REAL-TIME timers)')
# =====================================================================