fix(fusion_repairs): code-review batch - 4 critical + 8 high + 8 medium/low

Critical
- C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation)
- C2: variance threshold no longer uses abs() - under-cost is good news,
  must not block invoicing. Now only OVER-cost triggers requires_requote.
- C3: roll_next_due_date() was dead code - now wired from
  fusion.technician.task.write() when a maintenance task transitions to
  'completed', so the whole maintenance lifecycle actually advances.
- C4: warranty.is_active was store=True but time-dependent (became stale).
  Dropped store=True; find_active_for() now filters by expiry_date directly.

High
- H1: added x_fc_maintenance_contract_id back-link on repair.order and
  populated it from create_repair_from_booking().
- H2: find_active_for() returns empty when neither lot nor product is
  supplied - prevents cross-product false warranty matches.
- H3: visit-report wizard now creates stock.move records of repair_line_type
  'add' for each part line, so Odoo's native action_create_sale_order()
  chain has lines to invoice and stock gets consumed properly.
- H4: office intake email template now carries a fallback email_to header
  computed from res.company.x_fc_office_notification_ids (or company email),
  so it does not silently send with no recipient.
- H5: maintenance reminder cron nextcall now always rolls to tomorrow
  at 07:00 local time, so installing/upgrading after 07:00 does not
  immediately fire all the day's reminders.
- H6: public portal no longer hardcodes UID 1 as the intake user fallback
  (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the
  lowest-id non-share user, else SUPERUSER_ID.
- H7: public portal validates client_email via tools.email_normalize
  before partner creation; malformed addresses redirect with error=email.
- H8: find_best_match() returns empty when no symptom keywords match
  (no silent first-catalog guess) and uses word-boundary regex to avoid
  matching 'battery' inside 'no battery problem'.

Medium
- M1: _inherit moved next to _name on maintenance_contract (cosmetic but
  brittle if Odoo refactors model class detection)
- M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty
  and maintenance intervals (correct month boundaries)
- M3: unique constraint on fusion.repair.maintenance.contract.booking_token
- M6: dispatch task fallback now searches for an actual x_fc_is_field_staff
  user; gracefully skips and logs if no field staff exists (instead of
  silently failing the constraint check)
- M7: maintenance contract list view date decoration uses context_today()
  (date) instead of strftime(string) - the str comparison would TypeError
- M9: Visit Report button hidden on draft repairs and when no technician
  task is linked yet

Low
- L2: portal-created partners get default lang + company_id so mail
  templates render in the right language
- L3: dropped unused exception variable in sales rep portal controller
- L4: visit-report wizard 'found another issue' now redirects to the
  spawned stub repair so the tech can fill it in immediately
- L5: dropped unrecognized data-string from <app> in settings view

Public portal also: rate-limit check moved BEFORE the counter increment so
blocked attempts do not keep inflating the bucket.

All fixes verified end-to-end on local westin-v19:
- variance one-sided: 0.5h labour vs $500 est -> requires_requote=False;
  2h x $250 + $200 parts vs $100 est -> requires_requote=True
- maintenance roll-forward: created MC/00006 due 2026-05-31, completed
  linked maintenance task -> contract rolled to 2026-11-21 with
  last_reminder_band reset
- warranty find_active_for(partner only) -> empty recordset
- service catalog find_best_match with unrelated text -> empty recordset
- pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique
- /repair landing still 200 after restart

Co-authored-by: Cursor <cursoragent@cursor.com>

fusion_repairs/controllers/portal_client_repair.py

@@ -29,8 +29,9 @@ import logging
 import re
 import time
 
-from odoo import http, fields
+from odoo import SUPERUSER_ID, http, fields
 from odoo.http import request
+from odoo.tools import email_normalize
 
 _logger = logging.getLogger(__name__)
 
@@ -92,9 +93,10 @@ class ClientRepairPortal(http.Controller):
         for k in list(_RATE_LIMIT_BUCKET.keys()):
             if not k.endswith(f":{bucket}"):
                 _RATE_LIMIT_BUCKET.pop(k, None)
-        _RATE_LIMIT_BUCKET[key] = _RATE_LIMIT_BUCKET.get(key, 0) + 1
-        if _RATE_LIMIT_BUCKET[key] > limit:
+        # Check FIRST so blocked attempts don't keep inflating the counter.
+        if _RATE_LIMIT_BUCKET.get(key, 0) >= limit:
             return True  # blocked
+        _RATE_LIMIT_BUCKET[key] = _RATE_LIMIT_BUCKET.get(key, 0) + 1
         return False
 
     # ------------------------------------------------------------------
@@ -164,6 +166,12 @@ class ClientRepairPortal(http.Controller):
         if not (partner_name and phone and issue_summary and category_id):
             return request.redirect("/repair/new?error=missing")
 
+        # Validate email if provided. Empty is allowed; malformed redirects back.
+        raw_email = (post.get("client_email") or "").strip()
+        clean_email = email_normalize(raw_email) if raw_email else False
+        if raw_email and not clean_email:
+            return request.redirect("/repair/new?error=email")
+
         # Find or create partner. Match by phone if known (safe - we already
         # have their consent to contact via this form).
         cleaned_phone = _e164_clean(phone)
@@ -180,7 +188,7 @@ class ClientRepairPortal(http.Controller):
             partner_vals = {
                 "name": partner_name,
                 "phone": phone,
-                "email": (post.get("client_email") or "").strip(),
+                "email": clean_email or False,
                 "street": (post.get("client_street") or "").strip(),
                 "city": (post.get("client_city") or "").strip(),
             }
@@ -209,13 +217,21 @@ class ClientRepairPortal(http.Controller):
             "internal_notes": (post.get("internal_notes") or "").strip(),
             "photo_attachment_ids": attachment_ids,
         }
+        # Pick a real human owner for the repair so emails go from a person:
+        # admin if present, else the lowest-id non-share user, else SUPERUSER_ID.
+        admin = request.env.ref("base.user_admin", raise_if_not_found=False)
+        if admin:
+            intake_uid = admin.id
+        else:
+            internal = request.env["res.users"].sudo().search(
+                [("share", "=", False)], order="id asc", limit=1,
+            )
+            intake_uid = internal.id if internal else SUPERUSER_ID
+
         payload = {
             "partner_id": partner.id if partner else None,
             "partner_vals": partner_vals,
-            "intake_user_id": request.env.ref(
-                "base.user_admin", raise_if_not_found=False).id
-                if request.env.ref("base.user_admin",
-                                   raise_if_not_found=False) else 1,
+            "intake_user_id": intake_uid,
             "equipment_items": [equipment],
         }
 

fusion_repairs/controllers/portal_sales_rep_repair.py

@@ -135,7 +135,7 @@ class SalesRepRepairPortal(CustomerPortal):
         try:
             repairs = request.env['fusion.repair.intake.service'].sudo() \
                 .create_repair_orders(payload, source='sales_rep_portal')
-        except Exception as e:
+        except Exception:
             _logger.exception('Sales rep portal repair submit failed')
             return request.redirect('/my/repair/new?error=server')