fix(fusion_repairs): code-review batch - 4 critical + 8 high + 8 medium/low

Critical
- C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation)
- C2: variance threshold no longer uses abs() - under-cost is good news,
  must not block invoicing. Now only OVER-cost triggers requires_requote.
- C3: roll_next_due_date() was dead code - now wired from
  fusion.technician.task.write() when a maintenance task transitions to
  'completed', so the whole maintenance lifecycle actually advances.
- C4: warranty.is_active was store=True but time-dependent (became stale).
  Dropped store=True; find_active_for() now filters by expiry_date directly.

High
- H1: added x_fc_maintenance_contract_id back-link on repair.order and
  populated it from create_repair_from_booking().
- H2: find_active_for() returns empty when neither lot nor product is
  supplied - prevents cross-product false warranty matches.
- H3: visit-report wizard now creates stock.move records of repair_line_type
  'add' for each part line, so Odoo's native action_create_sale_order()
  chain has lines to invoice and stock gets consumed properly.
- H4: office intake email template now carries a fallback email_to header
  computed from res.company.x_fc_office_notification_ids (or company email),
  so it does not silently send with no recipient.
- H5: maintenance reminder cron nextcall now always rolls to tomorrow
  at 07:00 local time, so installing/upgrading after 07:00 does not
  immediately fire all the day's reminders.
- H6: public portal no longer hardcodes UID 1 as the intake user fallback
  (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the
  lowest-id non-share user, else SUPERUSER_ID.
- H7: public portal validates client_email via tools.email_normalize
  before partner creation; malformed addresses redirect with error=email.
- H8: find_best_match() returns empty when no symptom keywords match
  (no silent first-catalog guess) and uses word-boundary regex to avoid
  matching 'battery' inside 'no battery problem'.

Medium
- M1: _inherit moved next to _name on maintenance_contract (cosmetic but
  brittle if Odoo refactors model class detection)
- M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty
  and maintenance intervals (correct month boundaries)
- M3: unique constraint on fusion.repair.maintenance.contract.booking_token
- M6: dispatch task fallback now searches for an actual x_fc_is_field_staff
  user; gracefully skips and logs if no field staff exists (instead of
  silently failing the constraint check)
- M7: maintenance contract list view date decoration uses context_today()
  (date) instead of strftime(string) - the str comparison would TypeError
- M9: Visit Report button hidden on draft repairs and when no technician
  task is linked yet

Low
- L2: portal-created partners get default lang + company_id so mail
  templates render in the right language
- L3: dropped unused exception variable in sales rep portal controller
- L4: visit-report wizard 'found another issue' now redirects to the
  spawned stub repair so the tech can fill it in immediately
- L5: dropped unrecognized data-string from <app> in settings view

Public portal also: rate-limit check moved BEFORE the counter increment so
blocked attempts do not keep inflating the bucket.

All fixes verified end-to-end on local westin-v19:
- variance one-sided: 0.5h labour vs $500 est -> requires_requote=False;
  2h x $250 + $200 parts vs $100 est -> requires_requote=True
- maintenance roll-forward: created MC/00006 due 2026-05-31, completed
  linked maintenance task -> contract rolled to 2026-11-21 with
  last_reminder_band reset
- warranty find_active_for(partner only) -> empty recordset
- service catalog find_best_match with unrelated text -> empty recordset
- pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique
- /repair landing still 200 after restart

Co-authored-by: Cursor <cursoragent@cursor.com>

fusion_repairs/models/intake_service.py

@@ -90,6 +90,10 @@ class FusionRepairIntakeService(models.AbstractModel):
         partner_vals = payload.get('partner_vals')
         if not partner_vals:
             return False
+        # Sensible defaults for partners created via public portals so mail
+        # templates pick up the right language / company.
+        partner_vals.setdefault('lang', self.env.user.lang or 'en_CA')
+        partner_vals.setdefault('company_id', self.env.company.id)
         partner = self.env['res.partner'].sudo().create(partner_vals)
         return partner.id
 
@@ -401,12 +405,25 @@ class FusionRepairIntakeService(models.AbstractModel):
                 'x_fc_repair_order_id': repair.id,
                 'description': repair.internal_notes or repair.name,
             }
-            # technician_id is required on fusion.technician.task; we fall back to
-            # the intake user. Dispatcher will reassign.
-            vals['technician_id'] = (
-                repair.user_id.id if repair.user_id and repair.user_id.x_fc_is_field_staff
-                else self.env.uid
-            )
+            # technician_id is required AND constrained to x_fc_is_field_staff.
+            # Use the intake user if they qualify, otherwise the lowest-id active
+            # field-staff user as a placeholder for the dispatcher to reassign.
+            if repair.user_id and repair.user_id.x_fc_is_field_staff:
+                vals['technician_id'] = repair.user_id.id
+            else:
+                fallback = self.env['res.users'].sudo().search([
+                    ('x_fc_is_field_staff', '=', True),
+                    ('active', '=', True),
+                ], order='id', limit=1)
+                if not fallback:
+                    _logger.warning(
+                        'No field-staff user available - skipping auto-dispatch '
+                        'task for repair %s (mark a user as Field Staff under '
+                        'Settings > Users).',
+                        repair.name,
+                    )
+                    return
+                vals['technician_id'] = fallback.id
             Task.create(vals)
         except Exception as e:
             _logger.warning('Failed to auto-create dispatch task for repair %s: %s',
@@ -449,8 +466,13 @@ class FusionRepairIntakeService(models.AbstractModel):
     @api.model
     def _office_emails(self, company):
         # Reuse the office notification recipients defined by fusion_claims.
-        partners = company.sudo()
-        recipients = getattr(partners, 'x_fc_office_notification_ids', False)
-        if recipients:
-            return [p.email for p in recipients if p.email]
-        return []
+        company_sudo = company.sudo()
+        recipients = getattr(company_sudo, 'x_fc_office_notification_ids', False)
+        emails = [p.email for p in (recipients or []) if p.email]
+        if not emails:
+            _logger.info(
+                'No office notification recipients configured on company %s - '
+                'skipping office intake email.',
+                company.name,
+            )
+        return emails