From ca60500c0783666ea8cb83526e27bf27cf4c17b5 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Sun, 17 May 2026 13:44:41 -0400
Subject: [PATCH] fix(portal): guard sidebar item dict access with .get()
 fallbacks

Direct entry['url'] / entry['label'] would 500 the portal page if a
future helper emits an item dict missing a key. Use .get('url', '#')
and .get('label', '') so a malformed entry degrades silently instead
of taking the page down. Helper data is currently trusted (defined
in _FP_SIDEBAR_LAYOUT class constant) but defensive iteration is
cheap and prevents regression bugs from cascading.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../fusion_plating_portal/views/fp_portal_shell.xml         | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fusion_plating/fusion_plating_portal/views/fp_portal_shell.xml b/fusion_plating/fusion_plating_portal/views/fp_portal_shell.xml
index 7b296663..02d2157e 100644
--- a/fusion_plating/fusion_plating_portal/views/fp_portal_shell.xml
+++ b/fusion_plating/fusion_plating_portal/views/fp_portal_shell.xml
@@ -81,14 +81,14 @@
             <t t-foreach="fp_sidebar_items or []" t-as="entry">
                 <!-- Section labels render as non-link headers -->
                 <t t-if="entry.get('type') == 'section_label'">
-                    <div class="o_fp_sidebar_section_label" t-out="entry['label']"/>
+                    <div class="o_fp_sidebar_section_label" t-out="entry.get('label', '')"/>
                 </t>
                 <!-- Items render as anchor links -->
                 <t t-elif="entry.get('type') == 'item'">
-                    <a t-att-href="entry['url']"
+                    <a t-att-href="entry.get('url', '#')"
                        t-attf-class="o_fp_sidebar_item #{'o_fp_sidebar_active' if entry.get('active') else ''}">
                         <span class="o_fp_sidebar_icon" t-out="entry.get('icon') or '&#x2022;'"/>
-                        <span t-out="entry['label']"/>
+                        <span t-out="entry.get('label', '')"/>
                     </a>
                 </t>
             </t>