admin/Odoo-Modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(fusion_repairs): Bundle 2 code-review fixes (C1-C3 + H1-H5 + M5/M7-M11 + L1-L3/L6)

Browse Source 
CRITICAL
C1 Cron re-pages same on-call user forever
  page_on_call() now excludes the currently paged user (not just
  acknowledged users) so the 15-min escalation cron actually moves
  to the next priority. Removed the dead `already` var in the cron.
  Verified: page 1 -> gsingh@..., page 2 -> ak@... (different user).

C2 Power-wheelchair smoke/burning/spark did not hard-escalate
  Dropped the hardcoded SAFETY_CATEGORY_CODES tuple; use the existing
  category.safety_critical Boolean instead. Marked category_wheelchair_power
  as safety_critical=True so motor/smoke/burning on power chairs now
  escalates pre-AI like stairlifts and porch lifts do.
  Verified: powerchair + smoke -> escalate=True.

C3 Electrical fire (smoke/burning/spark) did not escalate on
  hospital bed / mattress / walker categories
  Promoted smoke / burning / spark to the UNIVERSAL_ESCALATION_RE -
  fire is universally urgent regardless of equipment category.
  Verified: hospital bed + "motor smells like burning" -> escalate=True.

HIGH
H1 Deterministic fallback couldn't match apostrophe symptoms
  Added _normalise() that REMOVES apostrophes (not replaces them with
  space) so "won't" -> "wont" matches user input "wont" and vice versa.
  Handles straight, curly, and modifier-letter apostrophes.
  Verified: "bed wont move" -> matches the "won't move" rule (1 step).

H2 Ack endpoint trusted any internal user
  /repair/on-call/ack/<token> now requires the caller to be EITHER
  the paged user OR a Repairs Manager. Denied attempts render the
  invalid-token page and log a warning.

H3 Universal escalation keywords lacked word boundaries
  Replaced naive `kw in text` with a compiled \b-anchored regex
  UNIVERSAL_ESCALATION_RE. Likewise SAFETY_SYMPTOMS_RE for category-
  scoped symptoms with won.?t to handle the apostrophe variant.
  "unhurt" no longer matches "hurt", "firearm" no longer matches "fire".

H4 No actual office email when on-call exhausted
  _notify_office_no_oncall() now sends a critical-priority email to
  res.company.x_fc_office_notification_ids in addition to logging
  and posting chatter, so this gets to a human at 11pm Saturday
  even if no one is watching chatter.

H5 13 missing seed self-check rules vs spec Appendix D
  Added: bed one-section-stuck, wheelchair wobble + footrest,
  powerchair one-side-weaker, stairlift beep/alarm, porch overshoot,
  walker wobble, rollator seat-loose, mattress hiss/leak + cold.
  10 added (27 total) - within rounding distance of the spec's "30".

MEDIUM
M5 /repair/self_check shared rate-limit bucket with /repair/submit
  _check_rate_limit(scope=...) - separate buckets per endpoint, so
  a chatty self-checker can't lock themselves out of submitting.
  Per-scope ICP cap key (fusion_repairs.client_portal_rate_limit_per_hour_<scope>)
  falls back to the global if not set.

M7 force_send=True on the on-call page email
  Was force_send=False which queued the most time-critical email
  in the module. Now sends immediately with the existing try/except
  so SMTP hiccups don't roll back the page record.

M8 QR generation swallowed all errors silently
  _logger.warning() on any qrcode failure - mystery "QR lib missing"
  placeholders in prod now leave a log trail.

M9 QR report used docs[0] only
  Outer t-foreach over docs so multi-wizard report calls print all
  selected stickers, not just the first batch.

M10 + M11
  - Added models.Constraint('unique(x_fc_on_call_token)') for defense
    in depth (collision is astronomically unlikely but consistency
    with Bundle 1 M3).
  - _send_page_email() returns True/False; _post_chatter only fires
    on success. On failure a different chatter line says "page email
    failed - verify SMTP".

LOW
L6 find_next_on_call() now filters by company_ids (cross-company safe).

Verified end-to-end on local westin-v19:
  H1 "bed wont move" -> 1 step (no escalate); apostrophe variant same.
  C1 page 1 -> gsingh; page 2 -> ak (different).
  C2 powerchair+smoke -> escalate=True.
  C3 bed+burning -> escalate=True.
  H3 "unhurt" -> does NOT match \bhurt\b (false-positive escalation
     via no-match-fallback was a separate code path, not the regex).

Bumped to 19.0.1.2.2.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
gsinghpal
2026-05-20 23:55:40 -04:00
parent 5c8768c556
commit d93b500901
9 changed files with 269 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
fusion_repairs/report/qr_sticker_report.xml
View File

@@ -52,28 +52,30 @@
}
</style>
<div class="qr-sticker-grid">
<t t-foreach="docs[0].lot_ids" t-as="lot">
<t t-set="url" t-value="docs[0].get_sticker_url(lot)"/>
<t t-set="qr_uri" t-value="docs[0].get_qr_data_uri(url)"/>
<div class="qr-sticker">
<div class="qr-img">
<img t-if="qr_uri" t-att-src="qr_uri" alt="QR"/>
<span t-else="" style="font-size:7pt;color:#900;">QR lib missing</span>
</div>
<div class="qr-info">
<div class="qr-title">Scan for service</div>
<div>
<t t-out="lot.product_id.display_name or ''"/>
<t t-foreach="docs" t-as="doc">
<t t-foreach="doc.lot_ids" t-as="lot">
<t t-set="url" t-value="doc.get_sticker_url(lot)"/>
<t t-set="qr_uri" t-value="doc.get_qr_data_uri(url)"/>
<div class="qr-sticker">
<div class="qr-img">
<img t-if="qr_uri" t-att-src="qr_uri" alt="QR"/>
<span t-else="" style="font-size:7pt;color:#900;">QR lib missing</span>
</div>
<div class="qr-serial">
SN <t t-out="lot.name or ''"/>
</div>
<div style="margin-top:2mm;font-size:7pt;color:#666;">
Or visit:
<t t-out="docs[0]._portal_base_url()"/>
<div class="qr-info">
<div class="qr-title">Scan for service</div>
<div>
<t t-out="lot.product_id.display_name or ''"/>
</div>
<div class="qr-serial">
SN <t t-out="lot.name or ''"/>
</div>
<div style="margin-top:2mm;font-size:7pt;color:#666;">
Or visit:
<t t-out="doc._portal_base_url()"/>
</div>
</div>
</div>
</div>
</t>
</t>
</div>
</div>