From e923e9fc00a7409bc1804a27e9ccd0f583064b05 Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Fri, 22 May 2026 23:07:15 -0400
Subject: [PATCH] fix(fusion_plating_jobs): delete orphan Plant Overview menu
 record
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Phase 3 removed the menu_fp_shopfloor_plant_overview menuitem from
fp_menu.xml, but Odoo doesn't auto-delete orphan records when XML
disappears — the menu stayed in the database. Combined with P3.5's
action retarget (action_fp_plant_overview tag → fp_shopfloor_landing),
clicking it landed on the same Landing component as Workstation —
hence the duplicate menu items both opening the same screen.

Adds <delete model='ir.ui.menu' id='...'> in legacy_menu_hide.xml so
future -u runs scrub the orphan. Drops the now-defunct group_ids
block for the deleted menu. The action record stays (bookmark
back-compat).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../fusion_plating_jobs/views/legacy_menu_hide.xml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/fusion_plating/fusion_plating_jobs/views/legacy_menu_hide.xml b/fusion_plating/fusion_plating_jobs/views/legacy_menu_hide.xml
index 6d20bae3..757753da 100644
--- a/fusion_plating/fusion_plating_jobs/views/legacy_menu_hide.xml
+++ b/fusion_plating/fusion_plating_jobs/views/legacy_menu_hide.xml
@@ -9,20 +9,26 @@
          site that needs to bring legacy menus back can simply add a
          user to the group. -->
 
-    <!-- Reset group_ids on the 3 shopfloor menus that used to be
+    <!-- Reset group_ids on the shopfloor menus that used to be
          hidden — they are now the canonical UIs and should be visible
          to all users (subject to the original groups= attribute on
          each menuitem in fusion_plating_shopfloor/views/fp_menu.xml). -->
     <record id="fusion_plating_shopfloor.menu_fp_shopfloor_manager" model="ir.ui.menu">
         <field name="group_ids" eval="[(6, 0, [ref('fusion_plating.group_fusion_plating_manager')])]"/>
     </record>
-    <record id="fusion_plating_shopfloor.menu_fp_shopfloor_plant_overview" model="ir.ui.menu">
-        <field name="group_ids" eval="[(6, 0, [])]"/>
-    </record>
     <record id="fusion_plating_shopfloor.menu_fp_shopfloor_tablet" model="ir.ui.menu">
         <field name="group_ids" eval="[(6, 0, [])]"/>
     </record>
 
+    <!-- Phase 3 tablet redesign (2026-05-22) — the standalone Plant
+         Overview menu is superseded by Workstation > All Plant toggle.
+         The fp_menu.xml record was removed but the database row
+         persists (Odoo doesn't auto-delete orphan records). Force-
+         delete here so the menu disappears from the Shop Floor tree.
+         The action record (action_fp_plant_overview) is kept and
+         retargeted to fp_shopfloor_landing for bookmark back-compat. -->
+    <delete model="ir.ui.menu" id="fusion_plating_shopfloor.menu_fp_shopfloor_plant_overview"/>
+
     <!-- bridge_mrp Production Priorities reference removed post-Sub 11
          (the bridge module is uninstalled and its menu xmlid no longer
          resolves). fp.job has its own priority field on the header. -->