changes

fusion_plating/fusion_plating_notifications/models/fp_notification_template.py

@@ -13,11 +13,16 @@ TRIGGER_EVENTS = [
     ('quote_sent', 'Quotation Sent'),
     ('so_confirmed', 'Order Confirmed'),
     ('parts_received', 'Parts Received'),
-    ('mo_complete', 'Manufacturing Complete'),
+    ('mo_complete', 'Manufacturing Complete'),  # legacy, fired by mrp; kept for back-compat
+    ('job_confirmed', 'Plating Job Confirmed'),  # Sub 11 — fp.job lifecycle
+    ('job_complete', 'Plating Job Complete'),    # Sub 11 — fp.job.button_mark_done
     ('shipped', 'Shipped / Delivered'),
     ('invoice_posted', 'Invoice Posted'),
     ('payment_received', 'Payment Received'),
     ('deposit_created', 'Deposit Required'),
+    ('rma_authorised', 'RMA Authorised'),     # Sub 12 — RMA lifecycle
+    ('rma_received', 'RMA Parts Received'),
+    ('rma_resolved', 'RMA Resolved'),
 ]
 
 # Sub 6 — map each trigger event to a communication stream. Contacts on
@@ -29,10 +34,15 @@ FP_TRIGGER_STREAM = {
     'so_confirmed':     'quotes_so',
     'parts_received':   'quotes_so',
     'mo_complete':      'qc',
+    'job_confirmed':    'qc',
+    'job_complete':     'qc',
     'shipped':          'certs',
     'invoice_posted':   'invoices',
     'payment_received': 'invoices',
     'deposit_created':  'invoices',
+    'rma_authorised':   'qc',
+    'rma_received':     'qc',
+    'rma_resolved':     'qc',
 }
 
 
@@ -117,6 +127,9 @@ class FpNotificationTemplate(models.Model):
                 )
             elif partner.email:
                 recipient_emails = [partner.email]
+        # Filter out falsy entries — sub-contacts may have no email and the
+        # resolver returns False/None for them. Joining with bool blows up.
+        recipient_emails = [e for e in (recipient_emails or []) if e]
         recipient_str = ', '.join(recipient_emails)
 
         email_values = {}