From f979bc686d0f8a0c58d6682946b830c2e908060b Mon Sep 17 00:00:00 2001
From: gsinghpal <gur_preet.singh@outlook.com>
Date: Sun, 19 Apr 2026 11:52:53 -0400
Subject: [PATCH] fix(plating): Process Details tab no longer red on every WO
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Bug: in Odoo 19, `required="1"` on a field inside an `invisible="..."`
group still triggers the missing-required-field flag — paints the
whole tab red on EVERY WO regardless of whether the field is shown.

Symptom: Process Details tab was red on masking, racking, oven, etc.
because the rack and mask groups' required fields were always
flagged as missing even when their parent group was hidden.

Fix: switch `required="1"` to `required="x_fc_wo_kind == 'rack'"` and
`required="x_fc_wo_kind == 'mask'"` so the required flag only fires
when the field is actually relevant. Matches the existing pattern
on bath/tank/oven (`required="x_fc_requires_bath"` etc.).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../views/mrp_workorder_views.xml                    | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/fusion_plating/fusion_plating_bridge_mrp/views/mrp_workorder_views.xml b/fusion_plating/fusion_plating_bridge_mrp/views/mrp_workorder_views.xml
index cb6f3d06..4a2971bd 100644
--- a/fusion_plating/fusion_plating_bridge_mrp/views/mrp_workorder_views.xml
+++ b/fusion_plating/fusion_plating_bridge_mrp/views/mrp_workorder_views.xml
@@ -203,17 +203,23 @@
                             <field name="x_fc_bake_duration_hours"/>
                         </group>
                     </group>
-                    <!-- Rack / de-rack WOs -->
+                    <!-- Rack / de-rack WOs.
+                         Note: required="x_fc_wo_kind == 'rack'" (not "1") —
+                         in Odoo 19 a `required="1"` on a field inside an
+                         invisible group still triggers the missing-required
+                         flag, painting the whole tab red on every WO. -->
                     <group invisible="x_fc_wo_kind != 'rack'">
                         <group string="Rack">
-                            <field name="x_fc_rack_id" required="1"/>
+                            <field name="x_fc_rack_id"
+                                   required="x_fc_wo_kind == 'rack'"/>
                             <field name="x_fc_rack_ref"/>
                         </group>
                     </group>
                     <!-- Mask / De-mask WOs -->
                     <group invisible="x_fc_wo_kind != 'mask'">
                         <group string="Masking">
-                            <field name="x_fc_masking_material" required="1"/>
+                            <field name="x_fc_masking_material"
+                                   required="x_fc_wo_kind == 'mask'"/>
                         </group>
                     </group>
                     <!-- Inspection -->