Files
gsinghpal c118b7c6b5 feat(plating): close compliance gaps 7-9 — NCR + CAPA + discharge + invoice ref
**7a. NCR close gate** (fusion.plating.ncr.action_close)
Block close unless these are filled in:
  • Description (what happened)
  • Containment Actions (immediate response)
  • Root Cause (why it happened)
  • Disposition (use-as-is / rework / scrap / RTV decision)

A closed NCR without these is useless for AS9100 audits — it's
the entire point of an NCR to document what went wrong, why, and
how we responded. Empty-HTML strings like "<p><br></p>" are
detected as empty too.

**7b. CAPA close gate** (fusion.plating.capa.action_close)
Block close unless:
  • Root Cause Analysis filled in
  • Action Plan filled in
  • Verification (date + verifier) recorded
  • Effectiveness Notes filled when CAPA was marked Not Effective

AS9100 §10.2 / Nadcap require evidence of root-cause analysis,
the corrective/preventive action plan, AND that effectiveness
was verified before the loop is closed.

**8. Invoice ref defensive default** (account.move.create)
Auto-fills `ref` from the source SO's client_order_ref or
x_fc_po_number when the invoice is created with invoice_origin set
but no ref. Already populated on the SO confirm path; this catches
manually-created invoices that would otherwise miss it. Customer
AP teams reject invoices that don't quote their PO# back.

**9. Discharge sample close gate** (fusion.plating.discharge.sample.action_close)
Block close unless:
  • Lab Report # set
  • Results Received Date set
  • At least one parameter reading on file
  • Lab certificate/report attached

Without lab evidence the record fails any environmental compliance
audit — the whole point is to document the test was performed and
what the lab said.

**Simulator** (scripts/fp_e2e_workforce.py)
Adds 4 new negative tests (Test 8-11), all wrapped in savepoints:
  ✓ Test 8 : NCR close without RC/containment/disposition → blocked
  ✓ Test 9 : CAPA close without analysis/plan/verification → blocked
  ✓ Test 10: Discharge sample close without lab evidence → blocked
  ✓ Test 11: Invoice ref auto-fills from SO.client_order_ref → asserted

**Final E2E**: 52 PASS / 2 WARN / 0 FAIL out of 54 checks.
Both remaining WARNs are expected (bake-window auto-create,
first-piece gate — coating-driven, this coating doesn't trigger them).

11 negative tests in total now, every gate fires when triggered.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 10:35:27 -04:00

96 lines
4.3 KiB
Python

# -*- coding: utf-8 -*-
# Copyright 2026 Nexa Systems Inc.
# License OPL-1 (Odoo Proprietary License v1.0)
from odoo import _, api, fields, models
from odoo.exceptions import UserError
class FpDischargeSample(models.Model):
_name = 'fusion.plating.discharge.sample'
_description = 'Fusion Plating - Discharge Sample'
_inherit = ['mail.thread', 'mail.activity.mixin']
_order = 'sample_date desc, id desc'
name = fields.Char(string='Reference', required=True, copy=False, default=lambda s: s._default_name(), tracking=True)
facility_id = fields.Many2one('fusion.plating.facility', string='Facility', required=True, ondelete='restrict', tracking=True)
company_id = fields.Many2one('res.company', related='facility_id.company_id', store=True, readonly=True)
sample_date = fields.Datetime(string='Sample Date', required=True, default=fields.Datetime.now, tracking=True)
sample_point = fields.Char(string='Sample Point')
collected_by_id = fields.Many2one('res.users', string='Collected By')
chain_of_custody_ref = fields.Char(string='Chain of Custody #')
lab_id = fields.Many2one('res.partner', string='Lab', domain=[('is_company', '=', True)])
lab_report_ref = fields.Char(string='Lab Report #')
received_date = fields.Date(string='Results Received')
state = fields.Selection(
[('draft', 'Draft'), ('sent_to_lab', 'Sent to Lab'), ('results_in', 'Results In'),
('escalated', 'Escalated'), ('closed', 'Closed')],
string='Status', default='draft', required=True, tracking=True,
)
line_ids = fields.One2many('fusion.plating.discharge.sample.line', 'sample_id', string='Parameters', copy=True)
worst_status = fields.Selection(
[('ok', 'OK'), ('warning', 'Warning'), ('out_of_spec', 'Out of Spec'), ('pending', 'Pending')],
string='Worst Result', compute='_compute_worst_status', store=True,
)
notes = fields.Html(string='Notes')
attachment_ids = fields.Many2many(
'ir.attachment', 'fp_discharge_sample_attachment_rel', 'sample_id', 'attachment_id', string='Attachments',
)
active = fields.Boolean(default=True)
@api.model
def _default_name(self):
seq = self.env['ir.sequence'].next_by_code('fusion.plating.discharge.sample')
return seq or '/'
@api.depends('line_ids', 'line_ids.status')
def _compute_worst_status(self):
order = ['out_of_spec', 'warning', 'pending', 'ok']
for rec in self:
statuses = [l.status for l in rec.line_ids if l.status]
worst = 'pending'
for s in order:
if s in statuses:
worst = s
break
rec.worst_status = worst if statuses else 'pending'
def action_send_to_lab(self):
self.write({'state': 'sent_to_lab'})
def action_results_in(self):
self.write({'state': 'results_in', 'received_date': fields.Date.context_today(self)})
def action_escalate(self):
self.write({'state': 'escalated'})
def action_close(self):
"""Block close until lab evidence is on file.
A closed discharge sample without a lab report ref + at least
one parameter reading + (when results are in) a lab cert
attachment fails any environmental audit. The whole point
of the record is to document the test was performed and what
the lab said.
"""
for rec in self:
missing = []
if not rec.lab_report_ref:
missing.append(_('Lab Report #'))
if not rec.received_date:
missing.append(_('Results Received Date'))
if not rec.line_ids:
missing.append(_('At least one parameter reading'))
if not rec.attachment_ids:
missing.append(_('Lab certificate / report attachment'))
if missing:
raise UserError(_(
'Cannot close discharge sample "%(name)s" — these '
'fields must be filled in first:\n%(fields)s\n\n'
'Without lab evidence on file the record fails any '
'environmental compliance audit.'
) % {
'name': rec.name or rec.display_name,
'fields': '\n'.join(missing),
})
self.write({'state': 'closed'})