Files
Odoo-Modules/fusion_plating/fusion_plating_jobs
gsinghpal e4681a58c6 fix(jobs): split fp.jobs by thickness + serial on SO confirm
The _fp_auto_create_job grouping key was (recipe, part, coating).
Lines that shared all three but differed in thickness (or serial)
silently collapsed into one fp.job — the second line's thickness/SN
was lost, and any downstream cert printed the first line's values
across both batches. Silent mis-attestation = compliance hole.

Extended the key tuple to (recipe, part, coating, thickness, serial).
Single-line SOs and same-(thickness, SN) multi-line SOs collapse
identically to before. Only lines that previously merged when they
shouldn't have now split into their own fp.jobs.

TDD via test_so_confirm_splits_by_thickness:
  - seeds the part with default_process_id so both lines hit the
    `if recipe:` branch (where the bug lived — the no_recipe branch
    already split correctly per line)
  - confirms 2 jobs after action_confirm with each carrying its
    own thickness via the linked SO line

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 07:57:56 -04:00
..
2026-04-26 10:46:44 -04:00
2026-04-26 15:05:17 -04:00
2026-05-10 10:25:12 -04:00
2026-04-28 19:39:37 -04:00

fusion_plating_jobs

Native plating job bridge — wires fp.job and fp.job.step (defined in fusion_plating core, Phase 1 of the migration spec dated 2026-04-25) into the rest of the Fusion Plating module family: configurator, portal, logistics, quality, certificates, batches, KPI, notifications, reports.

Coexists with fusion_plating_bridge_mrp during the migration period. The x_fc_use_native_jobs settings flag (default: False) toggles the behaviour. When False, SO confirm continues to create mrp.production records through bridge_mrp. When True, SO confirm creates fp.job records here.

See docs/superpowers/specs/2026-04-25-fp-native-job-model-design.md for full design rationale and §6 of the implementation plan for phase breakdown.

Phase 6 — deferred items

Phase 6 originally scoped the full operator UI rewrite. With Tailscale SSH to entech currently unavailable we cannot live-test OWL/JS in the browser, so Phase 6 ships a lean version: the data-layer endpoints land now, the rendering UI lands later.

Deferred to post-cutover hardening:

  • Plant Overview kanban over fp.job.step — replaces fusion_plating_shopfloor's mrp.workorder kanban.
  • Tablet Station UI rewrite over fp.job / fp.job.step.
  • Manager Dashboard rewrite.
  • Process Tree OWL component — currently a stub: /fp/jobs/process_tree returns the serialized recipe tree as JSON, but the OWL component to render it is not built.

Rationale: these are large OWL/JS components that need live in-browser verification on entech. Under the migration's parallel-coexistence strategy, operators continue using the existing shopfloor UI (bound to mrp.workorder) until cutover. After cutover, the operator UI rewrite becomes its own focused project — the data layer (fp.job, fp.job.step, time logs, timestamps) is fully in place from Phase 15.

Phase 6 — what shipped

  • /fp/job/<id> — scan-redirect controller. The fp.job sticker QR encodes this URL. Routes managers to the fp.job form; routes operators to the same form for now (will swap to the process tree client action once the OWL component lands).
  • /fp/jobs/process_tree — JSON-RPC endpoint that returns the recipe tree for a job, with each node tagged by its matching fp.job.step state, ready for an OWL component to consume.