Files
Odoo-Modules/fusion_plating/fusion_plating_jobs
gsinghpal a2e254b934 fix(fp.job): post-shop state machine entech smoke fixes (Task 23)
Three bugs caught + fixed during entech battle test:

1. _fp_check_finish_gates calling button_mark_done triggered the
   step-completion gate prematurely (step still in_progress at
   pre-super time). Pass fp_skip_step_gate=True alongside
   fp_check_gates_only — we know the operator is about to finish
   the last open step.

2. _fp_schedule_cert_activity used env.get('fp.notification.template')
   for presence check. env.get returns an EMPTY recordset (falsy),
   not None — 'if not Template: return' silently exited and no
   activity was ever scheduled. Switch to 'in self.env' check
   pattern + explicit indexing. CLAUDE.md Rule 24.

3. _fp_check_advance_after_cert_issue + _fp_check_regress_after_cert_void
   used 'state != issued' as outstanding-cert count. This made
   voided certs count as outstanding forever, so void+re-issue
   cycles never re-advanced. Switch to per-type coverage check:
   each required cert TYPE needs at least one issued cert.
   Regress mirrors: only fire if a type loses all issued certs.

CLAUDE.md gains Rule 24 (env.get falsy empty recordset trap).
Rule 25 (mail.template parse-time validation) renumbered.

Battle test ALL PASS on entech admin DB:
  10/10 steps green — auto-advance, kanban placement, activity
  schedule + auto-resolve, ACL guard, cert issue advance, void
  regress, re-issue advance, manual ship.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-25 10:45:35 -04:00
..
2026-04-26 10:46:44 -04:00
2026-05-17 03:20:33 -04:00
2026-05-21 03:37:25 -04:00
2026-04-28 19:39:37 -04:00

fusion_plating_jobs

Native plating job bridge — wires fp.job and fp.job.step (defined in fusion_plating core, Phase 1 of the migration spec dated 2026-04-25) into the rest of the Fusion Plating module family: configurator, portal, logistics, quality, certificates, batches, KPI, notifications, reports.

Coexists with fusion_plating_bridge_mrp during the migration period. The x_fc_use_native_jobs settings flag (default: False) toggles the behaviour. When False, SO confirm continues to create mrp.production records through bridge_mrp. When True, SO confirm creates fp.job records here.

See docs/superpowers/specs/2026-04-25-fp-native-job-model-design.md for full design rationale and §6 of the implementation plan for phase breakdown.

Phase 6 — deferred items

Phase 6 originally scoped the full operator UI rewrite. With Tailscale SSH to entech currently unavailable we cannot live-test OWL/JS in the browser, so Phase 6 ships a lean version: the data-layer endpoints land now, the rendering UI lands later.

Deferred to post-cutover hardening:

  • Plant Overview kanban over fp.job.step — replaces fusion_plating_shopfloor's mrp.workorder kanban.
  • Tablet Station UI rewrite over fp.job / fp.job.step.
  • Manager Dashboard rewrite.
  • Process Tree OWL component — currently a stub: /fp/jobs/process_tree returns the serialized recipe tree as JSON, but the OWL component to render it is not built.

Rationale: these are large OWL/JS components that need live in-browser verification on entech. Under the migration's parallel-coexistence strategy, operators continue using the existing shopfloor UI (bound to mrp.workorder) until cutover. After cutover, the operator UI rewrite becomes its own focused project — the data layer (fp.job, fp.job.step, time logs, timestamps) is fully in place from Phase 15.

Phase 6 — what shipped

  • /fp/job/<id> — scan-redirect controller. The fp.job sticker QR encodes this URL. Routes managers to the fp.job form; routes operators to the same form for now (will swap to the process tree client action once the OWL component lands).
  • /fp/jobs/process_tree — JSON-RPC endpoint that returns the recipe tree for a job, with each node tagged by its matching fp.job.step state, ready for an OWL component to consume.