db8b79d22e
Following the workforce-E2E + required-fields audit, ship the first 6 high-priority gates so critical workflow + compliance fields can no longer be left empty by accident. **1. Invoice payment terms (account.move)** - create() now auto-inherits `invoice_payment_term_id` from partner.property_payment_term_id when missing - action_post() raises UserError if still missing — accountant must pick one before posting (prevents silent "immediate" due-date) **2. MO facility (mrp.production)** - action_confirm() auto-derives `x_fc_facility_id` if unset, in order: SO override → res.company.x_fc_default_facility_id → first active facility — then HARD GATES: raises UserError if still empty. Without facility every downstream record (WO, batch, bath log, cert) is missing the "where" half of the audit trail. **3. WO facility (mrp.workorder)** - Switched `x_fc_facility_id` from related (workcenter only) to a proper compute that falls back to production_id.x_fc_facility_id. Stub workcenters auto-created from process node names usually have no facility — the MO always does (from #2 above). **4. Thickness reading calibration_std (fp.thickness.reading)** - `calibration_std_ref` is now `required=True` with sensible default ("NiP/Al STD SET SN 100174568"). Nadcap mandates which calibration standard the gauge was checked against — without it the cert data has no chain back to a metrology record. **5. Delivery POD gate (fusion.plating.delivery)** - action_mark_delivered() raises UserError if no `pod_id`. Driver must capture POD on the iPad (recipient signature + photos + notes) BEFORE marking delivered. Without POD there's no signed receipt to back the invoice or defend a delivery dispute. **6. Certificate spec_reference gate (fp.certificate)** - action_issue() raises UserError if no `spec_reference`. The cert ATTESTS to a spec — leaving it blank produces a piece of paper that AS9100 / Nadcap auditors will (rightfully) reject. **Simulator updated**: scripts/fp_e2e_workforce.py - Sets net-30 on the test customer + ensures a default facility - New PHASE 4c: 5 negative tests (one per new gate), each wrapped in a SAVEPOINT so SQL constraint violations don't abort the txn - Driver now creates POD on iPad BEFORE marking delivered **Final E2E**: 48 PASS / 2 WARN / 0 FAIL out of 50 checks. The 2 remaining WARNs (bake-window auto-create, first-piece gate) are expected behaviour — both are coating-driven and the test coating intentionally doesn't trigger them. All 7 negative tests now pass: ✓ Test 1: WO start without operator → blocked ✓ Test 2: WO start on wet WO without bath/tank → blocked ✓ Test 3: MO confirm without facility → blocked ✓ Test 4: Cert issue without spec_reference → blocked ✓ Test 5: Delivery delivered without POD → blocked ✓ Test 6: Invoice post without payment terms → blocked ✓ Test 7: Thickness reading without cal std → blocked (DB NOT NULL) Audit script (scripts/fp_required_fields_audit.py) committed too — it's the diagnostic that surfaced these gaps and can be re-run to catch new ones. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
68 lines
2.4 KiB
Python
68 lines
2.4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2026 Nexa Systems Inc.
|
|
# License OPL-1 (Odoo Proprietary License v1.0)
|
|
# Part of the Fusion Plating product family.
|
|
|
|
from odoo import fields, models
|
|
|
|
|
|
class FpThicknessReading(models.Model):
|
|
"""Fischerscope thickness measurement data.
|
|
|
|
Captures individual XRF readings from equipment like the
|
|
Fischerscope XDAL 600. Linked to certificates and/or MOs.
|
|
Data is manually entered for now; future: CSV import from equipment.
|
|
"""
|
|
_name = 'fp.thickness.reading'
|
|
_description = 'Fusion Plating — Thickness Reading'
|
|
_order = 'reading_number'
|
|
|
|
certificate_id = fields.Many2one(
|
|
'fp.certificate', string='Certificate', ondelete='cascade',
|
|
)
|
|
production_id = fields.Many2one(
|
|
'mrp.production', string='Manufacturing Order',
|
|
)
|
|
reading_number = fields.Integer(
|
|
string='Reading #', default=1, help='Sequence number (n=1, n=2, n=3).',
|
|
)
|
|
nip_mils = fields.Float(
|
|
string='NiP (mils)', digits=(10, 4), help='NiP thickness in mils.',
|
|
)
|
|
ni_percent = fields.Float(
|
|
string='Ni %', digits=(6, 3), help='Nickel content percentage.',
|
|
)
|
|
p_percent = fields.Float(
|
|
string='P %', digits=(6, 4), help='Phosphorus content percentage.',
|
|
)
|
|
position_label = fields.Char(
|
|
string='Position', help='Where on the part this reading was taken.',
|
|
)
|
|
equipment_model = fields.Char(
|
|
string='Equipment', default='Fischerscope XDAL 600',
|
|
)
|
|
product_ref = fields.Char(
|
|
string='Product Ref', help='e.g. "2805031 / NiP/Al-alloys 2805030"',
|
|
)
|
|
calibration_std_ref = fields.Char(
|
|
string='Calibration Std',
|
|
required=True,
|
|
default='NiP/Al STD SET SN 100174568',
|
|
help='Nadcap mandatory: which calibration standard the gauge '
|
|
'was checked against. Defaults to the shop\'s primary '
|
|
'standard but should be overridden if a different std '
|
|
'was used for this reading.',
|
|
)
|
|
microscope_image_id = fields.Many2one(
|
|
'ir.attachment', string='Microscope Image',
|
|
)
|
|
operator_id = fields.Many2one(
|
|
'res.users', string='Operator', default=lambda self: self.env.user,
|
|
)
|
|
reading_datetime = fields.Datetime(
|
|
string='Reading Date/Time', default=fields.Datetime.now,
|
|
)
|
|
measuring_time_seconds = fields.Integer(
|
|
string='Measuring Time (sec)', default=120,
|
|
)
|