Files
Odoo-Modules/fusion_repairs/views/repair_order_views.xml
gsinghpal c86f1bbbe5 fix(fusion_repairs): code-review batch - 4 critical + 8 high + 8 medium/low
Critical
- C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation)
- C2: variance threshold no longer uses abs() - under-cost is good news,
  must not block invoicing. Now only OVER-cost triggers requires_requote.
- C3: roll_next_due_date() was dead code - now wired from
  fusion.technician.task.write() when a maintenance task transitions to
  'completed', so the whole maintenance lifecycle actually advances.
- C4: warranty.is_active was store=True but time-dependent (became stale).
  Dropped store=True; find_active_for() now filters by expiry_date directly.

High
- H1: added x_fc_maintenance_contract_id back-link on repair.order and
  populated it from create_repair_from_booking().
- H2: find_active_for() returns empty when neither lot nor product is
  supplied - prevents cross-product false warranty matches.
- H3: visit-report wizard now creates stock.move records of repair_line_type
  'add' for each part line, so Odoo's native action_create_sale_order()
  chain has lines to invoice and stock gets consumed properly.
- H4: office intake email template now carries a fallback email_to header
  computed from res.company.x_fc_office_notification_ids (or company email),
  so it does not silently send with no recipient.
- H5: maintenance reminder cron nextcall now always rolls to tomorrow
  at 07:00 local time, so installing/upgrading after 07:00 does not
  immediately fire all the day's reminders.
- H6: public portal no longer hardcodes UID 1 as the intake user fallback
  (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the
  lowest-id non-share user, else SUPERUSER_ID.
- H7: public portal validates client_email via tools.email_normalize
  before partner creation; malformed addresses redirect with error=email.
- H8: find_best_match() returns empty when no symptom keywords match
  (no silent first-catalog guess) and uses word-boundary regex to avoid
  matching 'battery' inside 'no battery problem'.

Medium
- M1: _inherit moved next to _name on maintenance_contract (cosmetic but
  brittle if Odoo refactors model class detection)
- M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty
  and maintenance intervals (correct month boundaries)
- M3: unique constraint on fusion.repair.maintenance.contract.booking_token
- M6: dispatch task fallback now searches for an actual x_fc_is_field_staff
  user; gracefully skips and logs if no field staff exists (instead of
  silently failing the constraint check)
- M7: maintenance contract list view date decoration uses context_today()
  (date) instead of strftime(string) - the str comparison would TypeError
- M9: Visit Report button hidden on draft repairs and when no technician
  task is linked yet

Low
- L2: portal-created partners get default lang + company_id so mail
  templates render in the right language
- L3: dropped unused exception variable in sales rep portal controller
- L4: visit-report wizard 'found another issue' now redirects to the
  spawned stub repair so the tech can fill it in immediately
- L5: dropped unrecognized data-string from <app> in settings view

Public portal also: rate-limit check moved BEFORE the counter increment so
blocked attempts do not keep inflating the bucket.

All fixes verified end-to-end on local westin-v19:
- variance one-sided: 0.5h labour vs $500 est -> requires_requote=False;
  2h x $250 + $200 parts vs $100 est -> requires_requote=True
- maintenance roll-forward: created MC/00006 due 2026-05-31, completed
  linked maintenance task -> contract rolled to 2026-11-21 with
  last_reminder_band reset
- warranty find_active_for(partner only) -> empty recordset
- service catalog find_best_match with unrelated text -> empty recordset
- pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique
- /repair landing still 200 after restart

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-20 22:22:11 -04:00

160 lines
8.2 KiB
XML

<?xml version="1.0" encoding="utf-8"?>
<odoo>
<!-- ============================================================== -->
<!-- Form view extensions -->
<!-- ============================================================== -->
<record id="view_repair_order_form_inherit_fusion_repairs" model="ir.ui.view">
<field name="name">repair.order.form.inherit.fusion_repairs</field>
<field name="model">repair.order</field>
<field name="inherit_id" ref="repair.view_repair_order_form"/>
<field name="arch" type="xml">
<!-- Header action buttons (visit report + collect payment) -->
<xpath expr="//header" position="inside">
<button name="action_open_visit_report"
type="object"
string="Visit Report"
class="btn-primary"
invisible="state in ('draft', 'cancel') or x_fc_technician_task_count == 0"
groups="fusion_repairs.group_fusion_repairs_user"/>
<button name="action_collect_payment"
type="object"
string="Collect Payment"
class="btn-secondary"
invisible="state != 'done'"
groups="fusion_repairs.group_fusion_repairs_user"/>
</xpath>
<!-- Smart buttons: Technician Tasks + Intake Answers + Original SO. -->
<xpath expr="//div[hasclass('oe_button_box')]" position="inside">
<button name="action_view_technician_tasks"
type="object"
class="oe_stat_button"
icon="fa-wrench"
invisible="x_fc_technician_task_count == 0">
<field name="x_fc_technician_task_count" widget="statinfo" string="Tech Tasks"/>
</button>
<button name="action_view_intake_answers"
type="object"
class="oe_stat_button"
icon="fa-list-alt"
invisible="x_fc_intake_answer_count == 0">
<field name="x_fc_intake_answer_count" widget="statinfo" string="Answers"/>
</button>
<button name="action_view_original_sale_order"
type="object"
class="oe_stat_button"
icon="fa-dollar"
invisible="not x_fc_original_sale_order_id">
<field name="x_fc_original_sale_order_id" widget="statinfo" string="Original SO"/>
</button>
</xpath>
<!-- Add intake metadata under partner_id -->
<xpath expr="//field[@name='partner_id']" position="after">
<field name="x_fc_repair_category_id" options="{'no_create': True}"/>
<field name="x_fc_urgency" widget="badge"
decoration-success="x_fc_urgency == 'normal'"
decoration-warning="x_fc_urgency == 'urgent'"
decoration-danger="x_fc_urgency == 'safety'"/>
<field name="x_fc_third_party_equipment"/>
<field name="x_fc_intake_source" readonly="1"/>
<field name="x_fc_intake_user_id" readonly="1" invisible="not x_fc_intake_user_id"/>
<field name="x_fc_intake_session_id" readonly="1" invisible="not x_fc_intake_session_id"/>
</xpath>
<!-- Add a Fusion Repairs notebook tab with intake + photos. -->
<xpath expr="//notebook" position="inside">
<page string="Intake" name="fusion_intake">
<group>
<group>
<field name="x_fc_intake_template_id" readonly="1"/>
<field name="x_fc_issue_category"/>
</group>
<group>
<field name="x_fc_warranty_override_reason"
placeholder="Reason if warranty status was overridden"/>
<field name="x_fc_estimated_duration" widget="float_time"/>
</group>
</group>
<separator string="Answers"/>
<field name="x_fc_intake_answer_ids" readonly="1">
<list>
<field name="sequence" column_invisible="True"/>
<field name="question_name"/>
<field name="value_display"/>
<field name="question_type" optional="hide"/>
</list>
</field>
<separator string="Photos &amp; Videos"/>
<field name="x_fc_photo_ids" widget="many2many_binary"/>
</page>
<page string="Pricing" name="fusion_pricing" invisible="not x_fc_estimated_cost and not x_fc_actual_cost">
<group>
<group>
<field name="x_fc_estimated_cost" widget="monetary"/>
<field name="x_fc_actual_cost" widget="monetary"/>
</group>
<group>
<field name="x_fc_cost_variance_pct" widget="float" digits="[16,2]"/>
<field name="x_fc_requires_requote"/>
<field name="company_currency_id" invisible="1"/>
</group>
</group>
</page>
<page string="AI Brief" name="fusion_ai" invisible="not x_fc_ai_summary">
<field name="x_fc_ai_summary" readonly="1"/>
</page>
</xpath>
</field>
</record>
<!-- ============================================================== -->
<!-- Kanban: add urgency badge + intake source -->
<!-- ============================================================== -->
<record id="view_repair_order_kanban_inherit_fusion_repairs" model="ir.ui.view">
<field name="name">repair.order.kanban.inherit.fusion_repairs</field>
<field name="model">repair.order</field>
<field name="inherit_id" ref="repair.view_repair_kanban"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='partner_id']" position="after">
<field name="x_fc_urgency"/>
<field name="x_fc_third_party_equipment"/>
</xpath>
</field>
</record>
<!-- ============================================================== -->
<!-- List: add urgency + source columns -->
<!-- ============================================================== -->
<record id="view_repair_order_list_inherit_fusion_repairs" model="ir.ui.view">
<field name="name">repair.order.list.inherit.fusion_repairs</field>
<field name="model">repair.order</field>
<field name="inherit_id" ref="repair.view_repair_order_tree"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='partner_id']" position="after">
<field name="x_fc_urgency" widget="badge"
decoration-success="x_fc_urgency == 'normal'"
decoration-warning="x_fc_urgency == 'urgent'"
decoration-danger="x_fc_urgency == 'safety'"
optional="show"/>
<field name="x_fc_intake_source" optional="hide"/>
<field name="x_fc_third_party_equipment" optional="hide"/>
</xpath>
</field>
</record>
<!-- ============================================================== -->
<!-- New Service Call action - opens the wizard -->
<!-- ============================================================== -->
<record id="action_open_repair_intake_wizard" model="ir.actions.act_window">
<field name="name">New Service Call</field>
<field name="res_model">fusion.repair.intake.wizard</field>
<field name="view_mode">form</field>
<field name="target">new</field>
</record>
</odoo>