Files
Odoo-Modules/fusion_repairs/controllers/portal_sales_rep_repair.py
gsinghpal c86f1bbbe5 fix(fusion_repairs): code-review batch - 4 critical + 8 high + 8 medium/low
Critical
- C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation)
- C2: variance threshold no longer uses abs() - under-cost is good news,
  must not block invoicing. Now only OVER-cost triggers requires_requote.
- C3: roll_next_due_date() was dead code - now wired from
  fusion.technician.task.write() when a maintenance task transitions to
  'completed', so the whole maintenance lifecycle actually advances.
- C4: warranty.is_active was store=True but time-dependent (became stale).
  Dropped store=True; find_active_for() now filters by expiry_date directly.

High
- H1: added x_fc_maintenance_contract_id back-link on repair.order and
  populated it from create_repair_from_booking().
- H2: find_active_for() returns empty when neither lot nor product is
  supplied - prevents cross-product false warranty matches.
- H3: visit-report wizard now creates stock.move records of repair_line_type
  'add' for each part line, so Odoo's native action_create_sale_order()
  chain has lines to invoice and stock gets consumed properly.
- H4: office intake email template now carries a fallback email_to header
  computed from res.company.x_fc_office_notification_ids (or company email),
  so it does not silently send with no recipient.
- H5: maintenance reminder cron nextcall now always rolls to tomorrow
  at 07:00 local time, so installing/upgrading after 07:00 does not
  immediately fire all the day's reminders.
- H6: public portal no longer hardcodes UID 1 as the intake user fallback
  (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the
  lowest-id non-share user, else SUPERUSER_ID.
- H7: public portal validates client_email via tools.email_normalize
  before partner creation; malformed addresses redirect with error=email.
- H8: find_best_match() returns empty when no symptom keywords match
  (no silent first-catalog guess) and uses word-boundary regex to avoid
  matching 'battery' inside 'no battery problem'.

Medium
- M1: _inherit moved next to _name on maintenance_contract (cosmetic but
  brittle if Odoo refactors model class detection)
- M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty
  and maintenance intervals (correct month boundaries)
- M3: unique constraint on fusion.repair.maintenance.contract.booking_token
- M6: dispatch task fallback now searches for an actual x_fc_is_field_staff
  user; gracefully skips and logs if no field staff exists (instead of
  silently failing the constraint check)
- M7: maintenance contract list view date decoration uses context_today()
  (date) instead of strftime(string) - the str comparison would TypeError
- M9: Visit Report button hidden on draft repairs and when no technician
  task is linked yet

Low
- L2: portal-created partners get default lang + company_id so mail
  templates render in the right language
- L3: dropped unused exception variable in sales rep portal controller
- L4: visit-report wizard 'found another issue' now redirects to the
  spawned stub repair so the tech can fill it in immediately
- L5: dropped unrecognized data-string from <app> in settings view

Public portal also: rate-limit check moved BEFORE the counter increment so
blocked attempts do not keep inflating the bucket.

All fixes verified end-to-end on local westin-v19:
- variance one-sided: 0.5h labour vs $500 est -> requires_requote=False;
  2h x $250 + $200 parts vs $100 est -> requires_requote=True
- maintenance roll-forward: created MC/00006 due 2026-05-31, completed
  linked maintenance task -> contract rolled to 2026-11-21 with
  last_reminder_band reset
- warranty find_active_for(partner only) -> empty recordset
- service catalog find_best_match with unrelated text -> empty recordset
- pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique
- /repair landing still 200 after restart

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-20 22:22:11 -04:00

187 lines
7.0 KiB
Python

# -*- coding: utf-8 -*-
# Copyright 2024-2026 Nexa Systems Inc.
# License OPL-1 (Odoo Proprietary License v1.0)
"""Sales rep portal for repair intake.
Sales reps marked `is_sales_rep_portal` on their partner can:
- /my/repair/new - submit a new service call from their phone
- /my/repairs - list of repairs they have submitted
- /my/repair/<id> - read-only detail with status timeline
All routes are gated by the is_sales_rep_portal flag and use the SAME
shared intake service (`fusion.repair.intake.service`) as the backend
wizard - so behaviour stays consistent across surfaces.
"""
import base64
import logging
from odoo import http, fields
from odoo.http import request
from odoo.addons.portal.controllers.portal import CustomerPortal
_logger = logging.getLogger(__name__)
class SalesRepRepairPortal(CustomerPortal):
# ------------------------------------------------------------------
# ACCESS GATE
# ------------------------------------------------------------------
def _check_sales_rep_access(self):
partner = request.env.user.partner_id
if not getattr(partner, 'is_sales_rep_portal', False):
return request.redirect('/my')
return None
def _staged_attachment_ids_from_files(self, files):
"""Stage uploaded files as ir.attachment records and return their IDs."""
ids = []
for f in files or []:
if not getattr(f, 'filename', None):
continue
data = f.read()
if not data:
continue
attachment = request.env['ir.attachment'].sudo().create({
'name': f.filename,
'datas': base64.b64encode(data),
'res_model': 'fusion.repair.intake.session',
'res_id': 0,
})
ids.append(attachment.id)
return ids
# ------------------------------------------------------------------
# NEW SERVICE CALL FORM
# ------------------------------------------------------------------
@http.route('/my/repair/new', type='http', auth='user', website=True, sitemap=False)
def portal_repair_new(self, **kw):
gate = self._check_sales_rep_access()
if gate:
return gate
categories = request.env['fusion.repair.product.category'].sudo().search([
('active', '=', True),
], order='sequence, name')
return request.render('fusion_repairs.portal_sales_rep_repair_form', {
'page_name': 'repair_new',
'categories': categories,
'default_partner': False,
'submitted': False,
})
@http.route('/my/repair/lookup_partner', type='jsonrpc', auth='user', website=True)
def portal_repair_lookup_partner(self, query=None, **kw):
gate = self._check_sales_rep_access()
if gate:
return {'error': 'access'}
if not query or len(query) < 3:
return {'matches': []}
Partner = request.env['res.partner'].sudo()
matches = Partner.search([
'|', '|',
('name', 'ilike', query),
('phone', 'ilike', query),
('email', 'ilike', query),
], limit=8)
return {
'matches': [{
'id': p.id,
'name': p.name or '',
'phone': p.phone or '',
'email': p.email or '',
'street': p.street or '',
'city': p.city or '',
'repair_count': p.x_fc_repair_count,
} for p in matches],
}
@http.route('/my/repair/submit', type='http', auth='user', methods=['POST'],
csrf=True, website=True)
def portal_repair_submit(self, **post):
gate = self._check_sales_rep_access()
if gate:
return gate
partner_id = int(post.get('partner_id') or 0)
if not partner_id:
return request.redirect('/my/repair/new?error=partner')
# Build single-equipment payload from the form. Multi-equipment loop
# is supported by adding more equipment_* groups in Phase 2.
files = request.httprequest.files.getlist('photos')
attachment_ids = self._staged_attachment_ids_from_files(files)
equipment = {
'repair_category_id': int(post.get('category_id') or 0) or False,
'product_id': int(post.get('product_id') or 0) or False,
'third_party': post.get('third_party') in ('on', 'true', '1'),
'urgency': post.get('urgency') or 'normal',
'issue_summary': (post.get('issue_summary') or '').strip(),
'issue_category': (post.get('issue_category') or '').strip(),
'internal_notes': (post.get('internal_notes') or '').strip(),
'photo_attachment_ids': attachment_ids,
}
payload = {
'partner_id': partner_id,
'intake_user_id': request.env.uid,
'equipment_items': [equipment],
}
try:
repairs = request.env['fusion.repair.intake.service'].sudo() \
.create_repair_orders(payload, source='sales_rep_portal')
except Exception:
_logger.exception('Sales rep portal repair submit failed')
return request.redirect('/my/repair/new?error=server')
return request.redirect('/my/repair/%d?thanks=1' % repairs[0].id)
# ------------------------------------------------------------------
# MY REPAIRS LIST + DETAIL
# ------------------------------------------------------------------
@http.route(['/my/repairs', '/my/repairs/page/<int:page>'], type='http',
auth='user', website=True)
def portal_repairs_list(self, page=1, **kw):
gate = self._check_sales_rep_access()
if gate:
return gate
Repair = request.env['repair.order'].sudo()
domain = [('x_fc_intake_user_id', '=', request.env.uid)]
total = Repair.search_count(domain)
page_size = 20
offset = (page - 1) * page_size
repairs = Repair.search(domain, order='create_date desc',
limit=page_size, offset=offset)
return request.render('fusion_repairs.portal_sales_rep_repair_list', {
'page_name': 'repairs_list',
'repairs': repairs,
'total': total,
'page': page,
'page_size': page_size,
})
@http.route('/my/repair/<int:repair_id>', type='http', auth='user',
website=True)
def portal_repair_detail(self, repair_id, thanks=None, **kw):
gate = self._check_sales_rep_access()
if gate:
return gate
repair = request.env['repair.order'].sudo().browse(repair_id).exists()
if not repair or repair.x_fc_intake_user_id.id != request.env.uid:
return request.redirect('/my/repairs')
return request.render('fusion_repairs.portal_sales_rep_repair_detail', {
'page_name': 'repair_detail',
'repair': repair,
'thanks': bool(thanks),
})