Critical - C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation) - C2: variance threshold no longer uses abs() - under-cost is good news, must not block invoicing. Now only OVER-cost triggers requires_requote. - C3: roll_next_due_date() was dead code - now wired from fusion.technician.task.write() when a maintenance task transitions to 'completed', so the whole maintenance lifecycle actually advances. - C4: warranty.is_active was store=True but time-dependent (became stale). Dropped store=True; find_active_for() now filters by expiry_date directly. High - H1: added x_fc_maintenance_contract_id back-link on repair.order and populated it from create_repair_from_booking(). - H2: find_active_for() returns empty when neither lot nor product is supplied - prevents cross-product false warranty matches. - H3: visit-report wizard now creates stock.move records of repair_line_type 'add' for each part line, so Odoo's native action_create_sale_order() chain has lines to invoice and stock gets consumed properly. - H4: office intake email template now carries a fallback email_to header computed from res.company.x_fc_office_notification_ids (or company email), so it does not silently send with no recipient. - H5: maintenance reminder cron nextcall now always rolls to tomorrow at 07:00 local time, so installing/upgrading after 07:00 does not immediately fire all the day's reminders. - H6: public portal no longer hardcodes UID 1 as the intake user fallback (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the lowest-id non-share user, else SUPERUSER_ID. - H7: public portal validates client_email via tools.email_normalize before partner creation; malformed addresses redirect with error=email. - H8: find_best_match() returns empty when no symptom keywords match (no silent first-catalog guess) and uses word-boundary regex to avoid matching 'battery' inside 'no battery problem'. Medium - M1: _inherit moved next to _name on maintenance_contract (cosmetic but brittle if Odoo refactors model class detection) - M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty and maintenance intervals (correct month boundaries) - M3: unique constraint on fusion.repair.maintenance.contract.booking_token - M6: dispatch task fallback now searches for an actual x_fc_is_field_staff user; gracefully skips and logs if no field staff exists (instead of silently failing the constraint check) - M7: maintenance contract list view date decoration uses context_today() (date) instead of strftime(string) - the str comparison would TypeError - M9: Visit Report button hidden on draft repairs and when no technician task is linked yet Low - L2: portal-created partners get default lang + company_id so mail templates render in the right language - L3: dropped unused exception variable in sales rep portal controller - L4: visit-report wizard 'found another issue' now redirects to the spawned stub repair so the tech can fill it in immediately - L5: dropped unrecognized data-string from <app> in settings view Public portal also: rate-limit check moved BEFORE the counter increment so blocked attempts do not keep inflating the bucket. All fixes verified end-to-end on local westin-v19: - variance one-sided: 0.5h labour vs $500 est -> requires_requote=False; 2h x $250 + $200 parts vs $100 est -> requires_requote=True - maintenance roll-forward: created MC/00006 due 2026-05-31, completed linked maintenance task -> contract rolled to 2026-11-21 with last_reminder_band reset - warranty find_active_for(partner only) -> empty recordset - service catalog find_best_match with unrelated text -> empty recordset - pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique - /repair landing still 200 after restart Co-authored-by: Cursor <cursoragent@cursor.com>
152 lines
5.7 KiB
Python
152 lines
5.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2024-2026 Nexa Systems Inc.
|
|
# License OPL-1 (Odoo Proprietary License v1.0)
|
|
|
|
"""Service catalogue.
|
|
|
|
Each fusion.repair.service.catalog record is a named repair / maintenance
|
|
service (e.g. "Stairlift motor replacement", "Bed remote troubleshoot")
|
|
with estimated duration, estimated cost, default parts, and symptom
|
|
keywords used to auto-match an intake to the right catalogue entry.
|
|
|
|
The catalogue feeds:
|
|
- intake auto-match -> sets x_fc_service_catalog_id +
|
|
x_fc_estimated_duration + x_fc_estimated_cost on the repair
|
|
- visit report -> default labour line + parts pre-fill
|
|
- pricing variance -> compares estimate vs actual
|
|
"""
|
|
|
|
from odoo import api, fields, models
|
|
|
|
|
|
class FusionRepairServiceCatalog(models.Model):
|
|
_name = 'fusion.repair.service.catalog'
|
|
_description = 'Repair Service Catalogue Entry'
|
|
_order = 'sequence, name'
|
|
|
|
name = fields.Char(string='Service Name', required=True, translate=True)
|
|
code = fields.Char(string='Code', help='Stable identifier (lowercase, no spaces).')
|
|
sequence = fields.Integer(default=10)
|
|
active = fields.Boolean(default=True)
|
|
company_id = fields.Many2one(
|
|
'res.company', string='Company',
|
|
default=lambda self: self.env.company,
|
|
)
|
|
|
|
# Routing & matching
|
|
product_category_id = fields.Many2one(
|
|
'fusion.repair.product.category',
|
|
string='Equipment Category',
|
|
required=True,
|
|
index=True,
|
|
)
|
|
symptom_keywords = fields.Char(
|
|
string='Symptom Keywords',
|
|
help='Comma-separated keywords used to auto-match an intake to this catalogue entry. '
|
|
'Matched against the issue summary, issue category, and intake answer text.',
|
|
)
|
|
|
|
# Service product (what actually gets invoiced)
|
|
service_product_id = fields.Many2one(
|
|
'product.product',
|
|
string='Service Product',
|
|
domain=[('type', '=', 'service')],
|
|
help='Product line added to the repair sale order for the labour portion.',
|
|
)
|
|
default_parts_product_ids = fields.Many2many(
|
|
'product.product',
|
|
'fusion_repair_catalog_parts_rel',
|
|
'catalog_id', 'product_id',
|
|
string='Default Parts',
|
|
help='Parts typically used. Pre-loaded onto the visit report wizard for the tech to confirm.',
|
|
)
|
|
pricelist_id = fields.Many2one(
|
|
'product.pricelist',
|
|
string='Pricelist Override',
|
|
help='Optional pricelist applied to repair SOs from this catalogue entry. '
|
|
'Leave blank to use the partner default pricelist.',
|
|
)
|
|
|
|
# Estimates
|
|
estimated_hours = fields.Float(
|
|
string='Estimated Labour (h)',
|
|
default=1.0,
|
|
help='Used to size the technician task and the visit report labour default.',
|
|
)
|
|
estimated_cost = fields.Monetary(
|
|
string='Estimated Cost',
|
|
currency_field='company_currency_id',
|
|
help='Headline estimate shown to the client/CS during intake. Phase 1 is a flat number; '
|
|
'Phase 2+ may compute from labour + parts.',
|
|
)
|
|
|
|
# Automation hints
|
|
auto_schedule = fields.Boolean(
|
|
string='Auto-Create Tech Task',
|
|
help='When True, the intake service creates a draft technician task immediately for any '
|
|
'repair matched to this catalogue entry (even at normal urgency).',
|
|
)
|
|
task_type = fields.Selection(
|
|
[('delivery', 'Delivery'), ('repair', 'Repair'), ('pickup', 'Pickup'),
|
|
('troubleshoot', 'Troubleshoot'), ('assessment', 'Assessment'),
|
|
('installation', 'Installation'), ('maintenance', 'Maintenance'),
|
|
('other', 'Other')],
|
|
string='Default Task Type',
|
|
default='repair',
|
|
)
|
|
|
|
company_currency_id = fields.Many2one(
|
|
'res.currency',
|
|
related='company_id.currency_id',
|
|
readonly=True,
|
|
)
|
|
|
|
@api.depends('name', 'code')
|
|
def _compute_display_name(self):
|
|
for c in self:
|
|
c.display_name = c.name or c.code or ''
|
|
|
|
# ------------------------------------------------------------------
|
|
# MATCHING
|
|
# ------------------------------------------------------------------
|
|
@api.model
|
|
def find_best_match(self, product_category_id, text_hints):
|
|
"""Return the best-matching catalogue entry, or empty recordset.
|
|
|
|
Returns empty when no symptom keywords match. We never "guess" a default
|
|
catalog because the match drives estimated cost + auto-dispatch task -
|
|
a wrong guess would propagate into pricing and scheduling.
|
|
|
|
:param product_category_id: int id of the equipment category
|
|
:param text_hints: list[str] - text snippets to look for symptom keywords in
|
|
"""
|
|
import re
|
|
if not product_category_id:
|
|
return self.browse()
|
|
haystack = ' '.join(s.lower() for s in (text_hints or []) if s).strip()
|
|
if not haystack:
|
|
return self.browse()
|
|
candidates = self.search([
|
|
('product_category_id', '=', product_category_id),
|
|
('active', '=', True),
|
|
], order='sequence')
|
|
if not candidates:
|
|
return self.browse()
|
|
best = None
|
|
best_score = 0
|
|
for c in candidates:
|
|
kws = [k.strip().lower() for k in (c.symptom_keywords or '').split(',') if k.strip()]
|
|
# Word-boundary match avoids false positives where "battery" matches
|
|
# inside "no battery problem".
|
|
score = sum(
|
|
1 for kw in kws
|
|
if kw and re.search(rf'\b{re.escape(kw)}\b', haystack)
|
|
)
|
|
if score > best_score:
|
|
best = c
|
|
best_score = score
|
|
# No keywords matched -> return empty rather than the lowest-sequence guess.
|
|
if best and best_score > 0:
|
|
return best
|
|
return self.browse()
|