c86f1bbbe5
Critical - C1: _sql_constraints -> models.Constraint (Odoo 19 deprecation rule violation) - C2: variance threshold no longer uses abs() - under-cost is good news, must not block invoicing. Now only OVER-cost triggers requires_requote. - C3: roll_next_due_date() was dead code - now wired from fusion.technician.task.write() when a maintenance task transitions to 'completed', so the whole maintenance lifecycle actually advances. - C4: warranty.is_active was store=True but time-dependent (became stale). Dropped store=True; find_active_for() now filters by expiry_date directly. High - H1: added x_fc_maintenance_contract_id back-link on repair.order and populated it from create_repair_from_booking(). - H2: find_active_for() returns empty when neither lot nor product is supplied - prevents cross-product false warranty matches. - H3: visit-report wizard now creates stock.move records of repair_line_type 'add' for each part line, so Odoo's native action_create_sale_order() chain has lines to invoice and stock gets consumed properly. - H4: office intake email template now carries a fallback email_to header computed from res.company.x_fc_office_notification_ids (or company email), so it does not silently send with no recipient. - H5: maintenance reminder cron nextcall now always rolls to tomorrow at 07:00 local time, so installing/upgrading after 07:00 does not immediately fire all the day's reminders. - H6: public portal no longer hardcodes UID 1 as the intake user fallback (which in Odoo 19 is OdooBot). Prefers base.user_admin, else the lowest-id non-share user, else SUPERUSER_ID. - H7: public portal validates client_email via tools.email_normalize before partner creation; malformed addresses redirect with error=email. - H8: find_best_match() returns empty when no symptom keywords match (no silent first-catalog guess) and uses word-boundary regex to avoid matching 'battery' inside 'no battery problem'. Medium - M1: _inherit moved next to _name on maintenance_contract (cosmetic but brittle if Odoo refactors model class detection) - M2: relativedelta(months=N) instead of timedelta(days=N*30) for warranty and maintenance intervals (correct month boundaries) - M3: unique constraint on fusion.repair.maintenance.contract.booking_token - M6: dispatch task fallback now searches for an actual x_fc_is_field_staff user; gracefully skips and logs if no field staff exists (instead of silently failing the constraint check) - M7: maintenance contract list view date decoration uses context_today() (date) instead of strftime(string) - the str comparison would TypeError - M9: Visit Report button hidden on draft repairs and when no technician task is linked yet Low - L2: portal-created partners get default lang + company_id so mail templates render in the right language - L3: dropped unused exception variable in sales rep portal controller - L4: visit-report wizard 'found another issue' now redirects to the spawned stub repair so the tech can fill it in immediately - L5: dropped unrecognized data-string from <app> in settings view Public portal also: rate-limit check moved BEFORE the counter increment so blocked attempts do not keep inflating the bucket. All fixes verified end-to-end on local westin-v19: - variance one-sided: 0.5h labour vs $500 est -> requires_requote=False; 2h x $250 + $200 parts vs $100 est -> requires_requote=True - maintenance roll-forward: created MC/00006 due 2026-05-31, completed linked maintenance task -> contract rolled to 2026-11-21 with last_reminder_band reset - warranty find_active_for(partner only) -> empty recordset - service catalog find_best_match with unrelated text -> empty recordset - pg_constraint shows fusion_repair_maintenance_contract_booking_token_unique - /repair landing still 200 after restart Co-authored-by: Cursor <cursoragent@cursor.com>
62 lines
3.8 KiB
XML
62 lines
3.8 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<odoo>
|
|
|
|
<record id="res_config_settings_view_form_inherit_fusion_repairs" model="ir.ui.view">
|
|
<field name="name">res.config.settings.view.form.inherit.fusion_repairs</field>
|
|
<field name="model">res.config.settings</field>
|
|
<field name="inherit_id" ref="base.res_config_settings_view_form"/>
|
|
<field name="arch" type="xml">
|
|
<xpath expr="//form" position="inside">
|
|
<app string="Fusion Repairs"
|
|
name="fusion_repairs"
|
|
groups="fusion_repairs.group_fusion_repairs_manager">
|
|
<block title="Notifications" name="fc_repairs_notifications">
|
|
<setting id="fc_repairs_enable_email_notifications"
|
|
string="Enable Email Notifications"
|
|
help="Master toggle for all automated repair-related emails (intake confirmations, dispatch alerts, office digests).">
|
|
<field name="fc_repairs_enable_email_notifications"/>
|
|
</setting>
|
|
</block>
|
|
<block title="Intake Behaviour" name="fc_repairs_intake">
|
|
<setting id="fc_repairs_duplicate_call_window_days"
|
|
string="Duplicate Call Window (days)"
|
|
help="When an intake matches an open repair from this many days back on the same phone, the wizard offers 'add note instead'.">
|
|
<field name="fc_repairs_duplicate_call_window_days"/>
|
|
</setting>
|
|
<setting id="fc_repairs_outstanding_balance_threshold"
|
|
string="Outstanding Balance Warning ($)"
|
|
help="Show a warning if the client's open invoice total exceeds this amount.">
|
|
<field name="fc_repairs_outstanding_balance_threshold"/>
|
|
</setting>
|
|
</block>
|
|
<block title="Pricing Variance" name="fc_repairs_pricing">
|
|
<setting id="fc_repairs_variance_threshold_pct"
|
|
string="Variance Threshold (%)"
|
|
help="If the actual repair cost exceeds the estimate by more than this percentage, invoicing is blocked until manager review.">
|
|
<field name="fc_repairs_variance_threshold_pct"/>
|
|
</setting>
|
|
<setting id="fc_repairs_variance_threshold_amount"
|
|
string="Variance Threshold ($)"
|
|
help="Absolute variance amount that also triggers re-quote (whichever hits first).">
|
|
<field name="fc_repairs_variance_threshold_amount"/>
|
|
</setting>
|
|
</block>
|
|
<block title="Public Client Portal" name="fc_repairs_client_portal">
|
|
<setting id="fc_repairs_client_portal_url"
|
|
string="Portal URL Path"
|
|
help="URL path mentioned in voicemail greetings and printed on QR stickers. Phase 1 ships the form at this path.">
|
|
<field name="fc_repairs_client_portal_url"/>
|
|
</setting>
|
|
<setting id="fc_repairs_client_portal_rate_limit_per_hour"
|
|
string="Rate Limit (per hour per IP)"
|
|
help="Anti-spam limit for the public form.">
|
|
<field name="fc_repairs_client_portal_rate_limit_per_hour"/>
|
|
</setting>
|
|
</block>
|
|
</app>
|
|
</xpath>
|
|
</field>
|
|
</record>
|
|
|
|
</odoo>
|