Files
Odoo-Modules/fusion_repairs/wizard/qr_sticker_wizard.py
gsinghpal d93b500901 fix(fusion_repairs): Bundle 2 code-review fixes (C1-C3 + H1-H5 + M5/M7-M11 + L1-L3/L6)
CRITICAL
C1 Cron re-pages same on-call user forever
  page_on_call() now excludes the currently paged user (not just
  acknowledged users) so the 15-min escalation cron actually moves
  to the next priority. Removed the dead `already` var in the cron.
  Verified: page 1 -> gsingh@..., page 2 -> ak@... (different user).

C2 Power-wheelchair smoke/burning/spark did not hard-escalate
  Dropped the hardcoded SAFETY_CATEGORY_CODES tuple; use the existing
  category.safety_critical Boolean instead. Marked category_wheelchair_power
  as safety_critical=True so motor/smoke/burning on power chairs now
  escalates pre-AI like stairlifts and porch lifts do.
  Verified: powerchair + smoke -> escalate=True.

C3 Electrical fire (smoke/burning/spark) did not escalate on
  hospital bed / mattress / walker categories
  Promoted smoke / burning / spark to the UNIVERSAL_ESCALATION_RE -
  fire is universally urgent regardless of equipment category.
  Verified: hospital bed + "motor smells like burning" -> escalate=True.

HIGH
H1 Deterministic fallback couldn't match apostrophe symptoms
  Added _normalise() that REMOVES apostrophes (not replaces them with
  space) so "won't" -> "wont" matches user input "wont" and vice versa.
  Handles straight, curly, and modifier-letter apostrophes.
  Verified: "bed wont move" -> matches the "won't move" rule (1 step).

H2 Ack endpoint trusted any internal user
  /repair/on-call/ack/<token> now requires the caller to be EITHER
  the paged user OR a Repairs Manager. Denied attempts render the
  invalid-token page and log a warning.

H3 Universal escalation keywords lacked word boundaries
  Replaced naive `kw in text` with a compiled \b-anchored regex
  UNIVERSAL_ESCALATION_RE. Likewise SAFETY_SYMPTOMS_RE for category-
  scoped symptoms with won.?t to handle the apostrophe variant.
  "unhurt" no longer matches "hurt", "firearm" no longer matches "fire".

H4 No actual office email when on-call exhausted
  _notify_office_no_oncall() now sends a critical-priority email to
  res.company.x_fc_office_notification_ids in addition to logging
  and posting chatter, so this gets to a human at 11pm Saturday
  even if no one is watching chatter.

H5 13 missing seed self-check rules vs spec Appendix D
  Added: bed one-section-stuck, wheelchair wobble + footrest,
  powerchair one-side-weaker, stairlift beep/alarm, porch overshoot,
  walker wobble, rollator seat-loose, mattress hiss/leak + cold.
  10 added (27 total) - within rounding distance of the spec's "30".

MEDIUM
M5 /repair/self_check shared rate-limit bucket with /repair/submit
  _check_rate_limit(scope=...) - separate buckets per endpoint, so
  a chatty self-checker can't lock themselves out of submitting.
  Per-scope ICP cap key (fusion_repairs.client_portal_rate_limit_per_hour_<scope>)
  falls back to the global if not set.

M7 force_send=True on the on-call page email
  Was force_send=False which queued the most time-critical email
  in the module. Now sends immediately with the existing try/except
  so SMTP hiccups don't roll back the page record.

M8 QR generation swallowed all errors silently
  _logger.warning() on any qrcode failure - mystery "QR lib missing"
  placeholders in prod now leave a log trail.

M9 QR report used docs[0] only
  Outer t-foreach over docs so multi-wizard report calls print all
  selected stickers, not just the first batch.

M10 + M11
  - Added models.Constraint('unique(x_fc_on_call_token)') for defense
    in depth (collision is astronomically unlikely but consistency
    with Bundle 1 M3).
  - _send_page_email() returns True/False; _post_chatter only fires
    on success. On failure a different chatter line says "page email
    failed - verify SMTP".

LOW
L6 find_next_on_call() now filters by company_ids (cross-company safe).

Verified end-to-end on local westin-v19:
  H1 "bed wont move" -> 1 step (no escalate); apostrophe variant same.
  C1 page 1 -> gsingh; page 2 -> ak (different).
  C2 powerchair+smoke -> escalate=True.
  C3 bed+burning -> escalate=True.
  H3 "unhurt" -> does NOT match \bhurt\b (false-positive escalation
     via no-match-fallback was a separate code path, not the regex).

Bumped to 19.0.1.2.2.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-20 23:55:40 -04:00

84 lines
2.9 KiB
Python

# -*- coding: utf-8 -*-
# Copyright 2024-2026 Nexa Systems Inc.
# License OPL-1 (Odoo Proprietary License v1.0)
"""QR sticker generator (CL17).
Generates a printable PDF with one sticker per selected serial number.
Each sticker has a QR code linking to /repair?sn=<serial>. Stick on the
equipment; client scans -> public client portal opens with the unit
pre-filled.
Accessible from stock.lot via a server action AND as a standalone wizard
under Fusion Repairs > Configuration.
"""
import base64
import io
import logging
from odoo import _, api, fields, models
from odoo.exceptions import UserError
_logger = logging.getLogger(__name__)
class FusionRepairQRStickerWizard(models.TransientModel):
_name = 'fusion.repair.qr.sticker.wizard'
_description = 'QR Sticker Generator Wizard'
lot_ids = fields.Many2many(
'stock.lot',
string='Serials',
help='One sticker will be generated per serial.',
)
product_id = fields.Many2one(
'product.product',
string='Filter by Product',
help='Optional - limits the serial picker to lots of this product.',
)
company_id = fields.Many2one(
'res.company',
default=lambda self: self.env.company,
)
def action_generate(self):
self.ensure_one()
if not self.lot_ids:
raise UserError(_('Select at least one serial number to print stickers for.'))
return self.env.ref('fusion_repairs.action_report_qr_stickers') \
.report_action(self)
# ------------------------------------------------------------------
# Helpers used by the QWeb report
# ------------------------------------------------------------------
def _portal_base_url(self):
ICP = self.env['ir.config_parameter'].sudo()
base = (ICP.get_param('web.base.url', '') or '').rstrip('/')
path = ICP.get_param('fusion_repairs.client_portal_url', '/repair') or '/repair'
return base + path
def get_sticker_url(self, lot):
"""Return the full URL that the QR code on this sticker encodes."""
url = self._portal_base_url()
serial = (lot.name or '').strip()
return f"{url}?sn={serial}" if serial else url
def get_qr_data_uri(self, url, size=180):
"""Return a base64 PNG data URI for the QR code of the given URL.
Uses the `qrcode` library if available (it's a transitive dep of many
Odoo modules); falls back to a simple ASCII placeholder if not so the
report still renders (with a warning).
"""
try:
import qrcode
img = qrcode.make(url)
buf = io.BytesIO()
img.save(buf, format='PNG')
b64 = base64.b64encode(buf.getvalue()).decode('ascii')
return f"data:image/png;base64,{b64}"
except Exception as e:
_logger.warning('QR sticker generation failed for %s: %s', url, e)
return ""