Full end-to-end walk acting as customer, CS rep, dispatcher, technician,
and manager surfaced 6 real bugs (1 critical state-machine, 4 missing UX
wires, 1 docstring). Server endpoints existed for everything but several
were not wired into the templates.
B1 (HIGH) - Visit-report wizard never closed the repair
Tech submitted visit -> state stayed 'draft' -> x_fc_done_at never
stamped -> NPS cron never fired -> the whole post-visit flow died
silently. Customers never got their NPS email.
Fix: action_confirm() now drives the Odoo native state machine
draft -> action_validate (with _action_repair_confirm fallback) ->
action_repair_start -> action_repair_end. Each step guarded by the
current state and exception-logged. Leaves the repair open if:
- requires_requote=True (variance flag - office must re-quote)
- no_show=True (office reschedules)
- x_fc_is_quote_only (still a quote)
- found_another_issue spawned a stub
Posts a clear chatter line on success or failure.
Verified: e2e walk now shows state=done + x_fc_done_at stamped +
NPS cron fires + flags x_fc_nps_email_sent=True.
B2 (HIGH) - /repair/new form never called /repair/self_check
The AI self-check engine was the headline weekend feature but it was
invisible to the client. The endpoint worked server-side, just had
no frontend.
Fix: new portal_client_repair.js (Interaction class, registered on
registry.category('public.interactions')). 'Try 1-3 safe self-check
steps first' button POSTs to /repair/self_check, renders steps via
createElement + textContent (no innerHTML - all server output is
treated as untrusted text). Shows the AI's safety disclaimer on
every result. On escalate_immediately, shows a clear 'submit the
form, we'll come to you' message instead of the steps.
Verified: HTTP POST returns full JSON with instruction +
expected_result + disclaimer; new button + result panel appear in
rendered HTML.
B3 (HIGH) - No phone-lookup UI for returning clients
Same problem - endpoint existed but no UI. Returning clients had to
retype everything from scratch.
Fix:
- lookup_phone now returns a 'partners' array (id, name, email,
street, city) - cap of 3 results, rate-limited, every match logged
at INFO level for audit. Privacy compromise: a phone holder
deserves to see their own pre-fill; rate limit caps harvesting.
- JS lookup widget at the top of the form posts to /repair/lookup_phone
and pre-fills the 5 contact fields + writes the partner_id to a
hidden #fr_known_partner_id input.
- controller /repair/submit now trusts known_partner_id if present
(skips the phone re-match) so we don't create duplicate partners
when the lookup widget already identified the right one.
Verified: HTTP POST returns the 2 partner records we have for
+19055551234 with full id/name/email/street/city.
B4 (MEDIUM) - /repair?sn=<serial> from QR sticker did nothing
Spec: 'Client scans QR sticker - portal pre-fills the unit info.'
Reality: the form had no serial field; ?sn= was ignored.
Fix: new _resolve_serial_info(serial) on the controller resolves
the lot via stock.lot.search([('name','=',sn)]) and returns
{serial, lot_id, product_id, product_name, category_id}. Both
/repair (landing) and /repair/new pass it as serial_info template
context. Templates show 'Recognized X (Serial: Y)' + auto-select
the matching category in the dropdown. Hidden #fr_serial_number
carries it through to /repair/submit, which attaches the lot_id +
uses the QR category as fallback if user didn't pick one.
Verified: ?sn=stella23-20040164 produces 'Pre-filled from QR scan:'
banner + hidden input populated.
B5 (MEDIUM) - No upsell after submit
Spec required an upsell - 'reduce future calls'. Page was a bare
'Got it'.
Fix: /repair/thanks now shows a 2-card layout:
- 'Want to avoid this next time?' with 4 bullets (priority booking,
free inspection cert, discounted parts, annual reminder) +
'See our maintenance plans' CTA to /shop?category=maintenance
- 'What happens next' 4-step bulleted explanation
Verified: both cards render.
B6 (LOW) - SyntaxWarning '\-->' in repair_service_plan.py
Made the module docstring a raw string (r''') so the ASCII flowchart
arrows don't trigger Python's invalid-escape-sequence warning.
Bumped to 19.0.1.8.0.
Co-authored-by: Cursor <cursoragent@cursor.com>
440 lines
17 KiB
Python
440 lines
17 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2024-2026 Nexa Systems Inc.
|
|
# License OPL-1 (Odoo Proprietary License v1.0)
|
|
|
|
"""Technician visit report wizard.
|
|
|
|
Opened from a completed (or in-progress) repair.order. Captures:
|
|
- labour hours
|
|
- parts/consumables used
|
|
- recommended upsell products
|
|
- optional client signature
|
|
|
|
On confirm:
|
|
- writes labour + parts as repair.order lines (Odoo native operations)
|
|
- updates x_fc_actual_cost on the repair
|
|
- triggers variance reconciliation (sets x_fc_requires_requote if over threshold)
|
|
- if not requote: confirms the repair (state='under_repair' -> 'done' via Odoo native flow)
|
|
- offers an action_collect_payment shortcut to fire Poynt on the resulting invoice
|
|
"""
|
|
|
|
import logging
|
|
|
|
from markupsafe import Markup
|
|
|
|
from odoo import _, api, fields, models
|
|
from odoo.exceptions import UserError
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class RepairVisitReportWizard(models.TransientModel):
|
|
_name = 'fusion.repair.visit.report.wizard'
|
|
_description = 'Repair Visit Report Wizard'
|
|
|
|
repair_id = fields.Many2one(
|
|
'repair.order',
|
|
string='Repair Order',
|
|
required=True,
|
|
readonly=True,
|
|
)
|
|
technician_id = fields.Many2one(
|
|
'res.users',
|
|
string='Technician',
|
|
default=lambda self: self.env.user,
|
|
domain="[('x_fc_is_field_staff', '=', True)]",
|
|
)
|
|
|
|
# Labour
|
|
labour_hours = fields.Float(
|
|
string='Labour Hours',
|
|
required=True,
|
|
default=1.0,
|
|
)
|
|
|
|
# Parts used (simple line model below)
|
|
parts_line_ids = fields.One2many(
|
|
'fusion.repair.visit.report.wizard.line',
|
|
'wizard_id',
|
|
string='Parts Used',
|
|
)
|
|
|
|
# Outcome
|
|
notes = fields.Html(string='Technician Notes')
|
|
found_another_issue = fields.Boolean(
|
|
string='Found Another Issue',
|
|
help='Tick to spawn a follow-up repair after saving this visit.',
|
|
)
|
|
|
|
# M1: tick when the visit was a safety inspection. On save the wizard
|
|
# creates a fusion.repair.inspection.certificate.
|
|
issue_inspection_cert = fields.Boolean(
|
|
string='Issue Compliance Certificate',
|
|
help='Tick when the visit was an annual safety inspection. Creates an '
|
|
'inspection certificate record and prints the PDF on save.',
|
|
)
|
|
inspection_cert_id = fields.Many2one(
|
|
'fusion.repair.inspection.certificate',
|
|
string='Issued Certificate',
|
|
readonly=True,
|
|
)
|
|
|
|
# ----- T4 client signature -----
|
|
client_signature = fields.Binary(
|
|
string='Client Signature',
|
|
attachment=True,
|
|
help='Captured via signature widget on tech mobile - proves the '
|
|
'client accepted the work.',
|
|
)
|
|
client_signature_name = fields.Char(
|
|
string='Signed By',
|
|
help='Type the client name as they signed (for the audit log).',
|
|
)
|
|
|
|
# ----- T7 no-show photo proof -----
|
|
no_show = fields.Boolean(
|
|
string='Client No-Show',
|
|
help='Tick if the client was not present. Forces a no-show photo.',
|
|
)
|
|
no_show_photo = fields.Binary(
|
|
string='No-Show Photo',
|
|
attachment=True,
|
|
help='Photo of the door / driveway proving the technician attended.',
|
|
)
|
|
|
|
# ----- T6 parts replaced - serial capture -----
|
|
parts_serial_capture = fields.Text(
|
|
string='Replaced Parts - Serials',
|
|
help='One serial per line. Used for OEM warranty claims.',
|
|
)
|
|
|
|
# Variance display
|
|
estimated_cost = fields.Monetary(
|
|
related='repair_id.x_fc_estimated_cost',
|
|
currency_field='company_currency_id',
|
|
readonly=True,
|
|
)
|
|
actual_cost = fields.Monetary(
|
|
string='Actual Cost',
|
|
compute='_compute_actual_cost',
|
|
currency_field='company_currency_id',
|
|
)
|
|
variance_pct = fields.Float(
|
|
string='Variance %',
|
|
compute='_compute_actual_cost',
|
|
)
|
|
requires_requote = fields.Boolean(
|
|
compute='_compute_actual_cost',
|
|
)
|
|
|
|
company_currency_id = fields.Many2one(
|
|
'res.currency',
|
|
related='repair_id.company_currency_id',
|
|
readonly=True,
|
|
)
|
|
|
|
@api.depends('labour_hours', 'parts_line_ids.subtotal', 'repair_id.x_fc_estimated_cost')
|
|
def _compute_actual_cost(self):
|
|
ICP = self.env['ir.config_parameter'].sudo()
|
|
try:
|
|
threshold_pct = float(ICP.get_param('fusion_repairs.variance_threshold_pct', '20'))
|
|
except (ValueError, TypeError):
|
|
threshold_pct = 20.0
|
|
try:
|
|
threshold_amt = float(ICP.get_param('fusion_repairs.variance_threshold_amount', '100'))
|
|
except (ValueError, TypeError):
|
|
threshold_amt = 100.0
|
|
|
|
for w in self:
|
|
catalog = w.repair_id.x_fc_service_catalog_id
|
|
labour_rate = 0.0
|
|
if catalog and catalog.service_product_id:
|
|
labour_rate = catalog.service_product_id.list_price
|
|
parts_total = sum(w.parts_line_ids.mapped('subtotal'))
|
|
w.actual_cost = (w.labour_hours * labour_rate) + parts_total
|
|
est = w.estimated_cost or 0.0
|
|
variance_pct = ((w.actual_cost - est) / est * 100) if est else 0.0
|
|
w.variance_pct = variance_pct
|
|
# One-sided: only OVER-cost triggers re-quote. Coming in under
|
|
# estimate is good news and must not block invoicing.
|
|
over_pct = variance_pct
|
|
over_amt = w.actual_cost - est
|
|
w.requires_requote = est > 0 and (
|
|
over_pct >= threshold_pct or over_amt >= threshold_amt
|
|
)
|
|
|
|
# ------------------------------------------------------------------
|
|
# ACTION
|
|
# ------------------------------------------------------------------
|
|
def action_confirm(self):
|
|
self.ensure_one()
|
|
repair = self.repair_id
|
|
if not repair:
|
|
raise UserError(_('No repair selected.'))
|
|
|
|
# Create native repair operations (stock moves) for the parts used.
|
|
# 'add' type moves consume parts from the parts source location and
|
|
# flow through to the invoice when action_create_sale_order() is run.
|
|
self._create_repair_part_moves(repair)
|
|
|
|
# Persist actual cost + requote flag on the repair.
|
|
repair.write({
|
|
'x_fc_actual_cost': self.actual_cost,
|
|
'x_fc_requires_requote': self.requires_requote,
|
|
})
|
|
|
|
# Append technician notes to chatter.
|
|
if self.notes:
|
|
repair.message_post(body=self.notes)
|
|
|
|
# Spawn a follow-up repair if the tech found another issue.
|
|
stub = False
|
|
if self.found_another_issue:
|
|
stub = repair.copy({
|
|
'state': 'draft',
|
|
'internal_notes': _(
|
|
'<p><em>Spawned from visit report on %(ref)s. Add details for the new issue.</em></p>',
|
|
ref=repair.name,
|
|
),
|
|
'x_fc_intake_source': 'manual',
|
|
'x_fc_intake_session_id': repair.x_fc_intake_session_id,
|
|
'x_fc_estimated_cost': 0.0,
|
|
'x_fc_actual_cost': 0.0,
|
|
'x_fc_requires_requote': False,
|
|
'x_fc_intake_template_id': False,
|
|
'x_fc_service_catalog_id': False,
|
|
'x_fc_maintenance_contract_id': False,
|
|
})
|
|
repair.message_post(
|
|
body=Markup(_(
|
|
'Spawned follow-up repair <b>%(name)s</b> for "found another issue".'
|
|
)) % {'name': stub.name or ''},
|
|
)
|
|
|
|
# M1: issue an inspection certificate when the box is ticked
|
|
# AND the equipment is safety-critical (stairlift / porch lift / power chair).
|
|
if self.issue_inspection_cert:
|
|
self._create_inspection_certificate(repair)
|
|
|
|
# T4 / T6 / T7: persist captured artefacts as ir.attachment on the
|
|
# repair so they survive the wizard close.
|
|
self._persist_mobile_artefacts(repair)
|
|
|
|
# M5: burn a pre-paid service plan visit if the client has one and
|
|
# the repair is a maintenance visit. The wizard intentionally does NOT
|
|
# zero out the client's invoice line - the office still posts the
|
|
# invoice; the burn is informational + the office reconciles credits
|
|
# in their accounting flow.
|
|
if not repair.x_fc_is_quote_only:
|
|
self._burn_service_plan_visit(repair)
|
|
|
|
# BUG-B1 fix: actually close the repair so the whole downstream chain
|
|
# (NPS cron, dashboard "done this month" stats, customer survey) fires.
|
|
# Leave open if requote needed - the office will re-quote and the tech
|
|
# will revisit. No-show or quote-only also stays open.
|
|
if (not self.requires_requote
|
|
and not self.no_show
|
|
and not repair.x_fc_is_quote_only
|
|
and not stub):
|
|
self._close_repair(repair)
|
|
elif self.no_show:
|
|
# No-show: drop back to draft for re-scheduling.
|
|
repair.message_post(body=Markup(_(
|
|
'Repair kept <b>open</b> due to no-show. Office to reschedule.'
|
|
)))
|
|
elif self.requires_requote:
|
|
repair.message_post(body=Markup(_(
|
|
'Repair kept <b>open</b> pending re-quote (variance flag).'
|
|
)))
|
|
|
|
# If a stub was spawned, open it directly so the tech can fill in details.
|
|
# Otherwise, if a certificate was issued, jump to it so the tech can print.
|
|
if stub:
|
|
return {
|
|
'type': 'ir.actions.act_window',
|
|
'name': stub.name,
|
|
'res_model': 'repair.order',
|
|
'view_mode': 'form',
|
|
'res_id': stub.id,
|
|
}
|
|
if self.inspection_cert_id:
|
|
return {
|
|
'type': 'ir.actions.act_window',
|
|
'name': self.inspection_cert_id.name,
|
|
'res_model': 'fusion.repair.inspection.certificate',
|
|
'view_mode': 'form',
|
|
'res_id': self.inspection_cert_id.id,
|
|
}
|
|
return {
|
|
'type': 'ir.actions.act_window',
|
|
'name': repair.name,
|
|
'res_model': 'repair.order',
|
|
'view_mode': 'form',
|
|
'res_id': repair.id,
|
|
}
|
|
|
|
def _persist_mobile_artefacts(self, repair):
|
|
"""T4/T6/T7: attach signature image, no-show photo, and serial list
|
|
to the repair so they survive after the transient wizard closes."""
|
|
Attachment = self.env['ir.attachment'].sudo()
|
|
if self.client_signature:
|
|
Attachment.create({
|
|
'name': f'signature-{repair.name}.png',
|
|
'datas': self.client_signature,
|
|
'res_model': 'repair.order',
|
|
'res_id': repair.id,
|
|
'mimetype': 'image/png',
|
|
})
|
|
who = self.client_signature_name or repair.partner_id.name or ''
|
|
repair.message_post(body=Markup(_(
|
|
'Client signature captured (<b>%s</b>).'
|
|
)) % who)
|
|
if self.no_show:
|
|
if self.no_show_photo:
|
|
Attachment.create({
|
|
'name': f'no-show-{repair.name}.jpg',
|
|
'datas': self.no_show_photo,
|
|
'res_model': 'repair.order',
|
|
'res_id': repair.id,
|
|
'mimetype': 'image/jpeg',
|
|
})
|
|
repair.message_post(body=Markup(_(
|
|
'Visit recorded as <b>client no-show</b>%s.'
|
|
)) % (' (photo attached)' if self.no_show_photo else ''))
|
|
if self.parts_serial_capture and self.parts_serial_capture.strip():
|
|
repair.message_post(body=Markup(_(
|
|
'Replaced part serials captured:<br/><pre>%s</pre>'
|
|
)) % self.parts_serial_capture.strip())
|
|
|
|
def _close_repair(self, repair):
|
|
"""Drive the Odoo native state machine from draft -> done.
|
|
|
|
Odoo 19 sequence: draft -> action_validate (confirmed/under_repair)
|
|
-> action_repair_start (under_repair) -> action_repair_end (done).
|
|
Calls are guarded - silently re-runs only the missing steps.
|
|
"""
|
|
try:
|
|
if repair.state == 'draft':
|
|
# action_validate is the standard entry path; if the product is
|
|
# storable it expects reservations etc., so fall back to the
|
|
# simpler _action_repair_confirm() helper if validate refuses.
|
|
try:
|
|
repair.action_validate()
|
|
except Exception as e:
|
|
_logger.info(
|
|
'action_validate skipped for %s: %s; using internal confirm.',
|
|
repair.name, e,
|
|
)
|
|
repair._action_repair_confirm()
|
|
if repair.state == 'confirmed':
|
|
repair.action_repair_start()
|
|
if repair.state == 'under_repair':
|
|
repair.action_repair_end()
|
|
repair.message_post(body=Markup(_(
|
|
'Visit report submitted - repair closed by <b>%s</b>.'
|
|
)) % (self.technician_id.name or self.env.user.name))
|
|
except Exception as e:
|
|
_logger.exception(
|
|
'Visit report could not close repair %s automatically: %s',
|
|
repair.name, e,
|
|
)
|
|
repair.message_post(body=Markup(_(
|
|
'<b>Could not auto-close repair</b>: %s. Office must close manually.'
|
|
)) % str(e))
|
|
|
|
def _burn_service_plan_visit(self, repair):
|
|
"""M5: deduct one visit from the most-recently-active service plan
|
|
covering this repair. Quietly no-ops if the client has no plan."""
|
|
Plan = self.env['fusion.repair.service.plan.subscription'].sudo()
|
|
sub = Plan.find_for_repair(repair)
|
|
if sub:
|
|
sub.burn_visit(repair)
|
|
|
|
def _create_inspection_certificate(self, repair):
|
|
"""M1: create the inspection certificate. Requires a safety-critical
|
|
equipment category - otherwise just logs to chatter and skips."""
|
|
category = repair.x_fc_repair_category_id
|
|
if not category or not category.safety_critical:
|
|
repair.message_post(body=_(
|
|
'Inspection certificate skipped - equipment category is not '
|
|
'flagged as safety_critical. Only stairlifts, porch lifts, '
|
|
'and power wheelchairs receive annual certificates.'
|
|
))
|
|
return
|
|
if not repair.product_id:
|
|
repair.message_post(body=_(
|
|
'Inspection certificate skipped - the repair has no product set.'
|
|
))
|
|
return
|
|
Cert = self.env['fusion.repair.inspection.certificate'].sudo()
|
|
cert = Cert.create({
|
|
'partner_id': repair.partner_id.id,
|
|
'product_id': repair.product_id.id,
|
|
'lot_id': repair.lot_id.id if repair.lot_id else False,
|
|
'repair_order_id': repair.id,
|
|
'inspector_user_id': self.technician_id.id or self.env.uid,
|
|
})
|
|
self.inspection_cert_id = cert
|
|
repair.message_post(body=_(
|
|
'Issued inspection certificate %s (expires %s).'
|
|
) % (cert.name, cert.expiry_date))
|
|
|
|
def _create_repair_part_moves(self, repair):
|
|
"""Create stock.move records for each part used (repair_line_type='add').
|
|
|
|
Locations follow the repair order's configured source / parts locations;
|
|
Odoo natively links these moves to the SO line generated by
|
|
action_create_sale_order() so they invoice correctly.
|
|
"""
|
|
Move = self.env['stock.move'].sudo()
|
|
for line in self.parts_line_ids:
|
|
if not line.product_id or line.quantity <= 0:
|
|
continue
|
|
vals = {
|
|
'name': line.product_id.display_name,
|
|
'product_id': line.product_id.id,
|
|
'product_uom_qty': line.quantity,
|
|
'product_uom': line.product_id.uom_id.id,
|
|
'repair_id': repair.id,
|
|
'repair_line_type': 'add',
|
|
'location_id': repair.location_id.id,
|
|
'location_dest_id': repair.parts_location_id.id or repair.location_id.id,
|
|
'company_id': repair.company_id.id,
|
|
}
|
|
try:
|
|
Move.create(vals)
|
|
except Exception as e:
|
|
_logger.warning(
|
|
'Could not create repair part move on %s for %s: %s',
|
|
repair.name, line.product_id.display_name, e,
|
|
)
|
|
|
|
|
|
class RepairVisitReportWizardLine(models.TransientModel):
|
|
_name = 'fusion.repair.visit.report.wizard.line'
|
|
_description = 'Repair Visit Report Wizard - Part Line'
|
|
|
|
wizard_id = fields.Many2one(
|
|
'fusion.repair.visit.report.wizard',
|
|
required=True,
|
|
ondelete='cascade',
|
|
)
|
|
product_id = fields.Many2one(
|
|
'product.product',
|
|
string='Part',
|
|
required=True,
|
|
)
|
|
quantity = fields.Float(default=1.0, required=True)
|
|
unit_price = fields.Float(string='Unit Price')
|
|
subtotal = fields.Float(compute='_compute_subtotal', store=True)
|
|
|
|
@api.onchange('product_id')
|
|
def _onchange_product_id(self):
|
|
if self.product_id:
|
|
self.unit_price = self.product_id.list_price
|
|
|
|
@api.depends('quantity', 'unit_price')
|
|
def _compute_subtotal(self):
|
|
for line in self:
|
|
line.subtotal = line.quantity * line.unit_price
|