Files
Odoo-Modules/fusion_plating/fusion_plating_jobs
gsinghpal 89dd77aff2 fix(jobs): workflow bar stuck at Draft for confirmed/done jobs
Root cause: two compounding bugs in fp.job.workflow_state_id.
  - The "Confirmed" state seed has no trigger fields set, so it
    never passes _fp_is_passed_for_job.
  - The _compute_workflow_state_id loop breaks on the first
    non-passed state — so when Confirmed fails, every later
    state stays unevaluated and the bar is stuck at Draft.

Fixes:
  - Add trigger_on_job_state Selection field on fp.job.workflow.state
    with values confirmed/in_progress/done. Passes when fp.job.state
    >= the chosen value ("at least" semantics with explicit ordering
    that treats on_hold==in_progress and cancelled outside the
    progression). Lets workflow states key off the job's own state
    when recipe default_kind tagging isn't present.
  - Extend _fp_is_passed_for_job with the new branch.
  - Change _compute_workflow_state_id from first-non-pass-breaks to
    highest-passed-wins. Untagged/not-applicable states no longer
    block the cascade — the bar shows the furthest milestone the
    job has actually reached.
  - Seed update (DB-side, since data is noupdate=1): Confirmed now
    has trigger_on_job_state='confirmed'.

Result: Work Order # 00011 (state=confirmed, all 11 steps done/
skipped) now correctly shows the bar at "Done" instead of "Draft"
(via the existing trigger_all_steps_done on Done). Mid-flight
confirmed jobs without recipe tagging will show at least
"Confirmed" now.

Recipe authoring note (out of scope here): for accurate Received /
In Progress / Inspected intermediate states, recipe nodes still need
default_kind tagging (receiving / wet|bake|mask|rack / final_inspect).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 00:05:05 -04:00
..
2026-04-26 10:46:44 -04:00
2026-05-10 10:25:12 -04:00
2026-04-26 15:05:17 -04:00
2026-04-29 03:35:33 -04:00
2026-05-10 10:25:12 -04:00
2026-05-10 10:25:12 -04:00
2026-04-28 19:39:37 -04:00

fusion_plating_jobs

Native plating job bridge — wires fp.job and fp.job.step (defined in fusion_plating core, Phase 1 of the migration spec dated 2026-04-25) into the rest of the Fusion Plating module family: configurator, portal, logistics, quality, certificates, batches, KPI, notifications, reports.

Coexists with fusion_plating_bridge_mrp during the migration period. The x_fc_use_native_jobs settings flag (default: False) toggles the behaviour. When False, SO confirm continues to create mrp.production records through bridge_mrp. When True, SO confirm creates fp.job records here.

See docs/superpowers/specs/2026-04-25-fp-native-job-model-design.md for full design rationale and §6 of the implementation plan for phase breakdown.

Phase 6 — deferred items

Phase 6 originally scoped the full operator UI rewrite. With Tailscale SSH to entech currently unavailable we cannot live-test OWL/JS in the browser, so Phase 6 ships a lean version: the data-layer endpoints land now, the rendering UI lands later.

Deferred to post-cutover hardening:

  • Plant Overview kanban over fp.job.step — replaces fusion_plating_shopfloor's mrp.workorder kanban.
  • Tablet Station UI rewrite over fp.job / fp.job.step.
  • Manager Dashboard rewrite.
  • Process Tree OWL component — currently a stub: /fp/jobs/process_tree returns the serialized recipe tree as JSON, but the OWL component to render it is not built.

Rationale: these are large OWL/JS components that need live in-browser verification on entech. Under the migration's parallel-coexistence strategy, operators continue using the existing shopfloor UI (bound to mrp.workorder) until cutover. After cutover, the operator UI rewrite becomes its own focused project — the data layer (fp.job, fp.job.step, time logs, timestamps) is fully in place from Phase 15.

Phase 6 — what shipped

  • /fp/job/<id> — scan-redirect controller. The fp.job sticker QR encodes this URL. Routes managers to the fp.job form; routes operators to the same form for now (will swap to the process tree client action once the OWL component lands).
  • /fp/jobs/process_tree — JSON-RPC endpoint that returns the recipe tree for a job, with each node tagged by its matching fp.job.step state, ready for an OWL component to consume.