Bug review fixes (found by code review + live QWeb error):
- report_fp_sale.xml: product_uom → product_uom_id (Odoo 19 renamed;
was raising KeyError during PDF render, blocking all sale-order prints)
- mrp_production.button_mark_done: add idempotency guard on delivery
auto-create (was duplicating on every re-close)
- fp.certificate._compute_batch_ids: use empty recordset instead of
False for Many2many computed fields
- fp_notification_template._collect_attachments: collapse attach_quotation
+ attach_sale_order into a single render so email doesn't double-attach
the same PDF
- fp.operator.certification: SQL unique on computed state was unreliable;
added explicit `revoked` boolean, made state pure-compute, replaced
SQL constraint with @api.constrains that checks active-only uniqueness;
has_active_cert now reads revoked + expires_date directly (no stale
stored state between nightly recomputes)
Two missing invoice strategies implemented + 1 pre-existing deposit bug fix:
- Progress Billing: new x_fc_progress_initial_percent field on sale.order;
_create_progress_initial_invoice bills the configured % on SO confirm
via down-payment wizard, _create_final_balance_invoice bills the
remainder on delivery
- Net Terms: no invoice on confirm; full invoice auto-created when
fusion.plating.delivery.action_mark_delivered fires
- Fix for deposit (pre-existing, silent): sale.advance.payment.inv
reads active_ids at wizard-create time, not on create_invoices();
context was being set on the wrong call, so every deposit attempt
raised "Expected singleton" and message-posted to chatter instead
of actually invoicing
- New fusion_plating_invoicing/models/fp_delivery.py hooks
action_mark_delivered to dispatch final invoice for progress/net_terms
- fp.direct.order.wizard + SO form surface the progress_initial_percent
field (conditional on strategy)
Report styling cleanup:
- Hide DISCOUNT column from sale + invoice landscape reports unless at
least one line has a non-zero discount; colspan auto-adjusts
- Replace hardcoded #0066a1 in all reports with company.primary_color
driven by doc.company_id → company → user.company_id fallback chain,
with #1d1f1e as ultimate fallback; new .fp-header-primary class
exposes the colour for inline section headers (CARGO DESCRIPTION,
PAYMENT DETAILS, OPERATOR SIGN-OFF, etc.) so they retint with the
company theme without template edits
Certificate of Conformance — formal ENTECH-style rebuild:
- New res.company fields: x_fc_owner_user_id (default signer, sig from
hr.employee.signature), x_fc_coc_signature_override (manual upload),
x_fc_{nadcap,as9100,cgp}_logo + _active toggles for accreditation
badges
- New res.config.settings section "Fusion Plating" exposing the above
as configurable blocks; manager-only menu under Configuration →
Fusion Plating Settings
- New fp.certificate fields: nc_quantity, customer_job_no,
contact_partner_id (child contact for Name / Email / Phone block)
- New report_coc_en + report_coc_fr templates (primary): custom header
(company contact | accreditations | company logo), bilingual labels
per variant, customer info block with customer logo, 3-column cert
info table, 6-column line-item table (Part # | Process | Customer
PO | Shipped | NC Qty | Customer Job No.), signature image + bordered
certification statement, footer "Fusion Plating by Nexa Systems"
- Legacy report_coc + report_coc_portrait kept for existing portal-job
bindings (no behaviour change)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
183 lines
7.4 KiB
Python
183 lines
7.4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2026 Nexa Systems Inc.
|
|
# License OPL-1 (Odoo Proprietary License v1.0)
|
|
# Part of the Fusion Plating product family.
|
|
|
|
import logging
|
|
|
|
from odoo import api, fields, models, _
|
|
from odoo.exceptions import UserError
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class SaleOrder(models.Model):
|
|
_inherit = 'sale.order'
|
|
|
|
@api.onchange('partner_id')
|
|
def _onchange_partner_id_invoice_strategy(self):
|
|
"""Auto-fill invoice strategy from customer defaults."""
|
|
if self.partner_id:
|
|
default = self.env['fp.invoice.strategy.default'].search(
|
|
[('partner_id', '=', self.partner_id.id)], limit=1,
|
|
)
|
|
if default:
|
|
self.x_fc_invoice_strategy = default.default_strategy
|
|
self.x_fc_deposit_percent = default.default_deposit_percent
|
|
if default.payment_term_id:
|
|
self.payment_term_id = default.payment_term_id
|
|
|
|
def action_confirm(self):
|
|
"""Override to check account hold and trigger invoice strategy."""
|
|
for order in self:
|
|
# --- Account hold check ---
|
|
if order.partner_id.x_fc_account_hold:
|
|
is_manager = self.env.user.has_group(
|
|
'fusion_plating.group_fusion_plating_manager'
|
|
)
|
|
if not is_manager:
|
|
raise UserError(_(
|
|
'Cannot confirm — customer "%s" is on account hold.\n'
|
|
'Reason: %s\n\n'
|
|
'Contact a manager to override.'
|
|
) % (order.partner_id.name,
|
|
order.partner_id.x_fc_account_hold_reason or 'No reason specified'))
|
|
else:
|
|
order.message_post(
|
|
body=_(
|
|
'Warning: Customer "%s" is on account hold (reason: %s). '
|
|
'Order confirmed by manager override.'
|
|
) % (order.partner_id.name,
|
|
order.partner_id.x_fc_account_hold_reason or 'N/A'),
|
|
)
|
|
|
|
res = super().action_confirm()
|
|
|
|
# --- Invoice strategy automation (on confirm) ---
|
|
for order in self:
|
|
strategy = order.x_fc_invoice_strategy
|
|
if not strategy:
|
|
continue
|
|
if strategy == 'deposit' and order.x_fc_deposit_percent:
|
|
order._create_deposit_invoice()
|
|
elif strategy == 'cod_prepay':
|
|
order._create_full_invoice()
|
|
elif strategy == 'progress' and order.x_fc_progress_initial_percent:
|
|
order._create_progress_initial_invoice()
|
|
# 'net_terms' — no action on confirm; invoiced when delivery is marked delivered
|
|
|
|
return res
|
|
|
|
# ------------------------------------------------------------------
|
|
# Strategy implementations
|
|
# ------------------------------------------------------------------
|
|
def _create_deposit_invoice(self):
|
|
"""Deposit strategy: down-payment invoice for the deposit %."""
|
|
self.ensure_one()
|
|
percent = self.x_fc_deposit_percent
|
|
if not percent or percent <= 0:
|
|
return
|
|
try:
|
|
# The wizard's sale_order_ids default reads active_ids AT CREATE
|
|
# time — context must be set on .with_context(), not on the
|
|
# subsequent create_invoices() call.
|
|
wizard = self.env['sale.advance.payment.inv'].with_context(
|
|
active_ids=self.ids,
|
|
active_model='sale.order',
|
|
active_id=self.id,
|
|
).create({
|
|
'advance_payment_method': 'percentage',
|
|
'amount': percent,
|
|
})
|
|
wizard.create_invoices()
|
|
self.message_post(
|
|
body=_('Deposit invoice (%.0f%%) created — strategy: Deposit.') % percent,
|
|
)
|
|
except Exception as e:
|
|
_logger.warning('Failed to create deposit invoice for SO %s: %s', self.name, e)
|
|
self.message_post(
|
|
body=_('Failed to auto-create deposit invoice: %s. Create manually.') % str(e),
|
|
)
|
|
|
|
def _create_full_invoice(self):
|
|
"""COD / Prepay: invoice the entire order immediately."""
|
|
self.ensure_one()
|
|
try:
|
|
invoices = self._create_invoices()
|
|
if invoices:
|
|
self.message_post(
|
|
body=_('Full invoice created — strategy: COD / Prepay.'),
|
|
)
|
|
except Exception as e:
|
|
_logger.warning('Failed to create COD invoice for SO %s: %s', self.name, e)
|
|
self.message_post(
|
|
body=_('Failed to auto-create invoice: %s. Create manually.') % str(e),
|
|
)
|
|
|
|
def _create_progress_initial_invoice(self):
|
|
"""Progress Billing — first invoice at SO confirm.
|
|
|
|
Uses Odoo's down-payment mechanism to bill the initial percentage.
|
|
The remainder is billed on delivery via `_create_final_balance_invoice`.
|
|
"""
|
|
self.ensure_one()
|
|
percent = self.x_fc_progress_initial_percent
|
|
if not percent or percent <= 0:
|
|
return
|
|
try:
|
|
wizard = self.env['sale.advance.payment.inv'].with_context(
|
|
active_ids=self.ids,
|
|
active_model='sale.order',
|
|
active_id=self.id,
|
|
).create({
|
|
'advance_payment_method': 'percentage',
|
|
'amount': percent,
|
|
})
|
|
wizard.create_invoices()
|
|
self.message_post(
|
|
body=_(
|
|
'Progress invoice — initial %.0f%% created — strategy: Progress Billing. '
|
|
'Final balance will be invoiced on delivery.'
|
|
) % percent,
|
|
)
|
|
except Exception as e:
|
|
_logger.warning('Failed progress-initial invoice for SO %s: %s', self.name, e)
|
|
self.message_post(
|
|
body=_('Failed to auto-create progress invoice: %s') % str(e),
|
|
)
|
|
|
|
def _create_final_balance_invoice(self):
|
|
"""Create the closing invoice for Progress Billing / Net Terms.
|
|
|
|
Called when delivery is marked delivered. Uses the standard
|
|
`_create_invoices()` method which bills the remainder (net of any
|
|
previously-posted down payments).
|
|
"""
|
|
self.ensure_one()
|
|
if self.x_fc_final_invoice_id:
|
|
return self.x_fc_final_invoice_id # Already invoiced — don't double
|
|
if self.invoice_status == 'invoiced':
|
|
return False # Nothing more to bill
|
|
try:
|
|
invoices = self._create_invoices(final=True)
|
|
if invoices:
|
|
self.x_fc_final_invoice_id = invoices[:1].id
|
|
strategy_label = dict(
|
|
self._fields['x_fc_invoice_strategy'].selection
|
|
).get(self.x_fc_invoice_strategy, self.x_fc_invoice_strategy)
|
|
self.message_post(
|
|
body=_(
|
|
'Final invoice created on delivery — strategy: %s.'
|
|
) % strategy_label,
|
|
)
|
|
return invoices
|
|
except Exception as e:
|
|
_logger.warning('Failed final invoice for SO %s: %s', self.name, e)
|
|
self.message_post(
|
|
body=_(
|
|
'Failed to auto-create final invoice: %s. '
|
|
'Create manually from the SO.'
|
|
) % str(e),
|
|
)
|
|
return False
|