0047f49d2c
Pre-deploy fixes for Phase 1 permissions overhaul branch (catches by
final-reviewer subagent + main session).
CRITICAL FIXES:
C1: groups_id -> group_ids (Odoo 19 field rename). Affected ~30 sites
across 4 model files, 1 view, 7 test files. Documented project
gotcha (feedback_odoo19_groups_id_renamed.md) that the implementer
subagents missed because they don't see user memory.
C2: action_fp_resolve_plating_landing server action now calls
env['ir.actions.act_window'].sudo()._fp_resolve_landing_for_current_user()
instead of the old inline priority chain. Phase E's role-based
dispatch was previously dead code.
C3: New migrations/19.0.21.1.0/post-migrate.py triggers
_fp_post_init_role_migration(env) on -u. post_init_hook only fires
on INSTALL in Odoo 19, not UPGRADE -- so Phase H's preview creation
wouldn't have auto-fired on entech without this script. Module
version bumped to 19.0.21.1.0 to match the migration directory.
C4: Team kanban template rewritten for Odoo 19 (<t t-name='card'> with
semantic <aside>/<main>) instead of legacy <t t-name='kanban-box'>.
Previous template threw 'Missing card template' at render.
IMPORTANT FIXES:
I1: SO state=sent Confirm button (id='action_confirm') now also gated
to group_fp_sales_manager. Previously only the state=draft button
was gated; Sales Reps could send-and-confirm via the secondary path.
I2: Designated Officials picker domain uses all_group_ids (transitive)
instead of group_ids (explicit only). Owner users now correctly
appear as eligible CGP DO candidates via the implied_ids chain.
I3: test_menu_visibility.py compliance hub xmlid corrected to
fusion_plating.menu_fp_compliance_hub (was
fusion_plating_compliance.menu_fp_compliance_hub which doesn't exist
-- the hub menu is defined in core's fp_menu.xml). Tests were
silently skipTest-ing.
I4: _inverse_plating_role chatter audit reads old role from DB via SQL
(bypasses cache) so 'old -> new' displays actual values, and
short-circuits no-op writes.
I5: _FP_ROLE_MAPPING_RULES reordered: cgp_designated_official fires
BEFORE admin/uid_1_or_2 so admin+DO users keep the capability_delta
marker that triggers res.company.x_fc_cgp_designated_official_id
auto-set during migration.
I6: _cron_purge_expired_migrations skips groups with active users
instead of unlink-ing unconditionally. Defense against rollback
safety being bypassed by manual role assignments post-migration.
CLAUDE.md updated with 3 new durable rules (13b kanban card template,
13c group_ids vs all_group_ids, 13d post_init_hook only on install).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
47 lines
1.9 KiB
Python
47 lines
1.9 KiB
Python
from odoo.tests.common import TransactionCase, tagged
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
@tagged('-at_install', 'post_install', 'fp_perms')
|
|
class TestSalesManagerGate(TransactionCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
Users = self.env['res.users'].with_context(no_reset_password=True)
|
|
self.u_sr = Users.create({
|
|
'login': 'gate_sr', 'name': 'Gate SR',
|
|
'email': 'gate_sr@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_sales_rep').id])],
|
|
})
|
|
self.u_smg = Users.create({
|
|
'login': 'gate_smg', 'name': 'Gate SMg',
|
|
'email': 'gate_smg@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_sales_manager').id])],
|
|
})
|
|
partner = self.env['res.partner'].create({'name': 'Gate Test Customer'})
|
|
product = self.env['product.product'].create({'name': 'Gate Test Product'})
|
|
self.so = self.env['sale.order'].create({
|
|
'partner_id': partner.id,
|
|
'order_line': [(0, 0, {
|
|
'product_id': product.id, 'product_uom_qty': 1, 'price_unit': 100,
|
|
})],
|
|
})
|
|
|
|
def test_sales_rep_cannot_confirm(self):
|
|
with self.assertRaises(UserError):
|
|
self.so.with_user(self.u_sr).action_confirm()
|
|
|
|
def test_sales_manager_can_confirm(self):
|
|
self.so.with_user(self.u_smg).action_confirm()
|
|
self.assertEqual(self.so.state, 'sale')
|
|
|
|
def test_manager_can_confirm(self):
|
|
# Manager implies Sales Manager via the diamond — should also be able to confirm
|
|
u_mgr = self.env['res.users'].with_context(no_reset_password=True).create({
|
|
'login': 'gate_mgr', 'name': 'Gate Mgr',
|
|
'email': 'gate_mgr@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_manager').id])],
|
|
})
|
|
self.so.with_user(u_mgr).action_confirm()
|
|
self.assertEqual(self.so.state, 'sale')
|