0047f49d2c
Pre-deploy fixes for Phase 1 permissions overhaul branch (catches by
final-reviewer subagent + main session).
CRITICAL FIXES:
C1: groups_id -> group_ids (Odoo 19 field rename). Affected ~30 sites
across 4 model files, 1 view, 7 test files. Documented project
gotcha (feedback_odoo19_groups_id_renamed.md) that the implementer
subagents missed because they don't see user memory.
C2: action_fp_resolve_plating_landing server action now calls
env['ir.actions.act_window'].sudo()._fp_resolve_landing_for_current_user()
instead of the old inline priority chain. Phase E's role-based
dispatch was previously dead code.
C3: New migrations/19.0.21.1.0/post-migrate.py triggers
_fp_post_init_role_migration(env) on -u. post_init_hook only fires
on INSTALL in Odoo 19, not UPGRADE -- so Phase H's preview creation
wouldn't have auto-fired on entech without this script. Module
version bumped to 19.0.21.1.0 to match the migration directory.
C4: Team kanban template rewritten for Odoo 19 (<t t-name='card'> with
semantic <aside>/<main>) instead of legacy <t t-name='kanban-box'>.
Previous template threw 'Missing card template' at render.
IMPORTANT FIXES:
I1: SO state=sent Confirm button (id='action_confirm') now also gated
to group_fp_sales_manager. Previously only the state=draft button
was gated; Sales Reps could send-and-confirm via the secondary path.
I2: Designated Officials picker domain uses all_group_ids (transitive)
instead of group_ids (explicit only). Owner users now correctly
appear as eligible CGP DO candidates via the implied_ids chain.
I3: test_menu_visibility.py compliance hub xmlid corrected to
fusion_plating.menu_fp_compliance_hub (was
fusion_plating_compliance.menu_fp_compliance_hub which doesn't exist
-- the hub menu is defined in core's fp_menu.xml). Tests were
silently skipTest-ing.
I4: _inverse_plating_role chatter audit reads old role from DB via SQL
(bypasses cache) so 'old -> new' displays actual values, and
short-circuits no-op writes.
I5: _FP_ROLE_MAPPING_RULES reordered: cgp_designated_official fires
BEFORE admin/uid_1_or_2 so admin+DO users keep the capability_delta
marker that triggers res.company.x_fc_cgp_designated_official_id
auto-set during migration.
I6: _cron_purge_expired_migrations skips groups with active users
instead of unlink-ing unconditionally. Defense against rollback
safety being bypassed by manual role assignments post-migration.
CLAUDE.md updated with 3 new durable rules (13b kanban card template,
13c group_ids vs all_group_ids, 13d post_init_hook only on install).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
105 lines
5.2 KiB
Python
105 lines
5.2 KiB
Python
from odoo.tests.common import TransactionCase, tagged
|
|
|
|
|
|
@tagged('-at_install', 'post_install', 'fp_perms')
|
|
class TestTeamPage(TransactionCase):
|
|
"""Phase F — Owner-only Team management page.
|
|
Covers x_fc_plating_role compute/inverse + audit chatter + menu visibility."""
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
Users = self.env['res.users'].with_context(no_reset_password=True)
|
|
self.owner = Users.create({
|
|
'login': 'team_owner', 'name': 'Team Owner',
|
|
'email': 'team_owner@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_owner').id])],
|
|
})
|
|
self.target = Users.create({
|
|
'login': 'team_target', 'name': 'Team Target',
|
|
'email': 'team_target@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_technician').id])],
|
|
})
|
|
|
|
def test_compute_returns_technician(self):
|
|
self.assertEqual(self.target.x_fc_plating_role, 'technician')
|
|
|
|
def test_compute_picks_highest_role(self):
|
|
# Add Manager group on top of Technician
|
|
self.target.write({'group_ids': [(4, self.env.ref('fusion_plating.group_fp_manager').id)]})
|
|
self.target.invalidate_recordset(['x_fc_plating_role'])
|
|
self.assertEqual(self.target.x_fc_plating_role, 'manager')
|
|
|
|
def test_inverse_sets_only_chosen_role(self):
|
|
self.target.with_user(self.owner).x_fc_plating_role = 'shop_manager'
|
|
# Shop Manager group should be present, Technician should be ABSENT
|
|
sm = self.env.ref('fusion_plating.group_fp_shop_manager_v2')
|
|
tech = self.env.ref('fusion_plating.group_fp_technician')
|
|
self.assertIn(sm, self.target.groups_id)
|
|
# Technician is implied via shop_manager_v2.implied_ids → so it IS in user's
|
|
# transitive group set. But the inverse should NOT have ADDED it directly.
|
|
# Verify by checking groups_id (which Odoo stores as the union of explicit
|
|
# + implied groups) — Technician will be present via implication. That's
|
|
# correct. What we want to verify is no OTHER plating role is set explicitly.
|
|
# Easier assertion: after setting to shop_manager, compute should return
|
|
# shop_manager (highest plating role held).
|
|
self.target.invalidate_recordset(['x_fc_plating_role'])
|
|
self.assertEqual(self.target.x_fc_plating_role, 'shop_manager')
|
|
|
|
def test_inverse_to_no_clears_all_plating_roles(self):
|
|
# Start as Manager
|
|
self.target.with_user(self.owner).x_fc_plating_role = 'manager'
|
|
self.target.invalidate_recordset(['x_fc_plating_role'])
|
|
self.assertEqual(self.target.x_fc_plating_role, 'manager')
|
|
# Set to 'no'
|
|
self.target.with_user(self.owner).x_fc_plating_role = 'no'
|
|
self.target.invalidate_recordset(['x_fc_plating_role'])
|
|
# Verify no plating group remains
|
|
plating_groups = [
|
|
self.env.ref(f'fusion_plating.group_fp_{x}', raise_if_not_found=False)
|
|
for x in ('technician', 'sales_rep', 'shop_manager_v2',
|
|
'sales_manager', 'manager', 'quality_manager', 'owner')
|
|
]
|
|
for g in plating_groups:
|
|
if g:
|
|
self.assertNotIn(g, self.target.groups_id,
|
|
f'{g.name} should be removed when role=no')
|
|
self.assertEqual(self.target.x_fc_plating_role, 'no')
|
|
|
|
def test_inverse_posts_chatter_audit(self):
|
|
before = self.target.message_ids
|
|
self.target.with_user(self.owner).x_fc_plating_role = 'manager'
|
|
after = self.target.message_ids - before
|
|
self.assertTrue(after, 'Role change must post a chatter message')
|
|
# Verify the message body mentions the role change
|
|
bodies = ' '.join(after.mapped('body'))
|
|
self.assertIn('manager', bodies.lower())
|
|
|
|
def test_team_menu_visible_to_owner(self):
|
|
menu = self.env.ref('fusion_plating.menu_fp_team', raise_if_not_found=False)
|
|
if not menu:
|
|
self.skipTest('menu_fp_team not found')
|
|
visible = self.env['ir.ui.menu'].with_user(self.owner).search_count([('id', '=', menu.id)])
|
|
self.assertTrue(visible)
|
|
|
|
def test_team_menu_hidden_from_manager(self):
|
|
menu = self.env.ref('fusion_plating.menu_fp_team', raise_if_not_found=False)
|
|
if not menu:
|
|
self.skipTest('menu_fp_team not found')
|
|
mgr = self.env['res.users'].with_context(no_reset_password=True).create({
|
|
'login': 'team_mgr', 'name': 'Team Mgr',
|
|
'email': 'team_mgr@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref('fusion_plating.group_fp_manager').id])],
|
|
})
|
|
visible = self.env['ir.ui.menu'].with_user(mgr).search_count([('id', '=', menu.id)])
|
|
self.assertFalse(visible, 'Manager must not see Team menu (Owner-only)')
|
|
|
|
def test_cgp_do_field_on_company(self):
|
|
co = self.env.company
|
|
self.assertTrue(hasattr(co, 'x_fc_cgp_designated_official_id'),
|
|
'res.company must have x_fc_cgp_designated_official_id field')
|
|
|
|
def test_nadcap_authority_field_on_company(self):
|
|
co = self.env.company
|
|
self.assertTrue(hasattr(co, 'x_fc_nadcap_authority_user_id'),
|
|
'res.company must have x_fc_nadcap_authority_user_id field')
|