0047f49d2c
Pre-deploy fixes for Phase 1 permissions overhaul branch (catches by
final-reviewer subagent + main session).
CRITICAL FIXES:
C1: groups_id -> group_ids (Odoo 19 field rename). Affected ~30 sites
across 4 model files, 1 view, 7 test files. Documented project
gotcha (feedback_odoo19_groups_id_renamed.md) that the implementer
subagents missed because they don't see user memory.
C2: action_fp_resolve_plating_landing server action now calls
env['ir.actions.act_window'].sudo()._fp_resolve_landing_for_current_user()
instead of the old inline priority chain. Phase E's role-based
dispatch was previously dead code.
C3: New migrations/19.0.21.1.0/post-migrate.py triggers
_fp_post_init_role_migration(env) on -u. post_init_hook only fires
on INSTALL in Odoo 19, not UPGRADE -- so Phase H's preview creation
wouldn't have auto-fired on entech without this script. Module
version bumped to 19.0.21.1.0 to match the migration directory.
C4: Team kanban template rewritten for Odoo 19 (<t t-name='card'> with
semantic <aside>/<main>) instead of legacy <t t-name='kanban-box'>.
Previous template threw 'Missing card template' at render.
IMPORTANT FIXES:
I1: SO state=sent Confirm button (id='action_confirm') now also gated
to group_fp_sales_manager. Previously only the state=draft button
was gated; Sales Reps could send-and-confirm via the secondary path.
I2: Designated Officials picker domain uses all_group_ids (transitive)
instead of group_ids (explicit only). Owner users now correctly
appear as eligible CGP DO candidates via the implied_ids chain.
I3: test_menu_visibility.py compliance hub xmlid corrected to
fusion_plating.menu_fp_compliance_hub (was
fusion_plating_compliance.menu_fp_compliance_hub which doesn't exist
-- the hub menu is defined in core's fp_menu.xml). Tests were
silently skipTest-ing.
I4: _inverse_plating_role chatter audit reads old role from DB via SQL
(bypasses cache) so 'old -> new' displays actual values, and
short-circuits no-op writes.
I5: _FP_ROLE_MAPPING_RULES reordered: cgp_designated_official fires
BEFORE admin/uid_1_or_2 so admin+DO users keep the capability_delta
marker that triggers res.company.x_fc_cgp_designated_official_id
auto-set during migration.
I6: _cron_purge_expired_migrations skips groups with active users
instead of unlink-ing unconditionally. Defense against rollback
safety being bypassed by manual role assignments post-migration.
CLAUDE.md updated with 3 new durable rules (13b kanban card template,
13c group_ids vs all_group_ids, 13d post_init_hook only on install).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
86 lines
3.8 KiB
Python
86 lines
3.8 KiB
Python
from odoo.tests.common import TransactionCase, tagged
|
|
|
|
|
|
@tagged('-at_install', 'post_install', 'fp_perms')
|
|
class TestMenuVisibility(TransactionCase):
|
|
"""Section 2.F of spec: per-role menu render matrix."""
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
Users = self.env['res.users'].with_context(no_reset_password=True)
|
|
def mk(name, xmlid):
|
|
return Users.create({
|
|
'login': f'menu_{name}', 'name': f'Menu Test {name}',
|
|
'email': f'menu_{name}@example.com',
|
|
'group_ids': [(6, 0, [self.env.ref(xmlid).id])] if xmlid else [(6, 0, [])],
|
|
})
|
|
# "No" user has only base.group_user — no plating group
|
|
no_user = Users.create({
|
|
'login': 'menu_no', 'name': 'Menu Test no',
|
|
'email': 'menu_no@example.com',
|
|
})
|
|
no_user.write({'group_ids': [(6, 0, [self.env.ref('base.group_user').id])]})
|
|
self.u_no = no_user
|
|
self.u_tech = mk('tech', 'fusion_plating.group_fp_technician')
|
|
self.u_sr = mk('sr', 'fusion_plating.group_fp_sales_rep')
|
|
self.u_sm = mk('sm', 'fusion_plating.group_fp_shop_manager_v2')
|
|
self.u_smg = mk('smg', 'fusion_plating.group_fp_sales_manager')
|
|
self.u_mgr = mk('mgr', 'fusion_plating.group_fp_manager')
|
|
self.u_qm = mk('qm', 'fusion_plating.group_fp_quality_manager')
|
|
self.u_owner = mk('owner', 'fusion_plating.group_fp_owner')
|
|
|
|
def _visible(self, user, menu_xmlid):
|
|
menu = self.env.ref(menu_xmlid, raise_if_not_found=False)
|
|
if not menu:
|
|
return None # menu not installed
|
|
# An "invisible" menu is one the user can't read
|
|
return bool(self.env['ir.ui.menu'].with_user(user).search_count([('id', '=', menu.id)]))
|
|
|
|
def test_no_sees_no_plating_root(self):
|
|
result = self._visible(self.u_no, 'fusion_plating.menu_fp_root')
|
|
if result is None:
|
|
self.skipTest('Plating root menu not found')
|
|
self.assertFalse(result, '"No" role must not see Plating root')
|
|
|
|
def test_technician_sees_shop_floor(self):
|
|
result = self._visible(self.u_tech, 'fusion_plating_shopfloor.menu_fp_shopfloor')
|
|
if result is None:
|
|
self.skipTest('Shop Floor menu not found')
|
|
self.assertTrue(result)
|
|
|
|
def test_technician_does_not_see_sales(self):
|
|
result = self._visible(self.u_tech, 'fusion_plating_configurator.menu_fp_sales')
|
|
if result is None:
|
|
self.skipTest('Sales menu not found')
|
|
self.assertFalse(result, 'Technician must not see Sales & Quoting')
|
|
|
|
def test_sales_rep_sees_sales(self):
|
|
result = self._visible(self.u_sr, 'fusion_plating_configurator.menu_fp_sales')
|
|
if result is None:
|
|
self.skipTest('Sales menu not found')
|
|
self.assertTrue(result)
|
|
|
|
def test_sales_rep_does_not_see_shop_floor(self):
|
|
result = self._visible(self.u_sr, 'fusion_plating_shopfloor.menu_fp_shopfloor')
|
|
if result is None:
|
|
self.skipTest('Shop Floor menu not found')
|
|
self.assertFalse(result, 'Sales Rep must not see Shop Floor')
|
|
|
|
def test_manager_sees_quality(self):
|
|
result = self._visible(self.u_mgr, 'fusion_plating_quality.menu_fp_quality')
|
|
if result is None:
|
|
self.skipTest('Quality menu not found')
|
|
self.assertTrue(result)
|
|
|
|
def test_manager_does_not_see_compliance(self):
|
|
result = self._visible(self.u_mgr, 'fusion_plating.menu_fp_compliance_hub')
|
|
if result is None:
|
|
self.skipTest('Compliance hub not found')
|
|
self.assertFalse(result, 'Manager must not see Compliance hub')
|
|
|
|
def test_qm_sees_compliance(self):
|
|
result = self._visible(self.u_qm, 'fusion_plating.menu_fp_compliance_hub')
|
|
if result is None:
|
|
self.skipTest('Compliance hub not found')
|
|
self.assertTrue(result)
|