Files
Odoo-Modules/fusion_plating/fusion_plating_jobs
gsinghpal de3ec7d97a feat(plating-sec): SO confirm gate + fix _administrator typo + Python sweep
Phase G of permissions overhaul.

G2: sale.order.action_confirm now requires group_fp_sales_manager
(spec Section 2.B). Sales Reps can save drafts but cannot move SOs
to 'sale' state. UserError raised with clear message if attempted.

G3: Fixed audit-finding-11 typo bug in 2 files. The original code
checked has_group('fusion_plating.group_fusion_plating_administrator'),
an xmlid that has NEVER existed - so the gate always returned False
and only the Manager-side check actually fired. Fixed both:
  - fusion_plating_invoicing/models/res_partner.py:34
  - fusion_plating_configurator/wizard/fp_direct_order_wizard.py:467
Both now check has_group('fusion_plating.group_fp_manager') which
transitively includes Owner via implied_ids.

G4: Swept all Python has_group() calls to reference new group xmlids.
Backward-compat keeps old refs working today (Phase A's implied_ids),
but the sweep ensures correctness after the 30-day rollback window
deletes old groups. Replacements:
  group_fusion_plating_operator    -> group_fp_technician
  group_fusion_plating_supervisor  -> group_fp_shop_manager_v2
  group_fusion_plating_manager     -> group_fp_manager
  group_fusion_plating_admin       -> group_fp_owner
  group_fusion_plating_cgp_officer -> group_fp_quality_manager
  group_fusion_plating_cgp_designated_official -> group_fp_owner
  group_fp_estimator               -> group_fp_sales_rep
  group_fp_accounting              -> group_fp_manager
  group_fp_receiving               -> group_fp_shop_manager_v2
  group_fp_shop_manager (legacy)   -> group_fp_manager

G1: test_sales_manager_gate.py covers the new confirm gate (SR
blocked, SMg allowed, Manager allowed via diamond implication).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-24 02:11:35 -04:00
..
2026-04-26 10:46:44 -04:00
2026-05-17 03:20:33 -04:00
2026-05-21 03:37:25 -04:00
2026-04-28 19:39:37 -04:00

fusion_plating_jobs

Native plating job bridge — wires fp.job and fp.job.step (defined in fusion_plating core, Phase 1 of the migration spec dated 2026-04-25) into the rest of the Fusion Plating module family: configurator, portal, logistics, quality, certificates, batches, KPI, notifications, reports.

Coexists with fusion_plating_bridge_mrp during the migration period. The x_fc_use_native_jobs settings flag (default: False) toggles the behaviour. When False, SO confirm continues to create mrp.production records through bridge_mrp. When True, SO confirm creates fp.job records here.

See docs/superpowers/specs/2026-04-25-fp-native-job-model-design.md for full design rationale and §6 of the implementation plan for phase breakdown.

Phase 6 — deferred items

Phase 6 originally scoped the full operator UI rewrite. With Tailscale SSH to entech currently unavailable we cannot live-test OWL/JS in the browser, so Phase 6 ships a lean version: the data-layer endpoints land now, the rendering UI lands later.

Deferred to post-cutover hardening:

  • Plant Overview kanban over fp.job.step — replaces fusion_plating_shopfloor's mrp.workorder kanban.
  • Tablet Station UI rewrite over fp.job / fp.job.step.
  • Manager Dashboard rewrite.
  • Process Tree OWL component — currently a stub: /fp/jobs/process_tree returns the serialized recipe tree as JSON, but the OWL component to render it is not built.

Rationale: these are large OWL/JS components that need live in-browser verification on entech. Under the migration's parallel-coexistence strategy, operators continue using the existing shopfloor UI (bound to mrp.workorder) until cutover. After cutover, the operator UI rewrite becomes its own focused project — the data layer (fp.job, fp.job.step, time logs, timestamps) is fully in place from Phase 15.

Phase 6 — what shipped

  • /fp/job/<id> — scan-redirect controller. The fp.job sticker QR encodes this URL. Routes managers to the fp.job form; routes operators to the same form for now (will swap to the process tree client action once the OWL component lands).
  • /fp/jobs/process_tree — JSON-RPC endpoint that returns the recipe tree for a job, with each node tagged by its matching fp.job.step state, ready for an OWL component to consume.