ee80673579
Two bugs fixed in one drop, both targeting the contract review (QA-005)
enforcement gap reported on entech.
## Bug 1 — WO step routed to wrong wizard
Symptom: clicking Finish & Next or Record on a Contract Review step in
WH/JOB/00339 opened the generic measurement wizard with three fake
prompts (Reviewer Initials / Date Reviewed / QA-005 Approved). No path
to the actual QA-005 form from the work order.
Root cause: action_finish_and_advance + action_open_input_wizard had no
branch for recipe_node.default_kind == 'contract_review'. The step.kind
mapping collapses contract_review -> 'other' so kind-based detection
wouldn't have worked either; gate has to live at the recipe-node layer.
Fix in fusion_plating_jobs/models/fp_job_step.py (v19.0.8.14.6):
- action_finish_and_advance:329 calls _fp_contract_review_redirect
before the input-wizard branch
- action_open_input_wizard:844 same gate, keeps Record button consistent
- _fp_contract_review_redirect:866 (new) returns the part's
action_start_contract_review() unless review.state in
(complete, dismissed) — gate clears so the step can finish after
the operator signs QA-005.
## Bug 2 — Part create did not enforce contract review
Symptom: spec called for a banner-only UX. User wanted true automatic
enforcement on first part creation under an enforced customer.
Fix in fusion_plating_quality/models/fp_part_catalog.py (v19.0.4.10.0):
- @api.model_create_multi def create() override
- _fp_enforce_contract_review_on_create() helper auto-stages the
fp.contract.review record AND surfaces three prominent reminders:
1. Sticky bus.bus warning toast (top-right, doesn't auto-dismiss)
2. mail.activity (To Do) on the part for the current user
3. Smart button on the part form lights up (review now exists)
- Idempotent: skips parts that already carry a review id
- Soft-fails: bus or activity outage doesn't block part creation
- create()-only — write/update flows never re-trigger
Sub 4's existing info banner stays as a fourth surface.
## Tests
- fusion_plating_jobs/tests/test_fp_job_extensions.py:
+TestContractReviewStepRouting (5 tests covering both routing methods,
the complete/dismissed gate-clear, and non-CR step regression)
- fusion_plating_quality/tests/test_part_catalog_contract_review_enforcement.py
(NEW): 9 tests covering auto-create, batch create, idempotency,
activity surface, bus surface, write-must-not-retrigger, soft-fail.
- docs/superpowers/tests/2026-04-22-sub4-smoke.py: flipped the
"no review yet" assertion to "review auto-created" to match new
behavior. Sign-flow assertions unchanged.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fusion_plating_jobs
Native plating job bridge — wires fp.job and fp.job.step (defined in
fusion_plating core, Phase 1 of the migration spec dated 2026-04-25)
into the rest of the Fusion Plating module family: configurator, portal,
logistics, quality, certificates, batches, KPI, notifications, reports.
Coexists with fusion_plating_bridge_mrp during the migration period.
The x_fc_use_native_jobs settings flag (default: False) toggles the
behaviour. When False, SO confirm continues to create mrp.production
records through bridge_mrp. When True, SO confirm creates fp.job
records here.
See docs/superpowers/specs/2026-04-25-fp-native-job-model-design.md
for full design rationale and §6 of the implementation plan for phase
breakdown.
Phase 6 — deferred items
Phase 6 originally scoped the full operator UI rewrite. With Tailscale SSH to entech currently unavailable we cannot live-test OWL/JS in the browser, so Phase 6 ships a lean version: the data-layer endpoints land now, the rendering UI lands later.
Deferred to post-cutover hardening:
- Plant Overview kanban over
fp.job.step— replacesfusion_plating_shopfloor'smrp.workorderkanban. - Tablet Station UI rewrite over
fp.job/fp.job.step. - Manager Dashboard rewrite.
- Process Tree OWL component — currently a stub:
/fp/jobs/process_treereturns the serialized recipe tree as JSON, but the OWL component to render it is not built.
Rationale: these are large OWL/JS components that need live in-browser
verification on entech. Under the migration's parallel-coexistence
strategy, operators continue using the existing shopfloor UI (bound to
mrp.workorder) until cutover. After cutover, the operator UI rewrite
becomes its own focused project — the data layer (fp.job,
fp.job.step, time logs, timestamps) is fully in place from
Phase 1–5.
Phase 6 — what shipped
/fp/job/<id>— scan-redirect controller. The fp.job sticker QR encodes this URL. Routes managers to thefp.jobform; routes operators to the same form for now (will swap to the process tree client action once the OWL component lands)./fp/jobs/process_tree— JSON-RPC endpoint that returns the recipe tree for a job, with each node tagged by its matchingfp.job.stepstate, ready for an OWL component to consume.