469a9d0732
Following the workforce-E2E + required-fields audit, ship the first 6 high-priority gates so critical workflow + compliance fields can no longer be left empty by accident. **1. Invoice payment terms (account.move)** - create() now auto-inherits `invoice_payment_term_id` from partner.property_payment_term_id when missing - action_post() raises UserError if still missing — accountant must pick one before posting (prevents silent "immediate" due-date) **2. MO facility (mrp.production)** - action_confirm() auto-derives `x_fc_facility_id` if unset, in order: SO override → res.company.x_fc_default_facility_id → first active facility — then HARD GATES: raises UserError if still empty. Without facility every downstream record (WO, batch, bath log, cert) is missing the "where" half of the audit trail. **3. WO facility (mrp.workorder)** - Switched `x_fc_facility_id` from related (workcenter only) to a proper compute that falls back to production_id.x_fc_facility_id. Stub workcenters auto-created from process node names usually have no facility — the MO always does (from #2 above). **4. Thickness reading calibration_std (fp.thickness.reading)** - `calibration_std_ref` is now `required=True` with sensible default ("NiP/Al STD SET SN 100174568"). Nadcap mandates which calibration standard the gauge was checked against — without it the cert data has no chain back to a metrology record. **5. Delivery POD gate (fusion.plating.delivery)** - action_mark_delivered() raises UserError if no `pod_id`. Driver must capture POD on the iPad (recipient signature + photos + notes) BEFORE marking delivered. Without POD there's no signed receipt to back the invoice or defend a delivery dispute. **6. Certificate spec_reference gate (fp.certificate)** - action_issue() raises UserError if no `spec_reference`. The cert ATTESTS to a spec — leaving it blank produces a piece of paper that AS9100 / Nadcap auditors will (rightfully) reject. **Simulator updated**: scripts/fp_e2e_workforce.py - Sets net-30 on the test customer + ensures a default facility - New PHASE 4c: 5 negative tests (one per new gate), each wrapped in a SAVEPOINT so SQL constraint violations don't abort the txn - Driver now creates POD on iPad BEFORE marking delivered **Final E2E**: 48 PASS / 2 WARN / 0 FAIL out of 50 checks. The 2 remaining WARNs (bake-window auto-create, first-piece gate) are expected behaviour — both are coating-driven and the test coating intentionally doesn't trigger them. All 7 negative tests now pass: ✓ Test 1: WO start without operator → blocked ✓ Test 2: WO start on wet WO without bath/tank → blocked ✓ Test 3: MO confirm without facility → blocked ✓ Test 4: Cert issue without spec_reference → blocked ✓ Test 5: Delivery delivered without POD → blocked ✓ Test 6: Invoice post without payment terms → blocked ✓ Test 7: Thickness reading without cal std → blocked (DB NOT NULL) Audit script (scripts/fp_required_fields_audit.py) committed too — it's the diagnostic that surfaced these gaps and can be re-run to catch new ones. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
59 lines
2.7 KiB
Python
59 lines
2.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2026 Nexa Systems Inc.
|
|
# License OPL-1 (Odoo Proprietary License v1.0)
|
|
# Part of the Fusion Plating product family.
|
|
|
|
from odoo import api, models, _
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class AccountMove(models.Model):
|
|
_inherit = 'account.move'
|
|
|
|
@api.model_create_multi
|
|
def create(self, vals_list):
|
|
"""Auto-inherit payment terms from the customer when missing.
|
|
|
|
Customers usually have a default `property_payment_term_id`
|
|
(Net-30, Net-60, COD…). When an invoice is created without
|
|
terms, the due date silently defaults to "immediate" — wrong
|
|
for almost every B2B customer. Pull the partner's terms in
|
|
before super so the invoice is born with the right schedule.
|
|
"""
|
|
Partner = self.env['res.partner']
|
|
for vals in vals_list:
|
|
if vals.get('move_type') in ('out_invoice', 'out_refund'):
|
|
if not vals.get('invoice_payment_term_id') and vals.get('partner_id'):
|
|
partner = Partner.browse(vals['partner_id'])
|
|
if partner.property_payment_term_id:
|
|
vals['invoice_payment_term_id'] = partner.property_payment_term_id.id
|
|
return super().create(vals_list)
|
|
|
|
def action_post(self):
|
|
"""Block post when:
|
|
• customer is on account hold (existing rule), or
|
|
• the invoice has no payment term (auto-fill missed it AND
|
|
partner had no default — accountant must pick one).
|
|
"""
|
|
for move in self:
|
|
if move.move_type in ('out_invoice', 'out_refund') and move.partner_id:
|
|
if move.partner_id.x_fc_account_hold:
|
|
is_manager = self.env.user.has_group(
|
|
'fusion_plating.group_fusion_plating_manager'
|
|
)
|
|
if not is_manager:
|
|
raise UserError(_(
|
|
'Cannot post invoice — customer "%s" is on account hold.\n'
|
|
'Reason: %s\n\n'
|
|
'Contact a manager to override.'
|
|
) % (move.partner_id.name,
|
|
move.partner_id.x_fc_account_hold_reason or 'No reason specified'))
|
|
if not move.invoice_payment_term_id:
|
|
raise UserError(_(
|
|
'Cannot post invoice "%s" — no payment terms set.\n\n'
|
|
'Pick payment terms (Net-30, COD, etc.) on the invoice, '
|
|
'or set a default on the customer "%s" so future '
|
|
'invoices inherit it automatically.'
|
|
) % (move.name or move.display_name, move.partner_id.name))
|
|
return super().action_post()
|