admin/Odoo-Modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(fusion_accounting_bank_rec): acceptSuggestion double-decrement count

Browse Source 
Optimistic remove was decrementing unreconciledCount before assigning
the authoritative server count, leading to off-by-one. Order swapped:
remove first, then overwrite with server count.

Caught by Task 28 subagent self-review.

Made-with: Cursor
This commit is contained in:
gsinghpal
2026-04-19 12:28:34 -04:00
parent d4dbca5927
commit a4a9692888
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fusion_accounting_bank_rec/static/src/services/bank_reconciliation_service.js
View File

@@ -149,9 +149,8 @@ export class BankReconciliationService {
const result = await this.rpc(`${ENDPOINT_BASE}/accept_suggestion`, { const result = await this.rpc(`${ENDPOINT_BASE}/accept_suggestion`, {
suggestion_id: suggestionId, suggestion_id: suggestionId,
}); });
this.state.unreconciledCount = result.unreconciled_count_after;
// Optimistic remove from list
this._removeReconciledLineFromState(this.state.selectedLineId); this._removeReconciledLineFromState(this.state.selectedLineId);
this.state.unreconciledCount = result.unreconciled_count_after;
this.notification.add("Reconciliation accepted", { type: "success" }); this.notification.add("Reconciliation accepted", { type: "success" });
return result; return result;
} catch (err) { } catch (err) {